mbox series

[v3,0/2] Fixes for fscache volume operations

Message ID 20230113115211.2895845-1-houtao@huaweicloud.com
Headers
Series Fixes for fscache volume operations |

Message

Hou Tao Jan. 13, 2023, 11:52 a.m. UTC 
  From: Hou Tao <houtao1@huawei.com>

Hi,

The patchset includes two fixes for fscache volume operations: patch 1
fixes the hang problem during volume acquisition when the volume
acquisition process waits for the freeing of relinquished volume, patch
2 adds the missing memory barrier in fscache_create_volume_work() and it
is spotted through code review when checking whether or not these is
missing smp_mb() before invoking wake_up_bit().

Comments are always welcome.

Chang Log:
v3:
 * Use clear_and_wake_up_bit() helper (Suggested by Jingbo Xu)
 * Tidy up commit message and add Reviewed-by tag

v2: https://listman.redhat.com/archives/linux-cachefs/2022-December/007402.html
 * rebased on v6.1-rc1
 * Patch 1: use wait_on_bit() instead (Suggested by David)
 * Patch 2: add the missing smp_mb() in fscache_create_volume_work()

v1: https://listman.redhat.com/archives/linux-cachefs/2022-December/007384.html


Hou Tao (2):
  fscache: Use wait_on_bit() to wait for the freeing of relinquished
    volume
  fscache: Use clear_and_wake_up_bit() in fscache_create_volume_work()

 fs/fscache/volume.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Comments

Hou Tao Jan. 30, 2023, 10:56 a.m. UTC | #1 
Hi David,

Could you please pick it up for v6.2 ?

On 1/13/2023 7:52 PM, Hou Tao wrote:
> From: Hou Tao <houtao1@huawei.com>
>
> Hi,
>
> The patchset includes two fixes for fscache volume operations: patch 1
> fixes the hang problem during volume acquisition when the volume
> acquisition process waits for the freeing of relinquished volume, patch
> 2 adds the missing memory barrier in fscache_create_volume_work() and it
> is spotted through code review when checking whether or not these is
> missing smp_mb() before invoking wake_up_bit().
>
> Comments are always welcome.
>
> Chang Log:
> v3:
>  * Use clear_and_wake_up_bit() helper (Suggested by Jingbo Xu)
>  * Tidy up commit message and add Reviewed-by tag
>
> v2: https://listman.redhat.com/archives/linux-cachefs/2022-December/007402.html
>  * rebased on v6.1-rc1
>  * Patch 1: use wait_on_bit() instead (Suggested by David)
>  * Patch 2: add the missing smp_mb() in fscache_create_volume_work()
>
> v1: https://listman.redhat.com/archives/linux-cachefs/2022-December/007384.html
>
>
> Hou Tao (2):
>   fscache: Use wait_on_bit() to wait for the freeing of relinquished
>     volume
>   fscache: Use clear_and_wake_up_bit() in fscache_create_volume_work()
>
>  fs/fscache/volume.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>