mbox series

[V2,0/7] Add eqos and fec support for imx93

Message ID 20230113033347.264135-1-xiaoning.wang@nxp.com
Headers
Series Add eqos and fec support for imx93 |

Message

Clark Wang Jan. 13, 2023, 3:33 a.m. UTC 
  Hi,

This patchset add imx93 support for dwmac-imx glue driver.
There are some changes of GPR implement.
And add fec and eqos nodes for imx93 dts.

Clark Wang (7):
  net: stmmac: add imx93 platform support
  dt-bindings: add mx93 description
  dt-bindings: net: fec: add mx93 description
  arm64: dts: imx93: add eqos support
  arm64: dts: imx93: add FEC support
  arm64: dts: imx93-11x11-evk: enable eqos
  arm64: dts: imx93-11x11-evk: enable fec function

 .../devicetree/bindings/net/fsl,fec.yaml      |  1 +
 .../bindings/net/nxp,dwmac-imx.yaml           |  4 +-
 .../boot/dts/freescale/imx93-11x11-evk.dts    | 78 +++++++++++++++++++
 arch/arm64/boot/dts/freescale/imx93.dtsi      | 48 ++++++++++++
 .../net/ethernet/stmicro/stmmac/dwmac-imx.c   | 55 +++++++++++--
 5 files changed, 180 insertions(+), 6 deletions(-)

Comments

Paolo Abeni Jan. 17, 2023, 8:27 a.m. UTC | #1 
Hi,

On Fri, 2023-01-13 at 11:33 +0800, Clark Wang wrote:
> This patchset add imx93 support for dwmac-imx glue driver.
> There are some changes of GPR implement.
> And add fec and eqos nodes for imx93 dts.
> 
> Clark Wang (7):
>   net: stmmac: add imx93 platform support
>   dt-bindings: add mx93 description
>   dt-bindings: net: fec: add mx93 description
>   arm64: dts: imx93: add eqos support
>   arm64: dts: imx93: add FEC support
>   arm64: dts: imx93-11x11-evk: enable eqos
>   arm64: dts: imx93-11x11-evk: enable fec function
> 
>  .../devicetree/bindings/net/fsl,fec.yaml      |  1 +
>  .../bindings/net/nxp,dwmac-imx.yaml           |  4 +-
>  .../boot/dts/freescale/imx93-11x11-evk.dts    | 78 +++++++++++++++++++
>  arch/arm64/boot/dts/freescale/imx93.dtsi      | 48 ++++++++++++
>  .../net/ethernet/stmicro/stmmac/dwmac-imx.c   | 55 +++++++++++--
>  5 files changed, 180 insertions(+), 6 deletions(-)

It's not clear to me if the whole series should go via netdev. I
think/fear such option could cause later conflicts for Linus. Does it
make sense to split this in 2 chunks, and have only the first 3 patches
merged via netdev?

Thanks!

Paolo
patchwork-bot+netdevbpf@kernel.org Jan. 18, 2023, 1:10 p.m. UTC | #2 
Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Fri, 13 Jan 2023 11:33:40 +0800 you wrote:
> Hi,
> 
> This patchset add imx93 support for dwmac-imx glue driver.
> There are some changes of GPR implement.
> And add fec and eqos nodes for imx93 dts.
> 
> Clark Wang (7):
>   net: stmmac: add imx93 platform support
>   dt-bindings: add mx93 description
>   dt-bindings: net: fec: add mx93 description
>   arm64: dts: imx93: add eqos support
>   arm64: dts: imx93: add FEC support
>   arm64: dts: imx93-11x11-evk: enable eqos
>   arm64: dts: imx93-11x11-evk: enable fec function
> 
> [...]

Here is the summary with links:
  - [V2,1/7] net: stmmac: add imx93 platform support
    https://git.kernel.org/netdev/net-next/c/e5bf35ca4547
  - [V2,2/7] dt-bindings: add mx93 description
    https://git.kernel.org/netdev/net-next/c/b2274ffe90be
  - [V2,3/7] dt-bindings: net: fec: add mx93 description
    https://git.kernel.org/netdev/net-next/c/f743e7664dca
  - [V2,4/7] arm64: dts: imx93: add eqos support
    https://git.kernel.org/netdev/net-next/c/1f4263ea6a4b
  - [V2,5/7] arm64: dts: imx93: add FEC support
    https://git.kernel.org/netdev/net-next/c/eaaf47108540
  - [V2,6/7] arm64: dts: imx93-11x11-evk: enable eqos
    https://git.kernel.org/netdev/net-next/c/1b110dd678d9
  - [V2,7/7] arm64: dts: imx93-11x11-evk: enable fec function
    https://git.kernel.org/netdev/net-next/c/c897dc7f3a8d

You are awesome, thank you!
Shawn Guo Jan. 26, 2023, 1:02 a.m. UTC | #3 
On Tue, Jan 17, 2023 at 09:27:56AM +0100, Paolo Abeni wrote:
> Hi,
> 
> On Fri, 2023-01-13 at 11:33 +0800, Clark Wang wrote:
> > This patchset add imx93 support for dwmac-imx glue driver.
> > There are some changes of GPR implement.
> > And add fec and eqos nodes for imx93 dts.
> > 
> > Clark Wang (7):
> >   net: stmmac: add imx93 platform support
> >   dt-bindings: add mx93 description
> >   dt-bindings: net: fec: add mx93 description
> >   arm64: dts: imx93: add eqos support
> >   arm64: dts: imx93: add FEC support
> >   arm64: dts: imx93-11x11-evk: enable eqos
> >   arm64: dts: imx93-11x11-evk: enable fec function
> > 
> >  .../devicetree/bindings/net/fsl,fec.yaml      |  1 +
> >  .../bindings/net/nxp,dwmac-imx.yaml           |  4 +-
> >  .../boot/dts/freescale/imx93-11x11-evk.dts    | 78 +++++++++++++++++++
> >  arch/arm64/boot/dts/freescale/imx93.dtsi      | 48 ++++++++++++
> >  .../net/ethernet/stmicro/stmmac/dwmac-imx.c   | 55 +++++++++++--
> >  5 files changed, 180 insertions(+), 6 deletions(-)
> 
> It's not clear to me if the whole series should go via netdev. I
> think/fear such option could cause later conflicts for Linus. Does it
> make sense to split this in 2 chunks, and have only the first 3 patches
> merged via netdev?

I share the same concern here.

David,

Could you *not* apply DTS patches in the future?  People often include
driver changes and corresponding DTS ones in a single series to ease
cross reviewing and testing.  If picking selected patches from a series
could a problem for your applying robot, we should probably start asking
people to split change-sets.

Shawn