From patchwork Thu Jan 12 13:04:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Martin_T=C5=AFma?= X-Patchwork-Id: 3906 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp3825567wrt; Thu, 12 Jan 2023 03:24:33 -0800 (PST) X-Google-Smtp-Source: AMrXdXshldo+CxK09vI6oUwZAi+HLkOkWjtMT5KEk0N8P6ukEgdMONlk6RKnKz0fDrKHOcJMaYfs X-Received: by 2002:a17:902:c643:b0:192:b6ca:200 with SMTP id s3-20020a170902c64300b00192b6ca0200mr41002806pls.3.1673522672993; Thu, 12 Jan 2023 03:24:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673522672; cv=none; d=google.com; s=arc-20160816; b=Ub5za/tV+Mskb92lmienOxkVLzQlDD8Vqd3bEri9yq06KmMyh6XDnIsy5Tge7tSOp6 n+iDeHY1Gmz+LQN84Y97pvgLEHnAbSFeoDRfmepIENHj9HDpMDrb4xjEAWmwQkmR5iri Yo/CIJByxfB0ih1uTzgqtINtUQ/3unvjA8AVVNWMTVYbAIh/22UMwEgVwRvrjEA0relY N+VnxKBLQeVsNaL+HqRmpYSDISi9LyTN9fdh566ERLgzonV7LvZN9ChzPKrxc7bmMxYz 8eqhkTJjJdN2O9CzAz59yXH5ldJmkUIVEUp9VQwKgJZvCQMTlcDjZPIdm3cbFAOcsoXR recg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=3JGlEBrkn+FucHUQHmNwr/Q7kZ3ivjK8b9S+xlDi6sA=; b=xPpUSv8DVeGaKMG7V51eY3E5vaugZQ8mLU7HM1R5RiE8n89YOzwYrHBdq/8vwE4PPp Dth6FTPvudolRYoaYkV0rHaZOCWBxBn9tG2BJsiqu8Be9cIV244XUDggT/5Q3s+bI4v9 jevQfQNsYvniF/wkFyjiw1dgoi/eyuUXWDqK0pUtr55DhtBL8Ty8PuKmlxNAnXaNoI/s nvWkF2IzojJEdps/ABNwGPXgzVIrMPRd+sa0Bi61Bq1TpbKr3klPhDXc8Om6l1ojA24D 2yPM7O1MeL7GhhUsXXM7pDpj5htxpKcX4fIm+N+HcuwqsLdTU3RyC57ALzlwQ9aVDWyo 3XCg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s11-20020a170902ea0b00b001931d382a3esi15874168plg.489.2023.01.12.03.24.20; Thu, 12 Jan 2023 03:24:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232183AbjALLMs (ORCPT + 99 others); Thu, 12 Jan 2023 06:12:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234619AbjALLLf (ORCPT ); Thu, 12 Jan 2023 06:11:35 -0500 Received: from mx.gpxsee.org (mx.gpxsee.org [37.205.14.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5AA2954D9A; Thu, 12 Jan 2023 03:03:35 -0800 (PST) Received: from mgb4.digiteq.red (unknown [62.77.71.229]) by mx.gpxsee.org (Postfix) with ESMTPSA id 7416CAEBA; Thu, 12 Jan 2023 12:03:32 +0100 (CET) From: tumic@gpxsee.org To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Lizhi Hou , =?utf-8?q?Martin_T=C5=AFma?= Subject: [RESEND PATCH v4 0/1] Digiteq Automotive MGB4 driver Date: Thu, 12 Jan 2023 14:04:57 +0100 Message-Id: <20230112130458.2836-1-tumic@gpxsee.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754815710143943564?= X-GMAIL-MSGID: =?utf-8?q?1754815710143943564?= From: Martin Tůma Hi, This patch adds a driver for the Digiteq Automotive MGB4 grabber card. MGB4 is a modular frame grabber PCIe card for automotive video interfaces (FPD-Link and GMSL for now). It is based on a Xilinx FPGA and uses their XDMA IP core for DMA transfers. Additionally, Xilinx I2C and SPI IP cores which already have drivers in linux are used in the design. The driver is a quite standard v4l2 driver, with one exception - there are a lot of sysfs options that may/must be set before opening the v4l2 device to adapt the card on a specific signal (see mgb4.rst for details) as the card must be able to work with various signal sources (or displays) that can not be auto-detected. I have run the driver through the v4l2-compliance test suite for both the input and the output and the results look fine to me (I can provide the output if required). The patch requires the new XDMA v10 driver from Xilinx/AMD from the dmaengine mailing list to compile/work: https://www.spinics.net/lists/dmaengine/msg32151.html Changes in v4: * Redesigned the signal change handling logic. Now using the propper timings API in the video input driver and a propper open() syscall check/logic in the video output driver. * Fixed all minor issues from v3 review. * 'checkpatch.pl --strict' used for checking the code. Changes in v3: * Rebased the DMA transfers part to use the new XDMA driver from Xilinx/AMD Changes in v2: * Completely rewritten the original Xilinx's XDMA driver to meet kernel code standards. * Added all required "to" and "cc" mail addresses. Martin Tůma (1): Added Digiteq Automotive MGB4 driver Documentation/admin-guide/media/mgb4.rst | 352 ++++++++ .../admin-guide/media/pci-cardlist.rst | 1 + .../admin-guide/media/v4l-drivers.rst | 1 + MAINTAINERS | 7 + drivers/media/pci/Kconfig | 1 + drivers/media/pci/Makefile | 1 + drivers/media/pci/mgb4/Kconfig | 17 + drivers/media/pci/mgb4/Makefile | 6 + drivers/media/pci/mgb4/mgb4_cmt.c | 247 ++++++ drivers/media/pci/mgb4/mgb4_cmt.h | 16 + drivers/media/pci/mgb4/mgb4_core.c | 642 ++++++++++++++ drivers/media/pci/mgb4/mgb4_core.h | 65 ++ drivers/media/pci/mgb4/mgb4_dma.c | 123 +++ drivers/media/pci/mgb4/mgb4_dma.h | 18 + drivers/media/pci/mgb4/mgb4_i2c.c | 141 +++ drivers/media/pci/mgb4/mgb4_i2c.h | 35 + drivers/media/pci/mgb4/mgb4_io.h | 39 + drivers/media/pci/mgb4/mgb4_regs.c | 30 + drivers/media/pci/mgb4/mgb4_regs.h | 35 + drivers/media/pci/mgb4/mgb4_sysfs.h | 18 + drivers/media/pci/mgb4/mgb4_sysfs_in.c | 780 ++++++++++++++++ drivers/media/pci/mgb4/mgb4_sysfs_out.c | 732 +++++++++++++++ drivers/media/pci/mgb4/mgb4_sysfs_pci.c | 86 ++ drivers/media/pci/mgb4/mgb4_trigger.c | 209 +++++ drivers/media/pci/mgb4/mgb4_trigger.h | 8 + drivers/media/pci/mgb4/mgb4_vin.c | 830 ++++++++++++++++++ drivers/media/pci/mgb4/mgb4_vin.h | 63 ++ drivers/media/pci/mgb4/mgb4_vout.c | 501 +++++++++++ drivers/media/pci/mgb4/mgb4_vout.h | 58 ++ 29 files changed, 5062 insertions(+) create mode 100644 Documentation/admin-guide/media/mgb4.rst create mode 100644 drivers/media/pci/mgb4/Kconfig create mode 100644 drivers/media/pci/mgb4/Makefile create mode 100644 drivers/media/pci/mgb4/mgb4_cmt.c create mode 100644 drivers/media/pci/mgb4/mgb4_cmt.h create mode 100644 drivers/media/pci/mgb4/mgb4_core.c create mode 100644 drivers/media/pci/mgb4/mgb4_core.h create mode 100644 drivers/media/pci/mgb4/mgb4_dma.c create mode 100644 drivers/media/pci/mgb4/mgb4_dma.h create mode 100644 drivers/media/pci/mgb4/mgb4_i2c.c create mode 100644 drivers/media/pci/mgb4/mgb4_i2c.h create mode 100644 drivers/media/pci/mgb4/mgb4_io.h create mode 100644 drivers/media/pci/mgb4/mgb4_regs.c create mode 100644 drivers/media/pci/mgb4/mgb4_regs.h create mode 100644 drivers/media/pci/mgb4/mgb4_sysfs.h create mode 100644 drivers/media/pci/mgb4/mgb4_sysfs_in.c create mode 100644 drivers/media/pci/mgb4/mgb4_sysfs_out.c create mode 100644 drivers/media/pci/mgb4/mgb4_sysfs_pci.c create mode 100644 drivers/media/pci/mgb4/mgb4_trigger.c create mode 100644 drivers/media/pci/mgb4/mgb4_trigger.h create mode 100644 drivers/media/pci/mgb4/mgb4_vin.c create mode 100644 drivers/media/pci/mgb4/mgb4_vin.h create mode 100644 drivers/media/pci/mgb4/mgb4_vout.c create mode 100644 drivers/media/pci/mgb4/mgb4_vout.h