From patchwork Wed Jan 11 13:01:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 3844 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp3131829wrt; Tue, 10 Jan 2023 21:05:09 -0800 (PST) X-Google-Smtp-Source: AMrXdXukC1uigPBia1mdupsgI4oHKOswNgfmGnL/w7gSenqBg3+JOn+rKe4mlPwbUXwa7IRPopjU X-Received: by 2002:a05:6a20:a590:b0:ac:29b4:11bc with SMTP id bc16-20020a056a20a59000b000ac29b411bcmr1482202pzb.21.1673413508781; Tue, 10 Jan 2023 21:05:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673413508; cv=none; d=google.com; s=arc-20160816; b=YJNNs/tQcGw/O00ejNNPPq+Wfqv/CICAf41X0BNasQUmX/89rGVmbMW4QwtSntIG8w HH3dUXLU52bFglKYU3aS2jM4Go9HndCAwF+LxhxHGd7aLkuEQb93+A1QdDaRDsl49PD/ fj/LaX0SZjppmN0xhM/1Z7NwvVuFpg4y/KkhHxQThp4Nagx9RG9rLSHyM1Vuhm7Mc0JO fL4OlvY6SU8MqPS72WnjX35gIuT2xH+3D3pjBpqyAhP8/Py0MiJQU8fAl7iekNOO67y0 NPHatKX6ZHqN1tF0soxr/a7QTg+gWvo2cSU+Ta2qWSzabckXA/jZAjy5EAZ3Zbg6V4fo EClQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=UCtsdsb9Cy8xM21dlgnWlKkYwBYpSOydTjxFoHI6n8k=; b=E8TrOCBhNMffoOM95I6rlomix+eox2LxL5trgsiGq24+7FJ3hoaV7e5H5hQrRtb4tp FrhJ7bIiNxzi6X32WxixNBB310DruESqZ9ECLRhTDxYp0OuOkLoSFT7GMLjXK64LNrl+ gitmr88bQ9+L34WMPEggn1+QHZVdbFCDMTspozy7MqFjX0Jv0T9nSDeKhiQazCUU+nus 4uWcp0M9o/cPkPosUfjkRWMmfuc0p50Edm4UhLhxNB6gQL27CHZqTPNieAQ1ZwZF+/bD VV5q3FLBgH9kgxcBcISeYeP/8hlesxs6JriLk1L+HQY+uF9SUjIYvECCvF7EqJPmzrKE EEzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n18-20020a63ee52000000b004a4eae7c943si13434897pgk.535.2023.01.10.21.04.55; Tue, 10 Jan 2023 21:05:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235452AbjAKFDt (ORCPT + 99 others); Wed, 11 Jan 2023 00:03:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233452AbjAKFDe (ORCPT ); Wed, 11 Jan 2023 00:03:34 -0500 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 211E7CE3A; Tue, 10 Jan 2023 21:03:32 -0800 (PST) Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4NsFv152Q5z4f3p0f; Wed, 11 Jan 2023 13:03:25 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP1 (Coremail) with SMTP id cCh0CgDX9S8fQ75jGl2gBQ--.10280S2; Wed, 11 Jan 2023 13:03:28 +0800 (CST) From: Kemeng Shi To: hch@lst.de, axboe@kernel.dk, dwagner@suse.de, hare@suse.de, ming.lei@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: john.garry@huawei.com, jack@suse.cz Subject: [PATCH v3 00/14] A few bugfix and cleanup patches for blk-mq Date: Wed, 11 Jan 2023 21:01:45 +0800 Message-Id: <20230111130159.3741753-1-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 X-CM-TRANSID: cCh0CgDX9S8fQ75jGl2gBQ--.10280S2 X-Coremail-Antispam: 1UD129KBjvJXoW7uF1xXF4kAFW8Jw4xAry7Jrb_yoW8uryrpF W3Ka13Gw4fXr17Xw1Syw47ZF9ayws7GrW7Xw13G3s5Xr4DCr18Gr4Iqa1fAFy0yFZ5Ca17 JF4Fv345KF1v937anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkFb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M2 8lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E 3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26r xl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv 0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUGVWUXwAv7VC2z2 80aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JMxAIw28I cxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2 IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI 42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42 IY6xAIw20EY4v20xvaj40_WFyUJVCq3wCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E 87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07j7NVkUUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754701243420224183?= X-GMAIL-MSGID: =?utf-8?q?1754701243420224183?= Hi, this series contain several bugfix patches to fix potential io hung and a few cleanup patches to remove stale codes and unnecessary check. Most changes are in request issue and dispatch path. Thanks. --- V3: -Collect Reviewed-by from Christoph -Add new patch "blk-mq: make blk_mq_commit_rqs a general function for all commits" suggested-by Christoph -Move patch "blk-mq: remove unncessary from_schedule parameter in blk_mq_plug_issue_direct" forwad. This is because of some abandoned work, no influence anyway. No special attention should be paied. -Make patch based on rewriten blk_mq_commit_rqs. V2: -Thanks Christoph for review and there are two fixes in v2 according to recommends from Christoph. 1)Avoid overly long line in patch "blk-mq: avoid sleep in blk_mq_alloc_request_hctx" 2)Check BLK_MQ_REQ_NOWAIT and BLK_MQ_REQ_RESERVED in two WARN_ON_ONCE --- Kemeng Shi (14): blk-mq: avoid sleep in blk_mq_alloc_request_hctx blk-mq: remove stale comment for blk_mq_sched_mark_restart_hctx blk-mq: wait on correct sbitmap_queue in blk_mq_mark_tag_wait blk-mq: Fix potential io hung for shared sbitmap per tagset blk-mq: remove unnecessary list_empty check in blk_mq_try_issue_list_directly blk-mq: remove unncessary from_schedule parameter in blk_mq_plug_issue_direct blk-mq: make blk_mq_commit_rqs a general function for all commits blk-mq: remove unncessary error count and commit in blk_mq_plug_issue_direct blk-mq: use blk_mq_commit_rqs helper in blk_mq_try_issue_list_directly blk-mq: simplify flush check in blk_mq_dispatch_rq_list blk-mq: remove unnecessary error count and check in blk_mq_dispatch_rq_list blk-mq: remove set of bd->last when get driver tag for next request fails blk-mq: use switch/case to improve readability in blk_mq_try_issue_list_directly blk-mq: correct stale comment of .get_budget block/blk-mq-sched.c | 7 +-- block/blk-mq.c | 147 ++++++++++++++++++++----------------------- 2 files changed, 71 insertions(+), 83 deletions(-)