mbox series

[0/3] Convert to *_with_info() API

Message ID 20230105141911.8040-1-W_Armin@gmx.de
Headers
Series Convert to *_with_info() API |

Message

Armin Wolf Jan. 5, 2023, 2:19 p.m. UTC 
  This patch series converts the ftsteutates driver to the *_with_info()
API, reducing module size by ~30%.
The first patch does the actual conversion, while the second patch deals
with the nonstandard fanX_source attributes, which are being replaced
with the standard pwmX_auto_channels_temp attributes. The last patch
adds support for fanX_fault attributes.

All patches where tested on a Fujitsu DS3401-B1.

Armin Wolf (3):
  hwmon: (ftsteutates) Convert to devm_hwmon_device_register_with_info()
  hwmon: (ftsteutates) Replace fanX_source with pwmX_auto_channels_temp
  hwmon: (ftsteutates) Add support for fanX_fault attributes

 Documentation/hwmon/ftsteutates.rst |   5 +
 drivers/hwmon/ftsteutates.c         | 550 +++++++++++-----------------
 2 files changed, 210 insertions(+), 345 deletions(-)

--
2.30.2

Comments

Guenter Roeck Jan. 5, 2023, 2:57 p.m. UTC | #1 
On Thu, Jan 05, 2023 at 03:19:08PM +0100, Armin Wolf wrote:
> This patch series converts the ftsteutates driver to the *_with_info()
> API, reducing module size by ~30%.
> The first patch does the actual conversion, while the second patch deals
> with the nonstandard fanX_source attributes, which are being replaced
> with the standard pwmX_auto_channels_temp attributes. The last patch
> adds support for fanX_fault attributes.
> 
> All patches where tested on a Fujitsu DS3401-B1.
> 

This is the second time in less than two weeks that I get a follow-up
version of a patch series, unversioned and without change log.

That makes me wonder - is that just coincidence or is someone promoting
that ?

Guenter

> Armin Wolf (3):
>   hwmon: (ftsteutates) Convert to devm_hwmon_device_register_with_info()
>   hwmon: (ftsteutates) Replace fanX_source with pwmX_auto_channels_temp
>   hwmon: (ftsteutates) Add support for fanX_fault attributes
> 
>  Documentation/hwmon/ftsteutates.rst |   5 +
>  drivers/hwmon/ftsteutates.c         | 550 +++++++++++-----------------
>  2 files changed, 210 insertions(+), 345 deletions(-)
> 
> --
> 2.30.2
>
Armin Wolf Jan. 5, 2023, 10:36 p.m. UTC | #2 
Am 05.01.23 um 15:57 schrieb Guenter Roeck:

> On Thu, Jan 05, 2023 at 03:19:08PM +0100, Armin Wolf wrote:
>> This patch series converts the ftsteutates driver to the *_with_info()
>> API, reducing module size by ~30%.
>> The first patch does the actual conversion, while the second patch deals
>> with the nonstandard fanX_source attributes, which are being replaced
>> with the standard pwmX_auto_channels_temp attributes. The last patch
>> adds support for fanX_fault attributes.
>>
>> All patches where tested on a Fujitsu DS3401-B1.
>>
> This is the second time in less than two weeks that I get a follow-up
> version of a patch series, unversioned and without change log.
>
> That makes me wonder - is that just coincidence or is someone promoting
> that ?
>
> Guenter

My fault, i thought that with all other patches of the previous series being merged
and the single remaining patch being significantly changed, it would be more appropriate
to create a new series.

I will send the patches as a follow-up series of the previous patch series then.

Armin Wolf

>> Armin Wolf (3):
>>    hwmon: (ftsteutates) Convert to devm_hwmon_device_register_with_info()
>>    hwmon: (ftsteutates) Replace fanX_source with pwmX_auto_channels_temp
>>    hwmon: (ftsteutates) Add support for fanX_fault attributes
>>
>>   Documentation/hwmon/ftsteutates.rst |   5 +
>>   drivers/hwmon/ftsteutates.c         | 550 +++++++++++-----------------
>>   2 files changed, 210 insertions(+), 345 deletions(-)
>>
>> --
>> 2.30.2
>>