mbox series

[v3,0/3] Thermal ACPI APIs for generic trip points

Message ID 20230104222127.2364396-1-daniel.lezcano@kernel.org
Headers
Series Thermal ACPI APIs for generic trip points |

Message

Daniel Lezcano Jan. 4, 2023, 10:21 p.m. UTC 
  Recently sent as a RFC, the thermal ACPI for generic trip points is a set of
functions to fill the generic trip points structure which will become the
standard structure for the thermal framework and its users.

Different Intel drivers and the ACPI thermal driver are using the ACPI tables to
get the thermal zone information. As those are getting the same information,
providing this set of ACPI function with the generic trip points will
consolidate the code.

Also, the Intel PCH and the Intel 34xx drivers are converted to use the generic
trip points relying on the ACPI generic trip point parsing functions.

These changes have been tested on a Thinkpad Lenovo x280 with the PCH and
INT34xx drivers. No regression have been observed, the trip points remain the
same for what is described on this system.

Changelog:

 - V3:
   - Took into account Rafael's comments
   - Used a silence option THERMAL_ACPI in order to stay consistent
     with THERMAL_OF. It is up to the API user to select the option.

 - V2:
   - Fix the thermal ACPI patch where the thermal_acpi.c was not included in
     the series
   - Provide a couple of users of this API which could have been tested on a
     real system

Daniel Lezcano (3):
  thermal/acpi: Add ACPI trip point routines
  thermal/drivers/intel: Use generic trip points for intel_pch
  thermal/drivers/intel: Use generic trip points int340x

 drivers/thermal/Kconfig                       |   4 +
 drivers/thermal/Makefile                      |   1 +
 drivers/thermal/intel/Kconfig                 |   1 +
 drivers/thermal/intel/int340x_thermal/Kconfig |   1 +
 .../int340x_thermal/int340x_thermal_zone.c    | 177 ++++----------
 .../int340x_thermal/int340x_thermal_zone.h    |  10 +-
 drivers/thermal/intel/intel_pch_thermal.c     |  88 ++-----
 drivers/thermal/thermal_acpi.c                | 218 ++++++++++++++++++
 include/linux/thermal.h                       |   8 +
 9 files changed, 294 insertions(+), 214 deletions(-)
 create mode 100644 drivers/thermal/thermal_acpi.c

Comments

Zhang, Rui Jan. 6, 2023, 8:25 a.m. UTC | #1 
Hi,  Daniel,

On Wed, 2023-01-04 at 23:21 +0100, Daniel Lezcano wrote:
> Recently sent as a RFC, the thermal ACPI for generic trip points is a
> set of
> functions to fill the generic trip points structure which will become
> the
> standard structure for the thermal framework and its users.
> 
> Different Intel drivers and the ACPI thermal driver are using the
> ACPI tables to
> get the thermal zone information. As those are getting the same
> information,
> providing this set of ACPI function with the generic trip points will
> consolidate the code.

My understanding is that the ACPI thermal driver
(drivers/acpi/thermal.c) should be one of the top users of these APIs.

Is there any specific reason that it is not included in this patch
series? or is it just that you don't have ACPI thermal driver running
on your test platform?

thanks,
rui

> Also, the Intel PCH and the Intel 34xx drivers are converted to use
> the generic
> trip points relying on the ACPI generic trip point parsing functions.
> 
> These changes have been tested on a Thinkpad Lenovo x280 with the PCH
> and
> INT34xx drivers. No regression have been observed, the trip points
> remain the
> same for what is described on this system.
> 
> Changelog:
> 
>  - V3:
>    - Took into account Rafael's comments
>    - Used a silence option THERMAL_ACPI in order to stay consistent
>      with THERMAL_OF. It is up to the API user to select the option.
> 
>  - V2:
>    - Fix the thermal ACPI patch where the thermal_acpi.c was not
> included in
>      the series
>    - Provide a couple of users of this API which could have been
> tested on a
>      real system
> 
> Daniel Lezcano (3):
>   thermal/acpi: Add ACPI trip point routines
>   thermal/drivers/intel: Use generic trip points for intel_pch
>   thermal/drivers/intel: Use generic trip points int340x
> 
>  drivers/thermal/Kconfig                       |   4 +
>  drivers/thermal/Makefile                      |   1 +
>  drivers/thermal/intel/Kconfig                 |   1 +
>  drivers/thermal/intel/int340x_thermal/Kconfig |   1 +
>  .../int340x_thermal/int340x_thermal_zone.c    | 177 ++++----------
>  .../int340x_thermal/int340x_thermal_zone.h    |  10 +-
>  drivers/thermal/intel/intel_pch_thermal.c     |  88 ++-----
>  drivers/thermal/thermal_acpi.c                | 218
> ++++++++++++++++++
>  include/linux/thermal.h                       |   8 +
>  9 files changed, 294 insertions(+), 214 deletions(-)
>  create mode 100644 drivers/thermal/thermal_acpi.c
>
Daniel Lezcano Jan. 6, 2023, 1:25 p.m. UTC | #2 
On 06/01/2023 09:25, Zhang, Rui wrote:
> Hi,  Daniel,
> 
> On Wed, 2023-01-04 at 23:21 +0100, Daniel Lezcano wrote:
>> Recently sent as a RFC, the thermal ACPI for generic trip points is a
>> set of
>> functions to fill the generic trip points structure which will become
>> the
>> standard structure for the thermal framework and its users.
>>
>> Different Intel drivers and the ACPI thermal driver are using the
>> ACPI tables to
>> get the thermal zone information. As those are getting the same
>> information,
>> providing this set of ACPI function with the generic trip points will
>> consolidate the code.
> 
> My understanding is that the ACPI thermal driver
> (drivers/acpi/thermal.c) should be one of the top users of these APIs.

Yes, correct.

> Is there any specific reason that it is not included in this patch
> series? or is it just that you don't have ACPI thermal driver running
> on your test platform?

The generic trip point handling in the acpi thermal driver is another 
story. Some code reorg and cleanup should be done before. I have a 
series for that but I need to test it more. That is the reason why it 
will be submitted after this series is reviewed, so the changes will be 
focused on the acpi thermal driver only.

I have a laptop with acpitz but only the critical trip temp.