mbox series

[0/4] perf bpf_counter: A set of random fixes (v1)

Message ID 20230104064402.1551516-1-namhyung@kernel.org
Headers
Series perf bpf_counter: A set of random fixes (v1) |

Message

Namhyung Kim Jan. 4, 2023, 6:43 a.m. UTC 
  Hello,

This is a collection of small fixes for perf stat bpf counters (bperf).

The bperf framework maintains perf_attr_map in the BPF fs to share the
same event as much as possible.  But the size was limited to 16 and
perf stat with -ddd option would create more than 16 events and fails.

Also cgroup events with --for-each-cgroup had some other problems when
dealing with unsupported events and duplicate cgroups.

The code is available at 'perf/stat-bpf-fix-v1' branch in

  git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Thanks,
Namhyung

Namhyung Kim (4):
  perf bpf_counter: Add more error messages for bperf
  perf bpf_counter: Increase perf_attr_map entries to 32
  perf bpf_counter: Handle unsupported cgroup events
  perf stat: Do not use the same cgroup more than once

 tools/perf/util/bpf_counter.c        | 11 ++++++++---
 tools/perf/util/bpf_counter_cgroup.c | 14 +++-----------
 tools/perf/util/cgroup.c             | 23 ++++++++++++++++++-----
 3 files changed, 29 insertions(+), 19 deletions(-)


base-commit: d8d85ce86dc82de4f88b821a78f533b9d5b22a45

Comments

Arnaldo Carvalho de Melo Jan. 4, 2023, 2:21 p.m. UTC | #1 
Em Tue, Jan 03, 2023 at 10:43:58PM -0800, Namhyung Kim escreveu:
> Hello,
> 
> This is a collection of small fixes for perf stat bpf counters (bperf).
> 
> The bperf framework maintains perf_attr_map in the BPF fs to share the
> same event as much as possible.  But the size was limited to 16 and
> perf stat with -ddd option would create more than 16 events and fails.
> 
> Also cgroup events with --for-each-cgroup had some other problems when
> dealing with unsupported events and duplicate cgroups.
> 
> The code is available at 'perf/stat-bpf-fix-v1' branch in
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

The first two are improvements, not strict fixes, so I'm leaving them
for the next merge window.

- Arnaldo
 
> Thanks,
> Namhyung
> 
> Namhyung Kim (4):
>   perf bpf_counter: Add more error messages for bperf
>   perf bpf_counter: Increase perf_attr_map entries to 32
>   perf bpf_counter: Handle unsupported cgroup events
>   perf stat: Do not use the same cgroup more than once
> 
>  tools/perf/util/bpf_counter.c        | 11 ++++++++---
>  tools/perf/util/bpf_counter_cgroup.c | 14 +++-----------
>  tools/perf/util/cgroup.c             | 23 ++++++++++++++++++-----
>  3 files changed, 29 insertions(+), 19 deletions(-)
> 
> 
> base-commit: d8d85ce86dc82de4f88b821a78f533b9d5b22a45
> -- 
> 2.39.0.314.g84b9a713c41-goog