Message ID | 20230103141221.772261-1-apatel@ventanamicro.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4640429wrt; Tue, 3 Jan 2023 06:13:07 -0800 (PST) X-Google-Smtp-Source: AMrXdXszJgNpNups2lNZYbk+FXGbq06DwOr285dcM10BVeXAkHKWWftjQemb5ujI6JfWEh339hPn X-Received: by 2002:a17:902:a40a:b0:192:7363:f6c7 with SMTP id p10-20020a170902a40a00b001927363f6c7mr33821672plq.37.1672755186916; Tue, 03 Jan 2023 06:13:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672755186; cv=none; d=google.com; s=arc-20160816; b=iS6FEpbv/lTqnjyf81lxIoVIhI6NbnXQz2Gq8bnSwopWtdzaDmcBIugX8MaajSMHCM LTHf+Xcr1QE6KduOroSUg3qmUgQtQpqvK1XlVDxdr9/ITtMNOAeodOcHYILnpUyMDDNG b4fyfDSn6mdyXHYpv2XSDCTMnofQpFRsPQOIuMiYag0m9sJumYevxjp0iglbAsBKLAP0 hcKnXYQCqO82LU7Tfxk8v1NqvkGkQ4CiV4n9r/8TJNoMtONi+Gw7dHahkjN6X6h6MF9z e2qXs3MnIsE7M2nc81uDKYatfZdUt2wpLon4H4OTQTQxsVQE9d6rY1u2MLIk4sZF/xCw v04A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=pyb5UZmjqbSglyHq6r1Nzt+FNrL5pLsd5/wqWYrsn7o=; b=yGFeETDHEO+Y0awEuinZxrDO+jrrLyyHJdlGFEJEdmZnqYprKdgYjG9ucGC4ESmMcT +pwcfjzpQkrxSnptII2Z3ke3+N3X1vNTvJgpdQY/gERJTlngGLxZsQ+JzkCfFHjQ80m5 noRv2lXGWpfby84qeymB7YFsxD/r8l0Hyo8hPMN7W0jZsUEW2/8tx3veH6wJxLaZFjhX UdHeKJbACTS9/9/zNlGibyElfqWurED7Sa1RxuPXUw9qhBU9oF0G+fXHfOqg9rdI83KT wjTdYsad/uvpt+NIu6yaN1guSCuDPpAVX+MwgNaDVD6kbnxtPj5By3gVePVdv5JsKYhF /i/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ventanamicro.com header.s=google header.b=MVCVmUrI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n12-20020a170902e54c00b00174ea015ee8si33595105plf.592.2023.01.03.06.12.55; Tue, 03 Jan 2023 06:13:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ventanamicro.com header.s=google header.b=MVCVmUrI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237827AbjACOMt (ORCPT <rfc822;tmhikaru@gmail.com> + 99 others); Tue, 3 Jan 2023 09:12:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237833AbjACOMg (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 3 Jan 2023 09:12:36 -0500 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14D6711806 for <linux-kernel@vger.kernel.org>; Tue, 3 Jan 2023 06:12:34 -0800 (PST) Received: by mail-pl1-x62e.google.com with SMTP id p24so10195756plw.11 for <linux-kernel@vger.kernel.org>; Tue, 03 Jan 2023 06:12:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pyb5UZmjqbSglyHq6r1Nzt+FNrL5pLsd5/wqWYrsn7o=; b=MVCVmUrIbO1VkHOy6G+ik1NaYZi10V9JE3tWLEE5t0WPN2ARSCJeDL5nyw82EO2+jP 79mMWBQGUpAGirreRy2IrdhtviwOutMfQ3L2eFBgg1XoeU4WyFKzc/Dn1Qj3BOgv7gzA uCHoxqSoHIFFLACljAcNgIbp5YCEtPz6AFbgzVmRCJAs0M1PXq9NbECEK7Sy3hyW92/n xEAsv041ydx14RDSQ+VmsCyOlppIziyB5acUx4+f/jbFSj7YXiUR+G3U/YvodN6Ta+jC mFCfdxkWfZy92koSHui5p97vZEcjYFjDaXb0GKkr8yB3lacxzTtlEg3aDFoFHeC0NDr4 hQLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pyb5UZmjqbSglyHq6r1Nzt+FNrL5pLsd5/wqWYrsn7o=; b=GNZfMv99Q0fJjOVSEJfNZz+fUg+xwE268Tu0WZ3jeY1/2/WntAFFEBY3eA5r5VWofx YacQ3lbwNpG2zx4IUIJP9qTyHt25DaeRcB9hpFeSIjgyA0o0dcMMQnvF9WbKE9OHg7v3 8f2TyTZQFztPTJwk48rv8VYhDNM9faVeX7NQRSvBMCgBzY86uQxtuhP4dzLgHZ2DJB3Q 6I0YIigt3nSlCmU0umHubMtjT/FCNaCAVViaokDizJ5XKqIy1rtr+/PWXJbs5NbOT4Vr UCXQodFaY20/mC1T86UGqdq464/DTgfe8DCwG9IIAs+H7/vvTTtM9UxTZ/6OeGI44CPE IdEw== X-Gm-Message-State: AFqh2krJoEo76J9cGK0pW1r/Re3+omT1oE7yMX9CZKA89ODTpdw0+8RQ 1aHiorJedERf8b3IdClRxL6sNw== X-Received: by 2002:a17:902:f54a:b0:191:327d:ddc0 with SMTP id h10-20020a170902f54a00b00191327dddc0mr70794879plf.21.1672755153390; Tue, 03 Jan 2023 06:12:33 -0800 (PST) Received: from anup-ubuntu-vm.localdomain ([171.76.85.241]) by smtp.gmail.com with ESMTPSA id x16-20020a1709027c1000b00192b0a07891sm8598286pll.101.2023.01.03.06.12.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jan 2023 06:12:32 -0800 (PST) From: Anup Patel <apatel@ventanamicro.com> To: Palmer Dabbelt <palmer@dabbelt.com>, Paul Walmsley <paul.walmsley@sifive.com>, Thomas Gleixner <tglx@linutronix.de>, Marc Zyngier <maz@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org> Cc: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>, Alyssa Rosenzweig <alyssa@rosenzweig.io>, Atish Patra <atishp@atishpatra.org>, Alistair Francis <Alistair.Francis@wdc.com>, Anup Patel <anup@brainfault.org>, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, Anup Patel <apatel@ventanamicro.com> Subject: [PATCH v16 0/9] RISC-V IPI Improvements Date: Tue, 3 Jan 2023 19:42:12 +0530 Message-Id: <20230103141221.772261-1-apatel@ventanamicro.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754010943060200201?= X-GMAIL-MSGID: =?utf-8?q?1754010943060200201?= |
Series |
RISC-V IPI Improvements
|
|
Message
Anup Patel
Jan. 3, 2023, 2:12 p.m. UTC
This series aims to improve IPI support in Linux RISC-V in following ways: 1) Treat IPIs as normal per-CPU interrupts instead of having custom RISC-V specific hooks. This also makes Linux RISC-V IPI support aligned with other architectures. 2) Remote TLB flushes and icache flushes should prefer local IPIs instead of SBI calls whenever we have specialized hardware (such as RISC-V AIA IMSIC and RISC-V SWI) which allows S-mode software to directly inject IPIs without any assistance from M-mode runtime firmware. These patches were originally part of the "Linux RISC-V ACLINT Support" series but this now a separate series so that it can be merged independently of the "Linux RISC-V ACLINT Support" series. (Refer, https://lore.kernel.org/lkml/20211007123632.697666-1-anup.patel@wdc.com/) These patches are also a preparatory patches for the up-coming: 1) Linux RISC-V AIA support 2) Linux RISC-V SWI support These patches can also be found in riscv_ipi_imp_v16 branch at: https://github.com/avpatel/linux.git Changes since v15: - Rebased on Linux-6.2-rc2 - Added Reviewed-by and Tested-by tags to some of the patches. Changes since v14: - Minor fixes in commit description of PATCH3 (as suggested by tglx) - Don't disable parent IPI when CPU goes offline for SBI IPI driver and CLINT driver in PATCH4. - Include Apple AIC driver changes from Marc Z as PATCH9 Changes since v13: - Included changes suggested by Marc Z in PATCH3 - Use chained handlers in PATCH4 - Added new PATCH8 to have empty irq_eoi() in RISC-V INTC driver. This avoids the unnecessary mask/unmask dance at time of handling interrupts. Changes since v12: - Rebased on Linux-6.1-rc7 - Bring-back the IPI optimization in ipi_mux_send_mask() for PATCH3 - Call ipi_mux_send() for one target CPU at a time in PATCH3 Changes since v11: - Removed ipi_mux_pre/post_handle() callbacks in PATCH3 - Removed sturct ipi_mux_ops in PATCH3 - Removed parent_virq and data pointer from everywhere in PATCH3 - Removed struct ipi_mux_control in PATCH3 - Improved function signature of ipi_mux_send() callback in PATCH3 - Used unsigned type with atomic operation in PATCH3 Changes since v10: - Rebased on Linux-6.1-rc5 - Drop the "!(pending & ibit)" check in ipi_mux_send_mask() of PATCH3 - Disable local interrupts in ipi_mux_send_mask() of PATCH3 because we can be preempted while using a per-CPU temporary variable. Changes since v9: - Rebased on Linux-6.1-rc3 - Updated header comment block of ipi-mux.c in PATCH3 - Use a struct for global data of ipi-mux.c in PATCH3 - Add per-CPU temp cpumask for sending IPIs in PATCH3 - Drop the use of fwspec in PATCH3 - Use static key for ipi_mux_pre_handle() and ipi_mux_post_handle() in PATCH3 - Remove redundant pr_warn_ratelimited() called by ipi_mux_process() in PATCH3 - Remove CPUHP thingy from ipi_mux_create() in PATCH3 Changes since v8: - Rebased on Linux-6.0-rc3 - Use dummy percpu data as parameter for request_percpu_irq() in PATCH4. Changes since v7: - Rebased on Linux-6.0-rc1 - Use atomic operations to track per-CPU pending and enabled IPIs in PATCH3. (Note: this is inspired from IPI muxing implemented in drivers/irqchip/irq-apple-aic.c) - Made "struct ipi_mux_ops" (added by PATCH3) flexible so that drivers/irqchip/irq-apple-aic.c can adopt it in future. Changes since v6: - Rebased on Linux-5.19-rc7 - Added documentation for struct ipi_mux_ops in PATCH3 - Dropped dummy irq_mask()/unmask() in PATCH3 - Added const for "ipi_mux_chip" in PATCH3 - Removed "type" initialization from ipi_mux_domain_alloc() in PATCH3 - Dropped translate() from "ipi_mux_domain_ops" in PATCH3 - Improved barrier documentation in ipi_mux_process() of PATCH3 - Added percpu check in ipi_mux_create() for parent_virq of PATCH3 - Added nr_ipi parameter in ipi_mux_create() of PATCH3 Changes since v5: - Rebased on Linux-5.18-rc3 - Used kernel doc style in PATCH3 - Removed redundant loop in ipi_mux_process() of PATCH3 - Removed "RISC-V" prefix form ipi_mux_chip.name of PATCH3 - Removed use of "this patch" in PATCH3 commit description - Addressed few other nit comments in PATCH3 Changes since v4: - Rebased on Linux-5.17 - Includes new PATCH3 which adds mechanism to multiplex a single HW IPI Changes since v3: - Rebased on Linux-5.17-rc6 - Updated PATCH2 to not export riscv_set_intc_hwnode_fn() - Simplified riscv_intc_hwnode() in PATCH2 Changes since v2: - Rebased on Linux-5.17-rc4 - Updated PATCH2 to not create synthetic INTC fwnode and instead provide a function which allows drivers to directly discover INTC fwnode Changes since v1: - Use synthetic fwnode for INTC instead of irq_set_default_host() in PATCH2 Anup Patel (8): RISC-V: Clear SIP bit only when using SBI IPI operations irqchip/riscv-intc: Allow drivers to directly discover INTC hwnode genirq: Add mechanism to multiplex a single HW IPI RISC-V: Treat IPIs as normal Linux IRQs RISC-V: Allow marking IPIs as suitable for remote FENCEs RISC-V: Use IPIs for remote TLB flush when possible RISC-V: Use IPIs for remote icache flush when possible irqchip/riscv-intc: Add empty irq_eoi() for chained irq handlers Marc Zyngier (1): irqchip/apple-aic: Move over to core ipi-mux arch/riscv/Kconfig | 2 + arch/riscv/include/asm/irq.h | 4 + arch/riscv/include/asm/sbi.h | 9 +- arch/riscv/include/asm/smp.h | 49 +++++-- arch/riscv/kernel/Makefile | 1 + arch/riscv/kernel/cpu-hotplug.c | 3 +- arch/riscv/kernel/irq.c | 21 ++- arch/riscv/kernel/sbi-ipi.c | 77 +++++++++++ arch/riscv/kernel/sbi.c | 100 +++------------ arch/riscv/kernel/smp.c | 171 ++++++++++++------------ arch/riscv/kernel/smpboot.c | 5 +- arch/riscv/mm/cacheflush.c | 5 +- arch/riscv/mm/tlbflush.c | 93 +++++++++++--- drivers/clocksource/timer-clint.c | 65 +++++++--- drivers/irqchip/Kconfig | 2 + drivers/irqchip/irq-apple-aic.c | 161 ++--------------------- drivers/irqchip/irq-riscv-intc.c | 71 ++++++---- include/linux/irq.h | 3 + kernel/irq/Kconfig | 5 + kernel/irq/Makefile | 1 + kernel/irq/ipi-mux.c | 207 ++++++++++++++++++++++++++++++ 21 files changed, 654 insertions(+), 401 deletions(-) create mode 100644 arch/riscv/kernel/sbi-ipi.c create mode 100644 kernel/irq/ipi-mux.c
Comments
Hi Marc, On Tue, Jan 3, 2023 at 7:42 PM Anup Patel <apatel@ventanamicro.com> wrote: > > This series aims to improve IPI support in Linux RISC-V in following ways: > 1) Treat IPIs as normal per-CPU interrupts instead of having custom RISC-V > specific hooks. This also makes Linux RISC-V IPI support aligned with > other architectures. > 2) Remote TLB flushes and icache flushes should prefer local IPIs instead > of SBI calls whenever we have specialized hardware (such as RISC-V AIA > IMSIC and RISC-V SWI) which allows S-mode software to directly inject > IPIs without any assistance from M-mode runtime firmware. > > These patches were originally part of the "Linux RISC-V ACLINT Support" > series but this now a separate series so that it can be merged independently > of the "Linux RISC-V ACLINT Support" series. > (Refer, https://lore.kernel.org/lkml/20211007123632.697666-1-anup.patel@wdc.com/) > > These patches are also a preparatory patches for the up-coming: > 1) Linux RISC-V AIA support > 2) Linux RISC-V SWI support > > These patches can also be found in riscv_ipi_imp_v16 branch at: > https://github.com/avpatel/linux.git > > Changes since v15: > - Rebased on Linux-6.2-rc2 > - Added Reviewed-by and Tested-by tags to some of the patches. > > Changes since v14: > - Minor fixes in commit description of PATCH3 (as suggested by tglx) > - Don't disable parent IPI when CPU goes offline for SBI IPI driver and > CLINT driver in PATCH4. > - Include Apple AIC driver changes from Marc Z as PATCH9 > > Changes since v13: > - Included changes suggested by Marc Z in PATCH3 > - Use chained handlers in PATCH4 > - Added new PATCH8 to have empty irq_eoi() in RISC-V INTC driver. This > avoids the unnecessary mask/unmask dance at time of handling interrupts. > > Changes since v12: > - Rebased on Linux-6.1-rc7 > - Bring-back the IPI optimization in ipi_mux_send_mask() for PATCH3 > - Call ipi_mux_send() for one target CPU at a time in PATCH3 > > Changes since v11: > - Removed ipi_mux_pre/post_handle() callbacks in PATCH3 > - Removed sturct ipi_mux_ops in PATCH3 > - Removed parent_virq and data pointer from everywhere in PATCH3 > - Removed struct ipi_mux_control in PATCH3 > - Improved function signature of ipi_mux_send() callback in PATCH3 > - Used unsigned type with atomic operation in PATCH3 > > Changes since v10: > - Rebased on Linux-6.1-rc5 > - Drop the "!(pending & ibit)" check in ipi_mux_send_mask() of PATCH3 > - Disable local interrupts in ipi_mux_send_mask() of PATCH3 because we > can be preempted while using a per-CPU temporary variable. > > Changes since v9: > - Rebased on Linux-6.1-rc3 > - Updated header comment block of ipi-mux.c in PATCH3 > - Use a struct for global data of ipi-mux.c in PATCH3 > - Add per-CPU temp cpumask for sending IPIs in PATCH3 > - Drop the use of fwspec in PATCH3 > - Use static key for ipi_mux_pre_handle() and ipi_mux_post_handle() > in PATCH3 > - Remove redundant pr_warn_ratelimited() called by ipi_mux_process() > in PATCH3 > - Remove CPUHP thingy from ipi_mux_create() in PATCH3 > > Changes since v8: > - Rebased on Linux-6.0-rc3 > - Use dummy percpu data as parameter for request_percpu_irq() in PATCH4. > > Changes since v7: > - Rebased on Linux-6.0-rc1 > - Use atomic operations to track per-CPU pending and enabled IPIs in PATCH3. > (Note: this is inspired from IPI muxing implemented in > drivers/irqchip/irq-apple-aic.c) > - Made "struct ipi_mux_ops" (added by PATCH3) flexible so that > drivers/irqchip/irq-apple-aic.c can adopt it in future. > > Changes since v6: > - Rebased on Linux-5.19-rc7 > - Added documentation for struct ipi_mux_ops in PATCH3 > - Dropped dummy irq_mask()/unmask() in PATCH3 > - Added const for "ipi_mux_chip" in PATCH3 > - Removed "type" initialization from ipi_mux_domain_alloc() in PATCH3 > - Dropped translate() from "ipi_mux_domain_ops" in PATCH3 > - Improved barrier documentation in ipi_mux_process() of PATCH3 > - Added percpu check in ipi_mux_create() for parent_virq of PATCH3 > - Added nr_ipi parameter in ipi_mux_create() of PATCH3 > > Changes since v5: > - Rebased on Linux-5.18-rc3 > - Used kernel doc style in PATCH3 > - Removed redundant loop in ipi_mux_process() of PATCH3 > - Removed "RISC-V" prefix form ipi_mux_chip.name of PATCH3 > - Removed use of "this patch" in PATCH3 commit description > - Addressed few other nit comments in PATCH3 > > Changes since v4: > - Rebased on Linux-5.17 > - Includes new PATCH3 which adds mechanism to multiplex a single HW IPI > > Changes since v3: > - Rebased on Linux-5.17-rc6 > - Updated PATCH2 to not export riscv_set_intc_hwnode_fn() > - Simplified riscv_intc_hwnode() in PATCH2 > > Changes since v2: > - Rebased on Linux-5.17-rc4 > - Updated PATCH2 to not create synthetic INTC fwnode and instead provide > a function which allows drivers to directly discover INTC fwnode > > Changes since v1: > - Use synthetic fwnode for INTC instead of irq_set_default_host() in PATCH2 > > Anup Patel (8): > RISC-V: Clear SIP bit only when using SBI IPI operations > irqchip/riscv-intc: Allow drivers to directly discover INTC hwnode > genirq: Add mechanism to multiplex a single HW IPI > RISC-V: Treat IPIs as normal Linux IRQs > RISC-V: Allow marking IPIs as suitable for remote FENCEs > RISC-V: Use IPIs for remote TLB flush when possible > RISC-V: Use IPIs for remote icache flush when possible > irqchip/riscv-intc: Add empty irq_eoi() for chained irq handlers > > Marc Zyngier (1): > irqchip/apple-aic: Move over to core ipi-mux > > arch/riscv/Kconfig | 2 + > arch/riscv/include/asm/irq.h | 4 + > arch/riscv/include/asm/sbi.h | 9 +- > arch/riscv/include/asm/smp.h | 49 +++++-- > arch/riscv/kernel/Makefile | 1 + > arch/riscv/kernel/cpu-hotplug.c | 3 +- > arch/riscv/kernel/irq.c | 21 ++- > arch/riscv/kernel/sbi-ipi.c | 77 +++++++++++ > arch/riscv/kernel/sbi.c | 100 +++------------ > arch/riscv/kernel/smp.c | 171 ++++++++++++------------ > arch/riscv/kernel/smpboot.c | 5 +- > arch/riscv/mm/cacheflush.c | 5 +- > arch/riscv/mm/tlbflush.c | 93 +++++++++++--- > drivers/clocksource/timer-clint.c | 65 +++++++--- > drivers/irqchip/Kconfig | 2 + > drivers/irqchip/irq-apple-aic.c | 161 ++--------------------- > drivers/irqchip/irq-riscv-intc.c | 71 ++++++---- > include/linux/irq.h | 3 + > kernel/irq/Kconfig | 5 + > kernel/irq/Makefile | 1 + > kernel/irq/ipi-mux.c | 207 ++++++++++++++++++++++++++++++ > 21 files changed, 654 insertions(+), 401 deletions(-) > create mode 100644 arch/riscv/kernel/sbi-ipi.c > create mode 100644 kernel/irq/ipi-mux.c > > -- > 2.34.1 > Friendly ping ? Regards, Anup
Hi Marc, On Thu, Jan 12, 2023 at 5:47 PM Anup Patel <apatel@ventanamicro.com> wrote: > > Hi Marc, > > On Tue, Jan 3, 2023 at 7:42 PM Anup Patel <apatel@ventanamicro.com> wrote: > > > > This series aims to improve IPI support in Linux RISC-V in following ways: > > 1) Treat IPIs as normal per-CPU interrupts instead of having custom RISC-V > > specific hooks. This also makes Linux RISC-V IPI support aligned with > > other architectures. > > 2) Remote TLB flushes and icache flushes should prefer local IPIs instead > > of SBI calls whenever we have specialized hardware (such as RISC-V AIA > > IMSIC and RISC-V SWI) which allows S-mode software to directly inject > > IPIs without any assistance from M-mode runtime firmware. > > > > These patches were originally part of the "Linux RISC-V ACLINT Support" > > series but this now a separate series so that it can be merged independently > > of the "Linux RISC-V ACLINT Support" series. > > (Refer, https://lore.kernel.org/lkml/20211007123632.697666-1-anup.patel@wdc.com/) > > > > These patches are also a preparatory patches for the up-coming: > > 1) Linux RISC-V AIA support > > 2) Linux RISC-V SWI support > > > > These patches can also be found in riscv_ipi_imp_v16 branch at: > > https://github.com/avpatel/linux.git > > > > Changes since v15: > > - Rebased on Linux-6.2-rc2 > > - Added Reviewed-by and Tested-by tags to some of the patches. > > > > Changes since v14: > > - Minor fixes in commit description of PATCH3 (as suggested by tglx) > > - Don't disable parent IPI when CPU goes offline for SBI IPI driver and > > CLINT driver in PATCH4. > > - Include Apple AIC driver changes from Marc Z as PATCH9 > > > > Changes since v13: > > - Included changes suggested by Marc Z in PATCH3 > > - Use chained handlers in PATCH4 > > - Added new PATCH8 to have empty irq_eoi() in RISC-V INTC driver. This > > avoids the unnecessary mask/unmask dance at time of handling interrupts. > > > > Changes since v12: > > - Rebased on Linux-6.1-rc7 > > - Bring-back the IPI optimization in ipi_mux_send_mask() for PATCH3 > > - Call ipi_mux_send() for one target CPU at a time in PATCH3 > > > > Changes since v11: > > - Removed ipi_mux_pre/post_handle() callbacks in PATCH3 > > - Removed sturct ipi_mux_ops in PATCH3 > > - Removed parent_virq and data pointer from everywhere in PATCH3 > > - Removed struct ipi_mux_control in PATCH3 > > - Improved function signature of ipi_mux_send() callback in PATCH3 > > - Used unsigned type with atomic operation in PATCH3 > > > > Changes since v10: > > - Rebased on Linux-6.1-rc5 > > - Drop the "!(pending & ibit)" check in ipi_mux_send_mask() of PATCH3 > > - Disable local interrupts in ipi_mux_send_mask() of PATCH3 because we > > can be preempted while using a per-CPU temporary variable. > > > > Changes since v9: > > - Rebased on Linux-6.1-rc3 > > - Updated header comment block of ipi-mux.c in PATCH3 > > - Use a struct for global data of ipi-mux.c in PATCH3 > > - Add per-CPU temp cpumask for sending IPIs in PATCH3 > > - Drop the use of fwspec in PATCH3 > > - Use static key for ipi_mux_pre_handle() and ipi_mux_post_handle() > > in PATCH3 > > - Remove redundant pr_warn_ratelimited() called by ipi_mux_process() > > in PATCH3 > > - Remove CPUHP thingy from ipi_mux_create() in PATCH3 > > > > Changes since v8: > > - Rebased on Linux-6.0-rc3 > > - Use dummy percpu data as parameter for request_percpu_irq() in PATCH4. > > > > Changes since v7: > > - Rebased on Linux-6.0-rc1 > > - Use atomic operations to track per-CPU pending and enabled IPIs in PATCH3. > > (Note: this is inspired from IPI muxing implemented in > > drivers/irqchip/irq-apple-aic.c) > > - Made "struct ipi_mux_ops" (added by PATCH3) flexible so that > > drivers/irqchip/irq-apple-aic.c can adopt it in future. > > > > Changes since v6: > > - Rebased on Linux-5.19-rc7 > > - Added documentation for struct ipi_mux_ops in PATCH3 > > - Dropped dummy irq_mask()/unmask() in PATCH3 > > - Added const for "ipi_mux_chip" in PATCH3 > > - Removed "type" initialization from ipi_mux_domain_alloc() in PATCH3 > > - Dropped translate() from "ipi_mux_domain_ops" in PATCH3 > > - Improved barrier documentation in ipi_mux_process() of PATCH3 > > - Added percpu check in ipi_mux_create() for parent_virq of PATCH3 > > - Added nr_ipi parameter in ipi_mux_create() of PATCH3 > > > > Changes since v5: > > - Rebased on Linux-5.18-rc3 > > - Used kernel doc style in PATCH3 > > - Removed redundant loop in ipi_mux_process() of PATCH3 > > - Removed "RISC-V" prefix form ipi_mux_chip.name of PATCH3 > > - Removed use of "this patch" in PATCH3 commit description > > - Addressed few other nit comments in PATCH3 > > > > Changes since v4: > > - Rebased on Linux-5.17 > > - Includes new PATCH3 which adds mechanism to multiplex a single HW IPI > > > > Changes since v3: > > - Rebased on Linux-5.17-rc6 > > - Updated PATCH2 to not export riscv_set_intc_hwnode_fn() > > - Simplified riscv_intc_hwnode() in PATCH2 > > > > Changes since v2: > > - Rebased on Linux-5.17-rc4 > > - Updated PATCH2 to not create synthetic INTC fwnode and instead provide > > a function which allows drivers to directly discover INTC fwnode > > > > Changes since v1: > > - Use synthetic fwnode for INTC instead of irq_set_default_host() in PATCH2 > > > > Anup Patel (8): > > RISC-V: Clear SIP bit only when using SBI IPI operations > > irqchip/riscv-intc: Allow drivers to directly discover INTC hwnode > > genirq: Add mechanism to multiplex a single HW IPI > > RISC-V: Treat IPIs as normal Linux IRQs > > RISC-V: Allow marking IPIs as suitable for remote FENCEs > > RISC-V: Use IPIs for remote TLB flush when possible > > RISC-V: Use IPIs for remote icache flush when possible > > irqchip/riscv-intc: Add empty irq_eoi() for chained irq handlers > > > > Marc Zyngier (1): > > irqchip/apple-aic: Move over to core ipi-mux > > > > arch/riscv/Kconfig | 2 + > > arch/riscv/include/asm/irq.h | 4 + > > arch/riscv/include/asm/sbi.h | 9 +- > > arch/riscv/include/asm/smp.h | 49 +++++-- > > arch/riscv/kernel/Makefile | 1 + > > arch/riscv/kernel/cpu-hotplug.c | 3 +- > > arch/riscv/kernel/irq.c | 21 ++- > > arch/riscv/kernel/sbi-ipi.c | 77 +++++++++++ > > arch/riscv/kernel/sbi.c | 100 +++------------ > > arch/riscv/kernel/smp.c | 171 ++++++++++++------------ > > arch/riscv/kernel/smpboot.c | 5 +- > > arch/riscv/mm/cacheflush.c | 5 +- > > arch/riscv/mm/tlbflush.c | 93 +++++++++++--- > > drivers/clocksource/timer-clint.c | 65 +++++++--- > > drivers/irqchip/Kconfig | 2 + > > drivers/irqchip/irq-apple-aic.c | 161 ++--------------------- > > drivers/irqchip/irq-riscv-intc.c | 71 ++++++---- > > include/linux/irq.h | 3 + > > kernel/irq/Kconfig | 5 + > > kernel/irq/Makefile | 1 + > > kernel/irq/ipi-mux.c | 207 ++++++++++++++++++++++++++++++ > > 21 files changed, 654 insertions(+), 401 deletions(-) > > create mode 100644 arch/riscv/kernel/sbi-ipi.c > > create mode 100644 kernel/irq/ipi-mux.c > > > > -- > > 2.34.1 > > > > Friendly ping ? Any further comments on this series ? Regards, Anup
On Tue, 03 Jan 2023 14:12:12 +0000, Anup Patel <apatel@ventanamicro.com> wrote: > > This series aims to improve IPI support in Linux RISC-V in following ways: > 1) Treat IPIs as normal per-CPU interrupts instead of having custom RISC-V > specific hooks. This also makes Linux RISC-V IPI support aligned with > other architectures. > 2) Remote TLB flushes and icache flushes should prefer local IPIs instead > of SBI calls whenever we have specialized hardware (such as RISC-V AIA > IMSIC and RISC-V SWI) which allows S-mode software to directly inject > IPIs without any assistance from M-mode runtime firmware. [...] I'm queuing patches 3 and 9 via the irqchip tree as they are standalone. For the rest, I need an Ack from the riscv maintainers as they change a large amount of arch-specific code, and the couple of irqchip patches depend on these changes. Palmer, Paul? Thanks, M.
On Sun, 05 Feb 2023 03:04:14 PST (-0800), Marc Zyngier wrote: > On Tue, 03 Jan 2023 14:12:12 +0000, > Anup Patel <apatel@ventanamicro.com> wrote: >> >> This series aims to improve IPI support in Linux RISC-V in following ways: >> 1) Treat IPIs as normal per-CPU interrupts instead of having custom RISC-V >> specific hooks. This also makes Linux RISC-V IPI support aligned with >> other architectures. >> 2) Remote TLB flushes and icache flushes should prefer local IPIs instead >> of SBI calls whenever we have specialized hardware (such as RISC-V AIA >> IMSIC and RISC-V SWI) which allows S-mode software to directly inject >> IPIs without any assistance from M-mode runtime firmware. > > [...] > > I'm queuing patches 3 and 9 via the irqchip tree as they are > standalone. > > For the rest, I need an Ack from the riscv maintainers as they change > a large amount of arch-specific code, and the couple of irqchip > patches depend on these changes. > > Palmer, Paul? I haven't gotten time to give this a proper review, but I think we've got enough of a mess with our interrupt handling that it doesn't really matter so Acked-by: Palmer Dabbelt <palmer@rivosinc.com> if you want to take it for this cycle that's fine with me, but I'm also fine holding off so it can have a while to bake in linux-next -- there's no real rush for any of this, as there's no hardware yet. > > Thanks, > > M.
On 2023-02-15 03:17, Palmer Dabbelt wrote: > On Sun, 05 Feb 2023 03:04:14 PST (-0800), Marc Zyngier wrote: >> On Tue, 03 Jan 2023 14:12:12 +0000, >> Anup Patel <apatel@ventanamicro.com> wrote: >>> >>> This series aims to improve IPI support in Linux RISC-V in following >>> ways: >>> 1) Treat IPIs as normal per-CPU interrupts instead of having custom >>> RISC-V >>> specific hooks. This also makes Linux RISC-V IPI support aligned >>> with >>> other architectures. >>> 2) Remote TLB flushes and icache flushes should prefer local IPIs >>> instead >>> of SBI calls whenever we have specialized hardware (such as >>> RISC-V AIA >>> IMSIC and RISC-V SWI) which allows S-mode software to directly >>> inject >>> IPIs without any assistance from M-mode runtime firmware. >> >> [...] >> >> I'm queuing patches 3 and 9 via the irqchip tree as they are >> standalone. >> >> For the rest, I need an Ack from the riscv maintainers as they change >> a large amount of arch-specific code, and the couple of irqchip >> patches depend on these changes. >> >> Palmer, Paul? > > I haven't gotten time to give this a proper review, but I think we've > got enough of a mess with our interrupt handling that it doesn't > really matter so > > Acked-by: Palmer Dabbelt <palmer@rivosinc.com> > > if you want to take it for this cycle that's fine with me, but I'm > also fine holding off so it can have a while to bake in linux-next -- > there's no real rush for any of this, as there's no hardware yet. Letting this sort of things simmering in -next is the way. Now that the basic dependencies are on their way, I'd expect this to be rebased on 6.3-rc1, and we can then put the whole thing in -next. Thanks, M.
On Mon, Feb 20, 2023 at 2:05 PM Marc Zyngier <maz@kernel.org> wrote: > > On 2023-02-15 03:17, Palmer Dabbelt wrote: > > On Sun, 05 Feb 2023 03:04:14 PST (-0800), Marc Zyngier wrote: > >> On Tue, 03 Jan 2023 14:12:12 +0000, > >> Anup Patel <apatel@ventanamicro.com> wrote: > >>> > >>> This series aims to improve IPI support in Linux RISC-V in following > >>> ways: > >>> 1) Treat IPIs as normal per-CPU interrupts instead of having custom > >>> RISC-V > >>> specific hooks. This also makes Linux RISC-V IPI support aligned > >>> with > >>> other architectures. > >>> 2) Remote TLB flushes and icache flushes should prefer local IPIs > >>> instead > >>> of SBI calls whenever we have specialized hardware (such as > >>> RISC-V AIA > >>> IMSIC and RISC-V SWI) which allows S-mode software to directly > >>> inject > >>> IPIs without any assistance from M-mode runtime firmware. > >> > >> [...] > >> > >> I'm queuing patches 3 and 9 via the irqchip tree as they are > >> standalone. > >> > >> For the rest, I need an Ack from the riscv maintainers as they change > >> a large amount of arch-specific code, and the couple of irqchip > >> patches depend on these changes. > >> > >> Palmer, Paul? > > > > I haven't gotten time to give this a proper review, but I think we've > > got enough of a mess with our interrupt handling that it doesn't > > really matter so > > > > Acked-by: Palmer Dabbelt <palmer@rivosinc.com> > > > > if you want to take it for this cycle that's fine with me, but I'm > > also fine holding off so it can have a while to bake in linux-next -- > > there's no real rush for any of this, as there's no hardware yet. > > Letting this sort of things simmering in -next is the way. > > Now that the basic dependencies are on their way, I'd expect this to be > rebased on 6.3-rc1, and we can then put the whole thing in -next. Okay, I will rebase on 6.3-rc1 whenever it is available. Thanks, Anup > > Thanks, > > M. > -- > Jazz is not dead. It just smells funny...