mbox series

[0/7] usb: fotg210: Various improvements

Message ID 20230103-gemini-fotg210-usb-v1-0-f2670cb4a492@linaro.org
Headers
Series usb: fotg210: Various improvements |

Message

Linus Walleij Jan. 3, 2023, 11:35 p.m. UTC 
  This is some gradual improvements to the FOTG210 dual-mode
USB host/gadget driver.

- Create stricter device tree bindings fixing some mistakes.
  We have at least FOTG200 and FOTG210 out there. A third
  variant named FUSB220 is probably related but has a separate
  driver in the vendor code trees.

- Start to break out common code for remapping of memory and
  clock handling to begin with, move this to the core file.

- Check that the block is in the right role before
  proceeding, don't abort registration but print a warning
  if it's not.

- Assing some default speed and the OF node when the UDC
  starts. This is based on the similar pattern in the DW
  controllers.

- Implement a proper VBUS session handler calling down to
  the hardware VBUS control handler in the Gemini variant.
  This makes everything work on my hardware.

To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rob Herring <robh+dt@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-usb@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Fabian Vogt <fabian@ritter-vogt.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
Linus Walleij (7):
      dt-bindings: usb: Correct and extend FOTG210 schema
      usb: fotg210: List different variants
      usb: fotg210: Acquire memory resource in core
      usb: fotg210: Move clock handling to core
      usb: fotg210: Check role register in core
      usb: fotg210-udc: Assign of_node and speed on start
      usb: fotg210-udc: Implement VBUS session

 .../devicetree/bindings/usb/faraday,fotg210.yaml   |  7 +-
 drivers/usb/fotg210/fotg210-core.c                 | 81 +++++++++++++++++++---
 drivers/usb/fotg210/fotg210-hcd.c                  | 48 ++-----------
 drivers/usb/fotg210/fotg210-hcd.h                  |  1 +
 drivers/usb/fotg210/fotg210-udc.c                  | 68 ++++++++----------
 drivers/usb/fotg210/fotg210-udc.h                  |  2 +-
 drivers/usb/fotg210/fotg210.h                      | 27 ++++++--
 7 files changed, 136 insertions(+), 98 deletions(-)
---
base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
change-id: 20230103-gemini-fotg210-usb-95a76798706a

Best regards,

Comments

Linus Walleij Jan. 18, 2023, 7:03 a.m. UTC | #1 
On Wed, Jan 4, 2023 at 12:35 AM Linus Walleij <linus.walleij@linaro.org> wrote:

> This is some gradual improvements to the FOTG210 dual-mode
> USB host/gadget driver.

Been two weeks, something I should change or are these good to
go?

Yours,
Linus Walleij
Linus Walleij Jan. 18, 2023, 7:04 a.m. UTC | #2 
On Wed, Jan 18, 2023 at 8:03 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Wed, Jan 4, 2023 at 12:35 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> > This is some gradual improvements to the FOTG210 dual-mode
> > USB host/gadget driver.
>
> Been two weeks, something I should change or are these good to
> go?

Ah no wait I see it, a small change needed on the DT binding.
I'll respin.

Yours,
Linus Walleij
Greg KH Jan. 18, 2023, 7:10 a.m. UTC | #3 
On Wed, Jan 18, 2023 at 08:03:59AM +0100, Linus Walleij wrote:
> On Wed, Jan 4, 2023 at 12:35 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> 
> > This is some gradual improvements to the FOTG210 dual-mode
> > USB host/gadget driver.
> 
> Been two weeks, something I should change or are these good to
> go?

I dropped the series from my review queue due to this comment:
	https://lore.kernel.org/r/9bbd5343-30bc-1146-3296-2c3a43b9a91b@linaro.org

so I was expecting a new series, is that not the case?

thanks,

greg k-h
Linus Walleij Jan. 18, 2023, 7:47 a.m. UTC | #4 
On Wed, Jan 18, 2023 at 8:10 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Wed, Jan 18, 2023 at 08:03:59AM +0100, Linus Walleij wrote:
> > On Wed, Jan 4, 2023 at 12:35 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> >
> > > This is some gradual improvements to the FOTG210 dual-mode
> > > USB host/gadget driver.
> >
> > Been two weeks, something I should change or are these good to
> > go?
>
> I dropped the series from my review queue due to this comment:
>         https://lore.kernel.org/r/9bbd5343-30bc-1146-3296-2c3a43b9a91b@linaro.org
>
> so I was expecting a new series, is that not the case?

You're right, I've dropped a single word and resent!

Yours,
Linus Walleij