mbox series

[v7,00/10] Designware PWM driver updates for OF

Message ID 20221223153820.404565-1-ben.dooks@sifive.com
Headers
Series Designware PWM driver updates for OF |

Message

Ben Dooks Dec. 23, 2022, 3:38 p.m. UTC 
  An updated set of patches for the Designware PWM driver
split into PCI and OF versions. I think I got all the
review issues in this set.

Sorry for the delay in getting this out, between conferences
and other absences there has been little time to deal with
this set. I will be now out of office until 3rd Jan 2023.

v7:
 - fixup kconfig from previous pcie changes
 - re-order kconfig to make dwc core be selected by PCI driver
 - move clk variable to patch it is used in
v6:
 - fix removal ordering of DWC_PERIOD_NS
v5:
 - fixed kconfig string error
 - merged pwm-nr into main of code
 - split of code from pci code
 - updated pwm-nr capping
 - fix duplicate error reporting in of-code
 - fix return in of-probe
 - remove unecessary remove function as devm_ functions sort this
 - fixed ordering of properties
 - added missing reg item
 - fixed missing split of the two clock sources.
 - get bus clock in of code
v4:
 - split pci and of into new modules
 - fixup review comments
 - fix typos in dt-bindings
v3:
- change the compatible name
- squash down pwm count patch
- fixup patch naming
v2:
- fix #pwm-cells count to be 3
- fix indetation 
- merge the two clock patches
- add HAS_IOMEM as a config dependency

Ben Dooks (10):
  dt-bindings: pwm: Document Synopsys DesignWare
    snps,pwm-dw-apb-timers-pwm2
  pwm: dwc: allow driver to be built with COMPILE_TEST
  pwm: dwc: change &pci->dev to dev in probe
  pwm: dwc: move memory alloc to own function
  pwm: dwc: use devm_pwmchip_add
  pwm: dwc: split pci out of core driver
  pwm: dwc: make timer clock configurable
  pwm: dwc: add of/platform support
  pwm: dwc: add PWM bit unset in get_state call
  pwm: dwc: use clock rate in hz to avoid rounding issues

 .../bindings/pwm/snps,dw-apb-timers-pwm2.yaml |  68 ++++++
 drivers/pwm/Kconfig                           |  26 ++-
 drivers/pwm/Makefile                          |   2 +
 drivers/pwm/pwm-dwc-of.c                      |  76 +++++++
 drivers/pwm/pwm-dwc-pci.c                     | 134 +++++++++++
 drivers/pwm/pwm-dwc.c                         | 210 ++++--------------
 drivers/pwm/pwm-dwc.h                         |  59 +++++
 7 files changed, 404 insertions(+), 171 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml
 create mode 100644 drivers/pwm/pwm-dwc-of.c
 create mode 100644 drivers/pwm/pwm-dwc-pci.c
 create mode 100644 drivers/pwm/pwm-dwc.h

Comments

Ben Dooks Jan. 17, 2023, 4:39 p.m. UTC | #1 
On 23/12/2022 15:38, Ben Dooks wrote:
> An updated set of patches for the Designware PWM driver
> split into PCI and OF versions. I think I got all the
> review issues in this set.
> 
> Sorry for the delay in getting this out, between conferences
> and other absences there has been little time to deal with
> this set. I will be now out of office until 3rd Jan 2023.

Hi, how's the progress on review and getting this set finalised?
Uwe Kleine-König Jan. 17, 2023, 5:07 p.m. UTC | #2 
Hello Ben,

On Tue, Jan 17, 2023 at 04:39:34PM +0000, Ben Dooks wrote:
> On 23/12/2022 15:38, Ben Dooks wrote:
> > An updated set of patches for the Designware PWM driver
> > split into PCI and OF versions. I think I got all the
> > review issues in this set.
> > 
> > Sorry for the delay in getting this out, between conferences
> > and other absences there has been little time to deal with
> > this set. I will be now out of office until 3rd Jan 2023.
> 
> Hi, how's the progress on review and getting this set finalised?

Speaking for me:

Your patch set isn't forgotton. It's just that my time is limited and
reviewing a new driver is time intensive.

I'm sorry I cannot give feedback in a more timely manner, but I will
come to it eventually.

Best regards
Uwe
Thierry Reding Feb. 17, 2023, 3:08 p.m. UTC | #3 
On Fri, 23 Dec 2022 15:38:10 +0000, Ben Dooks wrote:
> An updated set of patches for the Designware PWM driver
> split into PCI and OF versions. I think I got all the
> review issues in this set.
> 
> Sorry for the delay in getting this out, between conferences
> and other absences there has been little time to deal with
> this set. I will be now out of office until 3rd Jan 2023.
> 
> [...]

Applied, thanks!

[01/10] dt-bindings: pwm: Document Synopsys DesignWare snps,pwm-dw-apb-timers-pwm2
        commit: 0f03bf300833c05d914ab7f5ab3d8bc8564e9912
[02/10] pwm: dwc: allow driver to be built with COMPILE_TEST
        commit: c901a57e39db555ad7950fd61e1470cdecc8e654
[03/10] pwm: dwc: change &pci->dev to dev in probe
        commit: 8f3c7ab881ed7329003e10a2dd58f735abda2259
[04/10] pwm: dwc: move memory alloc to own function
        commit: a4218d7cf8978f397e731d1f15ef33d28f77e42b
[05/10] pwm: dwc: use devm_pwmchip_add
        commit: 7a77daf8223e772a225d6aa6202a5b1ae2392caf

Best regards,
Uwe Kleine-König March 10, 2023, 6:21 p.m. UTC | #4 
On Fri, Feb 17, 2023 at 04:08:09PM +0100, Thierry Reding wrote:
> On Fri, 23 Dec 2022 15:38:10 +0000, Ben Dooks wrote:
> > An updated set of patches for the Designware PWM driver
> > split into PCI and OF versions. I think I got all the
> > review issues in this set.
> > 
> > Sorry for the delay in getting this out, between conferences
> > and other absences there has been little time to deal with
> > this set. I will be now out of office until 3rd Jan 2023.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [01/10] dt-bindings: pwm: Document Synopsys DesignWare snps,pwm-dw-apb-timers-pwm2
>         commit: 0f03bf300833c05d914ab7f5ab3d8bc8564e9912
> [02/10] pwm: dwc: allow driver to be built with COMPILE_TEST
>         commit: c901a57e39db555ad7950fd61e1470cdecc8e654
> [03/10] pwm: dwc: change &pci->dev to dev in probe
>         commit: 8f3c7ab881ed7329003e10a2dd58f735abda2259
> [04/10] pwm: dwc: move memory alloc to own function
>         commit: a4218d7cf8978f397e731d1f15ef33d28f77e42b
> [05/10] pwm: dwc: use devm_pwmchip_add
>         commit: 7a77daf8223e772a225d6aa6202a5b1ae2392caf

I had some comments for patches #6 and #10. Patches #7 - #9 are still
marked as new in the PWM patchwork, but I will mark them as
changes-requested in the assumption that you'll have to rework them to
address my feedback for the other two patches anyhow.

Best regards
Uwe