mbox series

[0/3] dyndbg: add source file name to prefix

Message ID 20221223-dyndbg-filename-v1-0-cbf8543009a1@weissschuh.net
Headers
Series dyndbg: add source file name to prefix |

Message

Thomas Weißschuh Jan. 30, 2023, 2:01 a.m. UTC 
  Currently dyndbg has no facility to print the source file name of a
debug statement.
Without the source file the line number is of limited use.
Also the dyndbg control file uses the filename as the primary index, so
having it in the logmessage makes the relation clearer.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
Thomas Weißschuh (3):
      dyndbg: constify opt_array
      dyndbg: increase PREFIX_SIZE to 128
      dyndbg: add source filename to prefix

 Documentation/admin-guide/dynamic-debug-howto.rst | 5 +++--
 include/linux/dynamic_debug.h                     | 4 +++-
 lib/dynamic_debug.c                               | 8 ++++++--
 3 files changed, 12 insertions(+), 5 deletions(-)
---
base-commit: 6d796c50f84ca79f1722bb131799e5a5710c4700
change-id: 20221223-dyndbg-filename-02e0879dae4b

Best regards,

Comments

Thomas Weißschuh March 20, 2023, 10:13 p.m. UTC | #1 
Hi Jim,

did you get a chance to look at this yet?

Thanks,
Thomas

On Mon, Jan 30, 2023 at 02:01:17AM +0000, Thomas Weißschuh wrote:
> Currently dyndbg has no facility to print the source file name of a
> debug statement.
> Without the source file the line number is of limited use.
> Also the dyndbg control file uses the filename as the primary index, so
> having it in the logmessage makes the relation clearer.
> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> Thomas Weißschuh (3):
>       dyndbg: constify opt_array
>       dyndbg: increase PREFIX_SIZE to 128
>       dyndbg: add source filename to prefix
> 
>  Documentation/admin-guide/dynamic-debug-howto.rst | 5 +++--
>  include/linux/dynamic_debug.h                     | 4 +++-
>  lib/dynamic_debug.c                               | 8 ++++++--
>  3 files changed, 12 insertions(+), 5 deletions(-)
> ---
> base-commit: 6d796c50f84ca79f1722bb131799e5a5710c4700
> change-id: 20221223-dyndbg-filename-02e0879dae4b
> 
> Best regards,
> -- 
> Thomas Weißschuh <linux@weissschuh.net>
>
Thomas Weißschuh June 27, 2023, 2:30 p.m. UTC | #2 
Hi Luis and Greg,

it seems you are the ones picking up patches for dyndbg.

Could you take a look at this series?
It has Acks from both Jason and Jim.

Thanks,
Thomas

On 2023-01-30 02:01:17+0000, Thomas Weißschuh wrote:
> Currently dyndbg has no facility to print the source file name of a
> debug statement.
> Without the source file the line number is of limited use.
> Also the dyndbg control file uses the filename as the primary index, so
> having it in the logmessage makes the relation clearer.
> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> Thomas Weißschuh (3):
>       dyndbg: constify opt_array
>       dyndbg: increase PREFIX_SIZE to 128
>       dyndbg: add source filename to prefix
> 
>  Documentation/admin-guide/dynamic-debug-howto.rst | 5 +++--
>  include/linux/dynamic_debug.h                     | 4 +++-
>  lib/dynamic_debug.c                               | 8 ++++++--
>  3 files changed, 12 insertions(+), 5 deletions(-)
> ---
> base-commit: 6d796c50f84ca79f1722bb131799e5a5710c4700
> change-id: 20221223-dyndbg-filename-02e0879dae4b
> 
> Best regards,
> -- 
> Thomas Weißschuh <linux@weissschuh.net>
>
Greg KH June 27, 2023, 2:47 p.m. UTC | #3 
On Tue, Jun 27, 2023 at 04:30:56PM +0200, Thomas Weißschuh wrote:
> Hi Luis and Greg,
> 
> it seems you are the ones picking up patches for dyndbg.
> 
> Could you take a look at this series?
> It has Acks from both Jason and Jim.

It's the middle of the merge window, we can't take anything new, sorry.

Care to submit it after 6.5-rc1 is out?

thanks,

greg k-h
Thomas Weißschuh June 27, 2023, 2:57 p.m. UTC | #4 
On 2023-06-27 16:47:26+0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 27, 2023 at 04:30:56PM +0200, Thomas Weißschuh wrote:
> > Hi Luis and Greg,
> > 
> > it seems you are the ones picking up patches for dyndbg.
> > 
> > Could you take a look at this series?
> > It has Acks from both Jason and Jim.
> 
> It's the middle of the merge window, we can't take anything new, sorry.

Just noticed this, too. Sorry for the noise.

> Care to submit it after 6.5-rc1 is out?

I'll ping again should it still apply cleanly to 6.5-rc1
othewise I'll resend.

Thanks,
Thomas
Greg KH June 27, 2023, 3:01 p.m. UTC | #5 
On Tue, Jun 27, 2023 at 04:57:35PM +0200, Thomas Weißschuh wrote:
> On 2023-06-27 16:47:26+0200, Greg Kroah-Hartman wrote:
> > On Tue, Jun 27, 2023 at 04:30:56PM +0200, Thomas Weißschuh wrote:
> > > Hi Luis and Greg,
> > > 
> > > it seems you are the ones picking up patches for dyndbg.
> > > 
> > > Could you take a look at this series?
> > > It has Acks from both Jason and Jim.
> > 
> > It's the middle of the merge window, we can't take anything new, sorry.
> 
> Just noticed this, too. Sorry for the noise.
> 
> > Care to submit it after 6.5-rc1 is out?
> 
> I'll ping again should it still apply cleanly to 6.5-rc1
> othewise I'll resend.

Resend would be good as this is long gone from out inboxes...