Message ID | 20221222-hid-v1-0-f4a6c35487a5@weissschuh.net |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp142310wrn; Wed, 21 Dec 2022 21:14:07 -0800 (PST) X-Google-Smtp-Source: AMrXdXu4JzJ4LVGKA8tddej+2UmYoGR4xDTSfOjWXOpExNaMb3WKum+5yyi+9qxfBjnm5xyROp2X X-Received: by 2002:a17:906:ad93:b0:7c1:100d:331a with SMTP id la19-20020a170906ad9300b007c1100d331amr3563275ejb.70.1671686047067; Wed, 21 Dec 2022 21:14:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671686047; cv=none; d=google.com; s=arc-20160816; b=b5YWlZYB0yxctqZxJlGfvZOHg4RZETjPKAUlBUiB8anJwktPR0CoNVrtng4wzTDctR UPwYqmDsQHggVDFNwFveV/HLElUwHMqZDYKRm5SwxwevzwVwi8OCF9s4LkoYb5x0LzeB FfRJIzEyGpbXZ9n3cTdbOB/bMsXNG/+yobnWh8ZXBVgVy0mbPMjQ/nZQxzUh9dCZ0o1W NFTkUtdMKwLLV3PTw54H0JCjfv5hF486GgqIWrb1kysLR2x1wDeETb3Zfw4d63rzIq0v Rjhl45zXBrCAFPlthFd+VNBDOmOV7BNzMqwAubjlGfySerfAb6KrVujJfGMy2KeF6Qom xqPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:content-transfer-encoding:mime-version :message-id:date:subject:dkim-signature:from; bh=KGuNxJnMin0qq1COxtQBtHLB0C1vwGasIxsMvPPPoMc=; b=IddArzcGNSA8T7ssMuorFTAm9hncMpp5d5+6iOKzGvgloN/Po2tuv0hq8fqB5MXscn HEU2m1ozQAdriFnbIEpc60tmVEuqZ6KMrgsAE8pTR35gKVc0Q8oC5P6ncYGFlTqgIPl6 q32GAltnQy8DgYnzbjRVYEoriak9oR1oMobh+midZe22Qjty8toDrcPOh7faT17ZW91J 7NS1/z5MaK3eeuFGuA/HaI1g1ryeWAZ9dOSstanHH+p1WE7l5xcQo8owk4gnyNt31f/k TzOfS8hIm7kdMOXZS/LoiB0r67grUs0A3cDLp+HSMbsiPtwNT47FjizEH5vXni300tDC 5XqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=U7HBuKeJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gn15-20020a1709070d0f00b007c18928418bsi17447249ejc.158.2022.12.21.21.13.43; Wed, 21 Dec 2022 21:14:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=U7HBuKeJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235035AbiLVFLL (ORCPT <rfc822;pacteraone@gmail.com> + 99 others); Thu, 22 Dec 2022 00:11:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230451AbiLVFKx (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 22 Dec 2022 00:10:53 -0500 Received: from todd.t-8ch.de (todd.t-8ch.de [IPv6:2a01:4f8:c010:41de::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12959167EA; Wed, 21 Dec 2022 21:10:50 -0800 (PST) From: Thomas =?utf-8?q?Wei=C3=9Fschuh?= <linux@weissschuh.net> DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1671685848; bh=0453VDQMas3wzKqIyLohx5n71ZFMChZfy4arzHwtRes=; h=From:Subject:Date:To:Cc:From; b=U7HBuKeJ5i4EX7wUylFkiAHnl1f3RpDqejjXskNL6OiypyU7jAF3z2zu9pLvh5qUH 4SklyXuN90pOkjWuoxDYkndbqcVFRwtvDaVOVm3CrpP0yCGCM/h82sF4Xxjhrnof1N nyXcaDDKSwzeO87AD6MBrcF6Y7ukrq8W4I8FpBxo= Subject: [PATCH 0/8] HID: remove some unneeded exported symbols from hid.h Date: Thu, 22 Dec 2022 05:10:44 +0000 Message-Id: <20221222-hid-v1-0-f4a6c35487a5@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-B4-Tracking: v=1; b=H4sIANTmo2MC/x2MQQqAIBAAvxJ7TsiNgvpKdNBcc0EslCKQ/t7Sc YZhKhTKTAXmpkKmmwsfSUC3DWzBpJ0UO2HADlEjogrslJ2GQfvJG+xHkNKaQspmk7YgbbpiFHlm 8vz862V93w/PlUFSagAAAA== To: Hans de Goede <hdegoede@redhat.com>, Jiri Kosina <jikos@kernel.org>, Benjamin Tissoires <benjamin.tissoires@redhat.com>, David Rheinsberg <david.rheinsberg@gmail.com>, Marcel Holtmann <marcel@holtmann.org>, Johan Hedberg <johan.hedberg@gmail.com>, Luiz Augusto von Dentz <luiz.dentz@gmail.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com> Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, Thomas =?utf-8?q?Wei=C3=9Fschuh?= <linux@weissschuh.net> X-Mailer: b4 0.11.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1671685844; l=1655; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=0453VDQMas3wzKqIyLohx5n71ZFMChZfy4arzHwtRes=; b=UEW9J5h8xA21rKQnW8+3rDycmx36CZWyTIZ1aT3QhxmBfaPk55tlGKBzP0cAsc7Qokuw2YBn0eU1 ZGj5kp4fCIjcqWWyHO+RRkz/w4oqGlVjnPMAoxSyjhhTz2M8phYc X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752889868429371655?= X-GMAIL-MSGID: =?utf-8?q?1752889868429371655?= |
Series |
HID: remove some unneeded exported symbols from hid.h
|
|
Message
Thomas Weißschuh
Dec. 22, 2022, 5:10 a.m. UTC
Small cleanup to get rid of exports of the lowlevel hid drivers and to make them const. To: Hans de Goede <hdegoede@redhat.com> To: Jiri Kosina <jikos@kernel.org> To: Benjamin Tissoires <benjamin.tissoires@redhat.com> To: David Rheinsberg <david.rheinsberg@gmail.com> To: Marcel Holtmann <marcel@holtmann.org> To: Johan Hedberg <johan.hedberg@gmail.com> To: Luiz Augusto von Dentz <luiz.dentz@gmail.com> To: "David S. Miller" <davem@davemloft.net> To: Eric Dumazet <edumazet@google.com> To: Jakub Kicinski <kuba@kernel.org> To: Paolo Abeni <pabeni@redhat.com> Cc: linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-usb@vger.kernel.org Cc: linux-bluetooth@vger.kernel.org Cc: netdev@vger.kernel.org --- Thomas Weißschuh (8): HID: letsketch: Use hid_is_usb() HID: usbhid: Make hid_is_usb() non-inline HID: Remove unused function hid_is_using_ll_driver() HID: Unexport struct usb_hid_driver HID: Unexport struct uhid_hid_driver HID: Unexport struct hidp_hid_driver HID: Unexport struct i2c_hid_ll_driver HID: Make lowlevel driver structs const drivers/hid/hid-letsketch.c | 2 +- drivers/hid/i2c-hid/i2c-hid-core.c | 3 +-- drivers/hid/uhid.c | 3 +-- drivers/hid/usbhid/hid-core.c | 9 +++++++-- include/linux/hid.h | 18 ++---------------- net/bluetooth/hidp/core.c | 3 +-- 6 files changed, 13 insertions(+), 25 deletions(-) --- base-commit: d264dd3bbbd16b56239e889023fbe49413a58eaf change-id: 20221222-hid-b9551f9fa236 Best regards,
Comments
Hi On Thu, 22 Dec 2022 at 06:10, Thomas Weißschuh <linux@weissschuh.net> wrote: > Small cleanup to get rid of exports of the lowlevel hid drivers and to make > them const. [...] > Thomas Weißschuh (8): > HID: letsketch: Use hid_is_usb() > HID: usbhid: Make hid_is_usb() non-inline > HID: Remove unused function hid_is_using_ll_driver() > HID: Unexport struct usb_hid_driver > HID: Unexport struct uhid_hid_driver > HID: Unexport struct hidp_hid_driver > HID: Unexport struct i2c_hid_ll_driver > HID: Make lowlevel driver structs const Yeah, it makes sense to avoid exposing the structs. Reviewed-by: David Rheinsberg <david.rheinsberg@gmail.com> Thanks David
Hi, On 12/22/22 06:10, Thomas Weißschuh wrote: > Small cleanup to get rid of exports of the lowlevel hid drivers and to make > them const. Thanks, the entire series looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> for the series. Regards, Hans > > To: Hans de Goede <hdegoede@redhat.com> > To: Jiri Kosina <jikos@kernel.org> > To: Benjamin Tissoires <benjamin.tissoires@redhat.com> > To: David Rheinsberg <david.rheinsberg@gmail.com> > To: Marcel Holtmann <marcel@holtmann.org> > To: Johan Hedberg <johan.hedberg@gmail.com> > To: Luiz Augusto von Dentz <luiz.dentz@gmail.com> > To: "David S. Miller" <davem@davemloft.net> > To: Eric Dumazet <edumazet@google.com> > To: Jakub Kicinski <kuba@kernel.org> > To: Paolo Abeni <pabeni@redhat.com> > Cc: linux-input@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-usb@vger.kernel.org > Cc: linux-bluetooth@vger.kernel.org > Cc: netdev@vger.kernel.org > > --- > Thomas Weißschuh (8): > HID: letsketch: Use hid_is_usb() > HID: usbhid: Make hid_is_usb() non-inline > HID: Remove unused function hid_is_using_ll_driver() > HID: Unexport struct usb_hid_driver > HID: Unexport struct uhid_hid_driver > HID: Unexport struct hidp_hid_driver > HID: Unexport struct i2c_hid_ll_driver > HID: Make lowlevel driver structs const > > drivers/hid/hid-letsketch.c | 2 +- > drivers/hid/i2c-hid/i2c-hid-core.c | 3 +-- > drivers/hid/uhid.c | 3 +-- > drivers/hid/usbhid/hid-core.c | 9 +++++++-- > include/linux/hid.h | 18 ++---------------- > net/bluetooth/hidp/core.c | 3 +-- > 6 files changed, 13 insertions(+), 25 deletions(-) > --- > base-commit: d264dd3bbbd16b56239e889023fbe49413a58eaf > change-id: 20221222-hid-b9551f9fa236 > > Best regards,
On Thu, 22 Dec 2022, Thomas Weißschuh wrote: > Small cleanup to get rid of exports of the lowlevel hid drivers and to make > them const. > > To: Hans de Goede <hdegoede@redhat.com> > To: Jiri Kosina <jikos@kernel.org> > To: Benjamin Tissoires <benjamin.tissoires@redhat.com> > To: David Rheinsberg <david.rheinsberg@gmail.com> > To: Marcel Holtmann <marcel@holtmann.org> > To: Johan Hedberg <johan.hedberg@gmail.com> > To: Luiz Augusto von Dentz <luiz.dentz@gmail.com> > To: "David S. Miller" <davem@davemloft.net> > To: Eric Dumazet <edumazet@google.com> > To: Jakub Kicinski <kuba@kernel.org> > To: Paolo Abeni <pabeni@redhat.com> > Cc: linux-input@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-usb@vger.kernel.org > Cc: linux-bluetooth@vger.kernel.org > Cc: netdev@vger.kernel.org > > --- > Thomas Weißschuh (8): > HID: letsketch: Use hid_is_usb() > HID: usbhid: Make hid_is_usb() non-inline > HID: Remove unused function hid_is_using_ll_driver() > HID: Unexport struct usb_hid_driver > HID: Unexport struct uhid_hid_driver > HID: Unexport struct hidp_hid_driver > HID: Unexport struct i2c_hid_ll_driver > HID: Make lowlevel driver structs const > > drivers/hid/hid-letsketch.c | 2 +- > drivers/hid/i2c-hid/i2c-hid-core.c | 3 +-- > drivers/hid/uhid.c | 3 +-- > drivers/hid/usbhid/hid-core.c | 9 +++++++-- > include/linux/hid.h | 18 ++---------------- > net/bluetooth/hidp/core.c | 3 +-- > 6 files changed, 13 insertions(+), 25 deletions(-) Applied to hid.git#for-6.3/hid-core. Thanks,