From patchwork Mon Dec 19 18:31:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 3106 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp2551238wrn; Mon, 19 Dec 2022 10:35:49 -0800 (PST) X-Google-Smtp-Source: AA0mqf4aqCsp5xOOoyrDB8pnCfXSBKtEApDOGmbhYKZuMvHLWwzjg7r4q8Oa4u3PkQ5M50QgjG2L X-Received: by 2002:aa7:96d4:0:b0:576:8e8d:6675 with SMTP id h20-20020aa796d4000000b005768e8d6675mr48651133pfq.19.1671474948958; Mon, 19 Dec 2022 10:35:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671474948; cv=none; d=google.com; s=arc-20160816; b=gAhoLXaoB7Pz3QXOe3VbSHFBTL7sqPkpOoskttaSaWV+W5YFd9JxQCKrvb6x6cQV5p q9/JL80D7IojzoHIUMdwez+8e2k/+BcwY1SiIoMcfRMHgBGNxqyqqkMMn4628RWpZJIA 6bTd+ke/lvcp2EaTY06/Q+DCt8PWuyvNPJ6M8GWg+SA14pKU88La8FD8vI1FmQXXELkR HZmMHybjVQji4fe0ISZ++BXjWKylDDOZ3fvHFXpIkgB2LSSaAEovmpvCtdwCoew7xSK8 V/6kmjOWiJuEL2hHrAw48S1e0lDshz2bTytkjm6xyKQfOkxSOgdgnL7UEv51GhhuC0SH v8mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:date:user-agent:message-id; bh=ZZz2jBi8GG+6eLUUHjMZdGke8KpVftgyyIbn4/Y6ePY=; b=mm7WqKo7jocwlhHl3sQ3MtfEuHIsmv+977UhNuWCqXEBrGq/KxJ/CggZqUTxltFHA1 lXnaR2tpvceVeRQkQCMEXiNMp0xx873QHbsTJqXtCeyKIjNWsE1/E38ZQ6ht82kviQyT Y+TgpnxEpgOOuUwLuB8Fl8vgJckLIYNyQ/cMnnAURqn7ipEP+RoNgOmt/rwGao9OzIt/ 9tsKkkflisfpYDKUhPwIix1UK0RiJdpkQJ0II57iBY9qUb9NmRL7pnZbb4WfJZ8S8Jbo O2Tinxre4goDn4JhH3kq2TAwPUFc4to4nOR+jLV1JUtGNlOF6o5Z51WJ9vy0eli9iuEo LdXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q13-20020a056a00084d00b0056b8ae6149csi12351321pfk.244.2022.12.19.10.35.36; Mon, 19 Dec 2022 10:35:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232400AbiLSSfL (ORCPT + 99 others); Mon, 19 Dec 2022 13:35:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232568AbiLSSe3 (ORCPT ); Mon, 19 Dec 2022 13:34:29 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1AF11176; Mon, 19 Dec 2022 10:32:17 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 58697B80F62; Mon, 19 Dec 2022 18:32:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3C30C433D2; Mon, 19 Dec 2022 18:32:14 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1p7Kvt-0005SZ-2r; Mon, 19 Dec 2022 13:32:13 -0500 Message-ID: <20221219183106.518341498@goodmis.org> User-Agent: quilt/0.66 Date: Mon, 19 Dec 2022 13:31:06 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Masami Hiramatsu , Andrew Morton , Ross Zwisler , Tom Zanussi , Zheng Yejian Subject: [PATCH 0/2] tracing: Add a way to filter function addresses to function names X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752213220634337125?= X-GMAIL-MSGID: =?utf-8?q?1752668515860950445?= There's been several times where an event records a function address in its field and I needed to filter on that address for a specific function name. It required looking up the function in kallsyms, finding its size, and doing a compare of "field >= function_start && field < function_end". But this would change from boot to boot and is unreliable in scripts. Also, it is useful to have this at boot up, where the addresses will not be known. For example, on the boot command line: trace_trigger="initcall_finish.traceoff if func.function == acpi_init" To implement this, add a ".function" prefix, that will check that the field is of size long, and the only operations allowed (so far) are "==" and "!=". Changes since v1: https://lore.kernel.org/linux-trace-kernel/20221214125209.09d736dd@gandalf.local.home/ - Fix commit log "initcall_finish.function" to "func.function" (Ross Zwisler) - Fixed processing of address (Ross Zwisler) - Added selftest (Masami Hiramatsu) - Just use "trigger" instead of "strsep(&trigger, "")" (Zheng Yejian) Steven Rostedt (Google) (2): tracing: Add a way to filter function addresses to function names tracing/selftests: Add test for event filtering on function name ---- Documentation/trace/events.rst | 12 +++ kernel/trace/trace_events.c | 2 +- kernel/trace/trace_events_filter.c | 93 +++++++++++++++++++++- .../ftrace/test.d/filter/event-filter-function.tc | 58 ++++++++++++++ 4 files changed, 163 insertions(+), 2 deletions(-) create mode 100644 tools/testing/selftests/ftrace/test.d/filter/event-filter-function.tc