mbox series

[v2,00/10] A few bugfix and cleancode patch for bfq

Message ID 20221216111230.3638832-1-shikemeng@huaweicloud.com
Headers
Series A few bugfix and cleancode patch for bfq |

Message

Kemeng Shi Dec. 16, 2022, 11:12 a.m. UTC 
  Hi, this series contain two patches to fix bug in request injection
mechanism and some random cleancode patches.
Thanks!

---
v2:
 -improve git log.
---

Kemeng Shi (10):
  block, bfq: correctly raise inject limit in
    bfq_choose_bfqq_for_injection
  block, bfq: remove unsed parameter reason in bfq_bfqq_is_slow
  block, bfq: initialize bfqq->decrease_time_jif correctly
  block, bfq: use helper macro RQ_BFQQ to get bfqq of request
  block, bfq: remove unnecessary dereference to get async_bfqq
  block, bfq: remove redundant bfqd->rq_in_driver > 0 check in
    bfq_add_request
  block, bfq: remove redundant check in bfq_put_cooperator
  block, bfq: remove unnecessary goto tag in bfq_dispatch_rq_from_bfqq
  block, bfq: remove unused bfq_wr_max_time in struct bfq_data
  block, bfq: remove check of bfq_wr_max_softrt_rate which is always
    greater than 0

 block/bfq-iosched.c | 49 +++++++++++++++++----------------------------
 block/bfq-iosched.h |  2 --
 2 files changed, 18 insertions(+), 33 deletions(-)

Comments

Kemeng Shi Dec. 27, 2022, 7:26 a.m. UTC | #1 
Friendly ping...

on 12/16/2022 7:12 PM, Kemeng Shi wrote:
> Hi, this series contain two patches to fix bug in request injection
> mechanism and some random cleancode patches.
> Thanks!
> 
> ---
> v2:
>  -improve git log.
> ---
> 
> Kemeng Shi (10):
>   block, bfq: correctly raise inject limit in
>     bfq_choose_bfqq_for_injection
>   block, bfq: remove unsed parameter reason in bfq_bfqq_is_slow
>   block, bfq: initialize bfqq->decrease_time_jif correctly
>   block, bfq: use helper macro RQ_BFQQ to get bfqq of request
>   block, bfq: remove unnecessary dereference to get async_bfqq
>   block, bfq: remove redundant bfqd->rq_in_driver > 0 check in
>     bfq_add_request
>   block, bfq: remove redundant check in bfq_put_cooperator
>   block, bfq: remove unnecessary goto tag in bfq_dispatch_rq_from_bfqq
>   block, bfq: remove unused bfq_wr_max_time in struct bfq_data
>   block, bfq: remove check of bfq_wr_max_softrt_rate which is always
>     greater than 0
> 
>  block/bfq-iosched.c | 49 +++++++++++++++++----------------------------
>  block/bfq-iosched.h |  2 --
>  2 files changed, 18 insertions(+), 33 deletions(-)
>