From patchwork Fri Dec 9 14:01:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 2817 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp794616wrr; Fri, 9 Dec 2022 06:06:49 -0800 (PST) X-Google-Smtp-Source: AA0mqf7LfWvppCcC5thdBW1KW0kpz9a07NyufSfSjH0lTborh0CqM00zp1E9S/jByDtwuL1cwws7 X-Received: by 2002:a17:90a:6c96:b0:212:ef19:1e0 with SMTP id y22-20020a17090a6c9600b00212ef1901e0mr5772346pjj.1.1670594809270; Fri, 09 Dec 2022 06:06:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670594809; cv=none; d=google.com; s=arc-20160816; b=ddYuNOKxFqlTVC5823xVY3pO0T2fCQ5jp0+dpCZtEOU2bxYu3eiLA9xU/OSAyhMd4s JU3WnytG+UcvcQbg4kuC0IIhHndL7R6uk0GLrfsCo+nGWWJcaWZEmEUGwOA94pQixcQM SJxMATTDeCNP+p84t+qnwppcvU34+I4XQPSUhYXU3sIl8neI2YyXdXGkjyWFCVoeo23E Pn5a4yK0BZp4ENXGL3V6dG2SDshcDgKTR1hbrQ9nBOV5lOun++iCjb9+y23yFdgO2shD rDJG8mtB41EBqujMO1EqqxeiHF4cDQennzaZnUjRNa1cPJLZ2r+QnNBg6xdc18hfWCgW psrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=5RbPgV/UxybIK6BFXyRxu+vvt9zqkVKvnwQW2NcyIzQ=; b=tRSsY/omDb86zYf9gWup+NrBEM3YWtnxP/2GNpghrDOGrkZLzOmOOaYGKSoARNvt5p AN/bTvXp0xpsdpSfOhmBo1KYh8ppauaitRlhQZyow56wZbe7jDb/6i4diWXRLkmZYnJP ATdLqMyNjMVU5YoXMnXsE6XiInBQrPf0YLJpkfpCeaTZSkzGEG95eDXpQ8FJERKZ3PIr NfW4hoWa6golbOLbQJPBI1hNPQS6CK+RnwHUd1vxEWKxzJP4m0TGoZWC+v9cj6apC1R0 QrmkMs98sgcfBiWG/dxeJEFXeCc3fnaRUHHiRAvzsSx9U1S42/PEZT/1WY4JRztNINFc JS5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=B1fmxikq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id my9-20020a17090b4c8900b0021d20da7a5fsi2444675pjb.120.2022.12.09.06.06.28; Fri, 09 Dec 2022 06:06:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=B1fmxikq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230084AbiLIOFr (ORCPT + 99 others); Fri, 9 Dec 2022 09:05:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229892AbiLIOFT (ORCPT ); Fri, 9 Dec 2022 09:05:19 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 487287723F; Fri, 9 Dec 2022 06:05:15 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9E71BB821FB; Fri, 9 Dec 2022 14:05:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 493D5C433EF; Fri, 9 Dec 2022 14:05:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670594713; bh=6uHKC/rYNMZbGqgdzTkCFSACHYrX65u6glI/1+02iB0=; h=From:To:Cc:Subject:Date:From; b=B1fmxikqb8Fw67G0tC7YA9Efg+IL/HqcUBdjDdfPrsQhNY/mQBKRtz5YnrDnnVhUc BEJezUadtkdrQD5ixCWcX/j4cRItCf0riR0INKkRNXKwmhg3/nfM6Qu8jyrkUJ3xcV c9QE3PZlgs9qCvOHj8wjdpVddifI2S0oeA4j6MZJfgFKtTxnSbd0cPCq9K6djnrJy1 rYznRVt4XbTP0sQVPKxMOkfq//4yg+66BT0EwB6v7pi8nz7vaCpAR7sBClK2YPq6pn zOB/CxyUVyyrJ+V4scR2b8ucmxivPTUb5ESteT8w/ypt1NER1wSEyW1Gbgf6bkYT6i m6ZuhT2qjK++g== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1p3e0I-0000RN-3S; Fri, 09 Dec 2022 15:05:30 +0100 From: Johan Hovold To: Marc Zyngier Cc: Thomas Gleixner , x86@kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v3 00/19] irqdomain: fix mapping race and clean up locking Date: Fri, 9 Dec 2022 15:01:31 +0100 Message-Id: <20221209140150.1453-1-johan+linaro@kernel.org> X-Mailer: git-send-email 2.37.4 MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751745622405788900?= X-GMAIL-MSGID: =?utf-8?q?1751745622405788900?= Parallel probing (e.g. due to asynchronous probing) of devices that share interrupts can currently result in two mappings for the same hardware interrupt to be created. This series fixes this mapping race and clean up the irqdomain locking so that in the end the global irq_domain_mutex is only used for managing the likewise global irq_domain_list, while domain operations (e.g. IRQ allocations) use per-domain (hierarchy) locking. Johan Changes in v2 - split out redundant-lookup cleanup (1/4) - use a per-domain mutex to address mapping race (2/4) - move kernel-doc to exported function (2/4) - fix association race (3/4, new) - use per-domain mutex for associations (4/4, new) Changes in v3 - drop dead and bogus code (1--3/19, new) - fix racy mapcount accesses (5/19, new) - drop revmap mutex (6/19, new) - use irq_domain_mutex to address mapping race (9/19) - clean up irq_domain_push/pop_irq() (10/19, new) - use irq_domain_create_hierarchy() to construct hierarchies (11--18/19, new) - switch to per-domain locking (19/19, new) Johan Hovold (19): irqdomain: Drop bogus fwspec-mapping error handling irqdomain: Drop dead domain-name assignment irqdomain: Drop leftover brackets irqdomain: Fix association race irqdomain: Fix disassociation race irqdomain: Drop revmap mutex irqdomain: Look for existing mapping only once irqdomain: Refactor __irq_domain_alloc_irqs() irqdomain: Fix mapping-creation race irqdomain: Clean up irq_domain_push/pop_irq() x86/ioapic: Use irq_domain_create_hierarchy() x86/apic: Use irq_domain_create_hierarchy() irqchip/alpine-msi: Use irq_domain_add_hierarchy() irqchip/gic-v2m: Use irq_domain_create_hierarchy() irqchip/gic-v3-its: Use irq_domain_create_hierarchy() irqchip/gic-v3-mbi: Use irq_domain_create_hierarchy() irqchip/loongson-pch-msi: Use irq_domain_create_hierarchy() irqchip/mvebu-odmi: Use irq_domain_create_hierarchy() irqdomain: Switch to per-domain locking arch/x86/kernel/apic/io_apic.c | 8 +- arch/x86/platform/uv/uv_irq.c | 7 +- drivers/irqchip/irq-alpine-msi.c | 8 +- drivers/irqchip/irq-gic-v2m.c | 5 +- drivers/irqchip/irq-gic-v3-its.c | 13 +- drivers/irqchip/irq-gic-v3-mbi.c | 5 +- drivers/irqchip/irq-loongson-pch-msi.c | 9 +- drivers/irqchip/irq-mvebu-odmi.c | 13 +- include/linux/irqdomain.h | 6 +- kernel/irq/irqdomain.c | 328 ++++++++++++++----------- 10 files changed, 220 insertions(+), 182 deletions(-) Tested-by: Hsin-Yi Wang