mbox series

[v2,0/2] fix out-of-bounds access when specifying invalid console

Message ID 20221209112737.3222509-1-svens@linux.ibm.com
Headers
Series fix out-of-bounds access when specifying invalid console |

Message

Sven Schnelle Dec. 9, 2022, 11:27 a.m. UTC 
  Hi,

these two patches fix a crash in the tty driver when a user specifies an
invalid console like 'console=tty3000'. The first patch adds a check to
tty_driver_lookup_tty(), the second one prevents that such a console gets
registered in the vt driver.

Changes in v2:
- trim commit message in first patch
- add second patch as suggested by Jiri Slaby

Sven Schnelle (2):
  tty: fix out-of-bounds access in tty_driver_lookup_tty()
  tty/vt: prevent registration of console with invalid number

 drivers/tty/tty_io.c | 8 +++++---
 drivers/tty/vt/vt.c  | 6 ++++++
 2 files changed, 11 insertions(+), 3 deletions(-)

Comments

Sven Schnelle Jan. 4, 2023, 7:20 a.m. UTC | #1 
Sven Schnelle <svens@linux.ibm.com> writes:

> Hi,
>
> these two patches fix a crash in the tty driver when a user specifies an
> invalid console like 'console=tty3000'. The first patch adds a check to
> tty_driver_lookup_tty(), the second one prevents that such a console gets
> registered in the vt driver.
>
> Changes in v2:
> - trim commit message in first patch
> - add second patch as suggested by Jiri Slaby
>
> Sven Schnelle (2):
>   tty: fix out-of-bounds access in tty_driver_lookup_tty()
>   tty/vt: prevent registration of console with invalid number
>
>  drivers/tty/tty_io.c | 8 +++++---
>  drivers/tty/vt/vt.c  | 6 ++++++
>  2 files changed, 11 insertions(+), 3 deletions(-)

Gentle ping... I couldn't find that this was applied anywhere?

Thanks
Sven
Greg KH Jan. 4, 2023, 8:26 a.m. UTC | #2 
On Wed, Jan 04, 2023 at 08:20:49AM +0100, Sven Schnelle wrote:
> Sven Schnelle <svens@linux.ibm.com> writes:
> 
> > Hi,
> >
> > these two patches fix a crash in the tty driver when a user specifies an
> > invalid console like 'console=tty3000'. The first patch adds a check to
> > tty_driver_lookup_tty(), the second one prevents that such a console gets
> > registered in the vt driver.
> >
> > Changes in v2:
> > - trim commit message in first patch
> > - add second patch as suggested by Jiri Slaby
> >
> > Sven Schnelle (2):
> >   tty: fix out-of-bounds access in tty_driver_lookup_tty()
> >   tty/vt: prevent registration of console with invalid number
> >
> >  drivers/tty/tty_io.c | 8 +++++---
> >  drivers/tty/vt/vt.c  | 6 ++++++
> >  2 files changed, 11 insertions(+), 3 deletions(-)
> 
> Gentle ping... I couldn't find that this was applied anywhere?

It's in my to-review queue, which is about 2000+ patches right now, give
me some time to dig it out.  In the meantime, please feel free to review
other pending patches on the list to help out with the workload.

thanks,

greg k-h
Greg KH Jan. 19, 2023, 2:04 p.m. UTC | #3 
On Wed, Jan 04, 2023 at 08:20:49AM +0100, Sven Schnelle wrote:
> Sven Schnelle <svens@linux.ibm.com> writes:
> 
> > Hi,
> >
> > these two patches fix a crash in the tty driver when a user specifies an
> > invalid console like 'console=tty3000'. The first patch adds a check to
> > tty_driver_lookup_tty(), the second one prevents that such a console gets
> > registered in the vt driver.
> >
> > Changes in v2:
> > - trim commit message in first patch
> > - add second patch as suggested by Jiri Slaby
> >
> > Sven Schnelle (2):
> >   tty: fix out-of-bounds access in tty_driver_lookup_tty()
> >   tty/vt: prevent registration of console with invalid number
> >
> >  drivers/tty/tty_io.c | 8 +++++---
> >  drivers/tty/vt/vt.c  | 6 ++++++
> >  2 files changed, 11 insertions(+), 3 deletions(-)
> 
> Gentle ping... I couldn't find that this was applied anywhere?

Sorry, still digging out of a lot of patches...