mbox series

[RFC,0/3] Add support control UP board CPLD/FPGA pin control

Message ID 20221207163359.26564-1-larry.lai@yunjingtech.com
Headers
Series Add support control UP board CPLD/FPGA pin control |

Message

larry.lai Dec. 7, 2022, 4:33 p.m. UTC 
  The UP board <http://www.upboard.com> is the computer board for 
Professional Makers and Industrial Applications. We want to upstream 
the UP board 40-pin GP-bus Kernel driver for giving the users better 
experience on the software release. (not just download from UP board 
github)

These patches are generated from the Linux kernel mainline tag v6.0.

larry.lai (3):
  mfd: Add support for UP board CPLD/FPGA
  pinctrl: Add support pin control for UP board CPLD/FPGA
  leds: Add support for UP board CPLD onboard LEDS

 drivers/leds/Kconfig              |   10 +
 drivers/leds/Makefile             |    1 +
 drivers/leds/leds-upboard.c       |   79 ++
 drivers/mfd/Kconfig               |   12 +
 drivers/mfd/Makefile              |    1 +
 drivers/mfd/upboard-fpga.c        |  669 ++++++++++++++
 drivers/pinctrl/Kconfig           |   14 +
 drivers/pinctrl/Makefile          |    1 +
 drivers/pinctrl/pinctrl-upboard.c | 1384 +++++++++++++++++++++++++++++
 include/linux/mfd/upboard-fpga.h  |   58 ++
 10 files changed, 2229 insertions(+)
 create mode 100644 drivers/leds/leds-upboard.c
 create mode 100644 drivers/mfd/upboard-fpga.c
 create mode 100644 drivers/pinctrl/pinctrl-upboard.c
 create mode 100644 include/linux/mfd/upboard-fpga.h


base-commit: 4fe89d07dcc2804c8b562f6c7896a45643d34b2f

Comments

Linus Walleij Dec. 7, 2022, 9:09 p.m. UTC | #1 
On Wed, Dec 7, 2022 at 5:36 PM larry.lai <larry.lai@yunjingtech.com> wrote:

> The UP board <http://www.upboard.com> is the computer board for
> Professional Makers and Industrial Applications. We want to upstream
> the UP board 40-pin GP-bus Kernel driver for giving the users better
> experience on the software release. (not just download from UP board
> github)
>
> These patches are generated from the Linux kernel mainline tag v6.0.

Why are these patches tagged RFC now? Weird.

Came to think of this:
Shouldn't the subdrivers for pin control LED etc have:
default MFD_INTEL_UPBOARD_FPGA
i.e become y if the core driver is y, becomes m if the core driver is m.
Of course it is possible to run around in menuconfig and activate them
all manually interactively and be frustrated that something is missing
still but setting them default like this saves everybody's time. Activate
the MFD core driver and everything else comes with it, then it can
be turned off at request.

Yours,
Linus Walleij
Andy Shevchenko Dec. 7, 2022, 9:33 p.m. UTC | #2 
On Wed, Dec 07, 2022 at 10:09:35PM +0100, Linus Walleij wrote:
> On Wed, Dec 7, 2022 at 5:36 PM larry.lai <larry.lai@yunjingtech.com> wrote:
> 
> > The UP board <http://www.upboard.com> is the computer board for
> > Professional Makers and Industrial Applications. We want to upstream
> > the UP board 40-pin GP-bus Kernel driver for giving the users better
> > experience on the software release. (not just download from UP board
> > github)
> >
> > These patches are generated from the Linux kernel mainline tag v6.0.
> 
> Why are these patches tagged RFC now? Weird.

I can easily tell you, this code is no go, too many problematic places.
Andy Shevchenko Dec. 7, 2022, 9:36 p.m. UTC | #3 
On Thu, Dec 08, 2022 at 12:33:56AM +0800, larry.lai wrote:
> The UP board <http://www.upboard.com> is the computer board for 
> Professional Makers and Industrial Applications. We want to upstream 
> the UP board 40-pin GP-bus Kernel driver for giving the users better 
> experience on the software release. (not just download from UP board 
> github)
> 
> These patches are generated from the Linux kernel mainline tag v6.0.

I have just checked the v3 (previous version of this) and I haven't found any
evidence that I gave my tag or permission to use it. What the heck is going on
here?!
Andy Shevchenko Dec. 7, 2022, 9:38 p.m. UTC | #4 
On Wed, Dec 07, 2022 at 11:36:37PM +0200, Andy Shevchenko wrote:
> On Thu, Dec 08, 2022 at 12:33:56AM +0800, larry.lai wrote:
> > The UP board <http://www.upboard.com> is the computer board for 
> > Professional Makers and Industrial Applications. We want to upstream 
> > the UP board 40-pin GP-bus Kernel driver for giving the users better 
> > experience on the software release. (not just download from UP board 
> > github)
> > 
> > These patches are generated from the Linux kernel mainline tag v6.0.
> 
> I have just checked the v3 (previous version of this) and I haven't found any
> evidence that I gave my tag or permission to use it. What the heck is going on
> here?!

NAK to this series.