mbox series

[0/5] staging: drivers: mfd: Add MAX77541 MFD and related device drivers

Message ID 20221207090906.5896-1-okan.sahin@analog.com
Headers
Series staging: drivers: mfd: Add MAX77541 MFD and related device drivers |

Message

Sahin, Okan Dec. 7, 2022, 9:08 a.m. UTC 
  This patchset adds mfd, regulator and adc driver and related bindings.The patches 
are required to be applied in sequence.

Okan Sahin (5):
  staging: drivers: mfd: Add MAX77541/MAX77540 PMIC Support
  staging: dt-bindings: mfd: adi,max77541.yaml Add MAX77541 bindings
  staging: drivers: regulator: Add MAX77541 Regulator Support
  staging: dt-bindings: regulator: adi,max77541.yaml Add MAX77541
    Regulator bindings
  staging: drivers: iio: adc: Adc MAX77541 ADC Support

 .../devicetree/bindings/mfd/adi,max77541.yaml | 134 ++++++++++
 .../bindings/regulator/adi,max77541.yaml      |  44 ++++
 MAINTAINERS                                   |  11 +
 drivers/iio/adc/Kconfig                       |  11 +
 drivers/iio/adc/Makefile                      |   1 +
 drivers/iio/adc/max77541-adc.c                | 224 +++++++++++++++++
 drivers/mfd/Kconfig                           |  13 +
 drivers/mfd/Makefile                          |   1 +
 drivers/mfd/max77541.c                        | 236 ++++++++++++++++++
 drivers/regulator/Kconfig                     |   9 +
 drivers/regulator/Makefile                    |   1 +
 drivers/regulator/max77541-regulator.c        | 181 ++++++++++++++
 include/linux/mfd/max77541.h                  | 150 +++++++++++
 13 files changed, 1016 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/adi,max77541.yaml
 create mode 100644 Documentation/devicetree/bindings/regulator/adi,max77541.yaml
 create mode 100644 drivers/iio/adc/max77541-adc.c
 create mode 100644 drivers/mfd/max77541.c
 create mode 100644 drivers/regulator/max77541-regulator.c
 create mode 100644 include/linux/mfd/max77541.h

Comments

Andy Shevchenko Dec. 7, 2022, 11:09 a.m. UTC | #1 
On Wed, Dec 07, 2022 at 12:08:39PM +0300, Okan Sahin wrote:
> This patchset adds mfd, regulator and adc driver and related bindings.The patches 
> are required to be applied in sequence.

You have an indentation / wrapping issues in the above text.

Nevertheless, why staging? What does it mean?
Jonathan Cameron Dec. 11, 2022, 12:20 p.m. UTC | #2 
On Wed, 7 Dec 2022 13:09:34 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Wed, Dec 07, 2022 at 12:08:39PM +0300, Okan Sahin wrote:
> > This patchset adds mfd, regulator and adc driver and related bindings.The patches 
> > are required to be applied in sequence.  
> 
> You have an indentation / wrapping issues in the above text.
> 
> Nevertheless, why staging? What does it mean?
> 

The main reason to go via staging is because a driver is sitting out
of tree and it is useful to bring it in on the basis that it can then be
cleaned up in tree before moving out of staging.

For a relatively small driver like this, that's hard to argue.  Just
clean it up in response to review feedback and then we can take it
directly into relevant subsystems in the main tree.

Jonathan
Andy Shevchenko Dec. 11, 2022, 1:34 p.m. UTC | #3 
On Sun, Dec 11, 2022 at 12:20:43PM +0000, Jonathan Cameron wrote:
> On Wed, 7 Dec 2022 13:09:34 +0200
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > On Wed, Dec 07, 2022 at 12:08:39PM +0300, Okan Sahin wrote:
> > > This patchset adds mfd, regulator and adc driver and related bindings.The patches 
> > > are required to be applied in sequence.  
> > 
> > You have an indentation / wrapping issues in the above text.
> > 
> > Nevertheless, why staging? What does it mean?
> 
> The main reason to go via staging is because a driver is sitting out
> of tree and it is useful to bring it in on the basis that it can then be
> cleaned up in tree before moving out of staging.

But files are not in staging. Me being confused.

> For a relatively small driver like this, that's hard to argue.  Just
> clean it up in response to review feedback and then we can take it
> directly into relevant subsystems in the main tree.
Jonathan Cameron Dec. 11, 2022, 2:07 p.m. UTC | #4 
On Sun, 11 Dec 2022 15:34:10 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Sun, Dec 11, 2022 at 12:20:43PM +0000, Jonathan Cameron wrote:
> > On Wed, 7 Dec 2022 13:09:34 +0200
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:  
> > > On Wed, Dec 07, 2022 at 12:08:39PM +0300, Okan Sahin wrote:  
> > > > This patchset adds mfd, regulator and adc driver and related bindings.The patches 
> > > > are required to be applied in sequence.    
> > > 
> > > You have an indentation / wrapping issues in the above text.
> > > 
> > > Nevertheless, why staging? What does it mean?  
> > 
> > The main reason to go via staging is because a driver is sitting out
> > of tree and it is useful to bring it in on the basis that it can then be
> > cleaned up in tree before moving out of staging.  
> 
> But files are not in staging. Me being confused.

I noticed that when I got to the patches :)
Odd indeed - I'm guessing some cut and paste gone wrong.

Jonathan

> 
> > For a relatively small driver like this, that's hard to argue.  Just
> > clean it up in response to review feedback and then we can take it
> > directly into relevant subsystems in the main tree.  
>