mbox series

[net-next,v3,0/2] dsa: lan9303: Move to PHYLINK

Message ID 20221206183500.6898-1-jerry.ray@microchip.com
Headers
Series dsa: lan9303: Move to PHYLINK |

Message

Jerry Ray Dec. 6, 2022, 6:34 p.m. UTC 
  This patch series moves the lan9303 driver to use the phylink
api away from phylib.

1) adds port_max_mtu api support.
2) Replace .adjust_link with .phylink_get_caps dsa api

Clearing the Turbo Mode bit previously done in the adjust_link
API is moved to the driver initialization immediately following
the successful detection of a LAN93xx device.  It is forced to a
disabled state and never enabled.

At this point, I do not see anything this driver needs from the other
phylink APIs.

Signed-off-by: Jerry Ray <jerry.ray@microchip.com>

---
v2-> v3:
  Added back in disabling Turbo Mode on the CPU MII interface.
  Removed the unnecessary clearing of the phyvsupported interfaces.
v1-> v2:
  corrected the reported mtu size, removing ETH_HLEN and ETH_FCS_LEN

 drivers/net/dsa/lan9303-core.c | 93 ++++++++++++--------
 1 file changed, 56 insertions(+), 37 deletions(-)

Comments

Vladimir Oltean Dec. 6, 2022, 6:57 p.m. UTC | #1 
On Tue, Dec 06, 2022 at 12:34:58PM -0600, Jerry Ray wrote:
> This patch series moves the lan9303 driver to use the phylink
> api away from phylib.
> 
> 1) adds port_max_mtu api support.
> 2) Replace .adjust_link with .phylink_get_caps dsa api

What does the max MTU have to do with phylink? What is it that makes
these two patches related?

> 
> Clearing the Turbo Mode bit previously done in the adjust_link
> API is moved to the driver initialization immediately following
> the successful detection of a LAN93xx device.  It is forced to a
> disabled state and never enabled.
> 
> At this point, I do not see anything this driver needs from the other
> phylink APIs.
> 
> Signed-off-by: Jerry Ray <jerry.ray@microchip.com>

You don't need to put your sign off on the cover letter.
Jerry Ray Dec. 6, 2022, 11:58 p.m. UTC | #2 
> > This patch series moves the lan9303 driver to use the phylink
> > api away from phylib.
> >
> > 1) adds port_max_mtu api support.
> > 2) Replace .adjust_link with .phylink_get_caps dsa api
> 
> What does the max MTU have to do with phylink? What is it that makes
> these two patches related?
> 

I'm touching the same file, so I created this series of patches to avoid
piecewise patching conflicts that might have resulted if they were
independent patches.

> >
> > Clearing the Turbo Mode bit previously done in the adjust_link
> > API is moved to the driver initialization immediately following
> > the successful detection of a LAN93xx device.  It is forced to a
> > disabled state and never enabled.
> >
> > At this point, I do not see anything this driver needs from the other
> > phylink APIs.
> >
> > Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
> 
> You don't need to put your sign off on the cover letter.
> 

Understood.  Thx,
J.