From patchwork Mon Dec 5 11:57:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 2586 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2054915wrr; Sun, 4 Dec 2022 19:58:28 -0800 (PST) X-Google-Smtp-Source: AA0mqf4ledRXj6EY10818X4121VZ51XX62uxXGNi8J2aj//0YBeeBCi0lQt3WumG3MuOV6bDMKD4 X-Received: by 2002:a17:902:ef49:b0:189:66dc:4af8 with SMTP id e9-20020a170902ef4900b0018966dc4af8mr47232941plx.148.1670212708215; Sun, 04 Dec 2022 19:58:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670212708; cv=none; d=google.com; s=arc-20160816; b=ntOPZ7sDgK7jJtSYRhUg9M4fk1/1NvLtG+UBWL4UEZYY5BKEbyKST37BUxEE0yg0T1 hn6OQr2JSId/C8yNg8wExjwxc2OGfEQ/p6y3EFD1IE1aw0zk2MVvOqydXCJVor+i8exB 6FiZaKLDLRzzFLwC/F8414opuqoLR9gSZdu25aq5ze+gq10EUwYVXWIHBaF9FsYa+0lg WJqlyoiPE5LQP+Mhxo/MayO5pKmzSY8zJH7diC/9I0LeMIs9civgUmDFnVPLpalmN5/+ RnFWGcjaD44mbHiEPLWzKlKqA+l0XWFHUoPUpy9GzaNGbdSAtw693iaMa927TGwADuvJ fT6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=HBcVAkcsysCOe2rGkywRwukzu6N+g3Noa1gr9Vpfx+g=; b=fRFOuUXWspcXj17LcQeRJ19slUQ5tLLvIfpPTsqCl6Qy5akWUrOoP7+WP7H0wyK5s2 yPZjASQmwzl8ZLh+Vxla7gIcUzO8m459ZQ6D5KXed+rDE0dD/uTT84rzG1SqGMbSITTa Xz5rBK/IIQWeVO3xyPsxxI3nwMDapFxpCyGM+fdcQ8caBZZzqUlABT1QAjBpynEg2bGs 7+4I1yNpO6OC2wnFuwX5xrWbxi4ckziaQ/iobrE7Vt0hlqQbmbD47F18aj7jhWBxQvcj Kb35hQ7U8rNjUqkcE+V5e3dtSbNGb+3X/IREYbwvKZDeBtb/zXIBA9p6rsBfUMAlZ1i0 zlQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l189-20020a6388c6000000b00470422252c7si14022304pgd.122.2022.12.04.19.58.15; Sun, 04 Dec 2022 19:58:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231433AbiLED6E (ORCPT + 99 others); Sun, 4 Dec 2022 22:58:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230307AbiLED6B (ORCPT ); Sun, 4 Dec 2022 22:58:01 -0500 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94A99FCD3; Sun, 4 Dec 2022 19:57:58 -0800 (PST) Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4NQVBS4RdJz4f3rpv; Mon, 5 Dec 2022 11:57:52 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP1 (Coremail) with SMTP id cCh0CgDXfq1CbI1jRaRVBg--.57323S2; Mon, 05 Dec 2022 11:57:55 +0800 (CST) From: Kemeng Shi To: tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, shikemeng@huawei.com, linfeilong@huawei.com, liuzhiqiang26@huawei.com Subject: [PATCH v3 0/9] A few bugfix and cleanup patches for blk-throttle Date: Mon, 5 Dec 2022 19:57:00 +0800 Message-Id: <20221205115709.251489-1-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 X-CM-TRANSID: cCh0CgDXfq1CbI1jRaRVBg--.57323S2 X-Coremail-Antispam: 1UD129KBjvJXoW7WrWkKr13Gr4kCrykJrW7XFb_yoW8KFyxpr WfZr1rGr4UXrnrGr1Sk3WavayrtaykJw4aqwnF9rZ3JF1vk34kKr129F18Zry7uFZ2ka1v vr42yr97GF1DZ37anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkYb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M2 8lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_ tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_Gc CE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxI r21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87 Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l42xK82IY c2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s 026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF 0xvE2Ix0cI8IcVAFwI0_Gr0_Xr1lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0x vE42xK8VAvwI8IcIk0rVW3JVWrJr1lIxAIcVC2z280aVAFwI0_Gr0_Cr1lIxAIcVC2z280 aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU01mh7UUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751344960810065200?= X-GMAIL-MSGID: =?utf-8?q?1751344960810065200?= Hi, this series contain a few patches to fix problem when on the default hierarchy, corret comment and so on. More details can be found in respective changelogs. Thanks. --- V2->V3: -Thanks for the review and advice from Tejun. Now all patches are acked by Tejun. -remove quotes around parent in corrected comment in patch "blk-throttle: correct stale comment in throtl_pd_init" -improve log message and rename throtl_tg_reach_low_limit to throtl_low_limit_reached. -drop patch "blk-throttle: avoid dead code in throtl_hierarchy_can_upgrade" --- V1->V2: -Thanks for the review and advice from Tejun. The corrected comment of "blk-throttle: correct stale comment in throtl_pd_init" and the solution of "blk-throttle: Fix that bps of child could exceed bps limited in parent" are from reply of Tejun. -Collect Ack from Tejun. -Fix the compile problem when CONFIG_BLK_DEV_THROTTLING_LOW is set. -Drop "blk-throttle: Limit whole system if root group is configured when on the default hierarchy", "blk-throttle: remove unnecessary check for validation of limit index" and "blk-throttle: remove unused variable td in tg_update_has_rules" -Add "blk-throttle: correct stale comment in throtl_pd_init" and "blk-throttle: avoid dead code in throtl_hierarchy_can_upgrade" -Use solution that set the BIO_BPS_THROTTLED flag only when the bio traversed the entire tree to fix that bps of child could exceed bps limited in parent in patch 2/10. -Improve the description and comment of most commits. --- Kemeng Shi (9): blk-throttle: correct stale comment in throtl_pd_init blk-throttle: Fix that bps of child could exceed bps limited in parent blk-throttle: ignore cgroup without io queued in blk_throtl_cancel_bios blk-throttle: correct calculation of wait time in tg_may_dispatch blk-throttle: simpfy low limit reached check in throtl_tg_can_upgrade blk-throttle: fix typo in comment of throtl_adjusted_limit blk-throttle: remove incorrect comment for tg_last_low_overflow_time blk-throttle: remove repeat check of elapsed time from last upgrade in throtl_hierarchy_can_downgrade blk-throttle: Use more siutable time_after check for update of slice_start block/blk-throttle.c | 102 +++++++++++++++++++++++-------------------- 1 file changed, 55 insertions(+), 47 deletions(-)