mbox series

[v6,0/5] media: i2c: imx334: support lower bandwidth mode

Message ID 20221205051937.3897001-1-shravan.chippa@microchip.com
Headers
Series media: i2c: imx334: support lower bandwidth mode |

Message

shravan chippa Dec. 5, 2022, 5:19 a.m. UTC 
  From: Shravan Chippa <shravan.chippa@microchip.com>

Hi

This patch series is for imx334 sensor driver support for lower bandwidth

Some platforms may not be capable of supporting the bandwidth
required for 12 bit or 3840x2160@60 resolutions.

Add support for dynamically selecting 10 bit and 1920x1080@30
resolutions while leaving the existing configuration as default

V5 -> V6
-Drop the dt-binding patch
-Optimize the code to avoid duplicating the lines
-Added proper mutex while imx334_mbus_codes array
-Modified Function __v4l2_ctrl_modify_range arguments as per the review commants
-Added hblank dummy set ctrl
-Removed Redundant comment
-corrected code alignment 
-All commit msgs are re-written

V4 -> V5
-Added 5 more patchs as per the review comments witch has below updates
-Updated 1782000000Mbps link frequency for 3840x2160@60 as per the mode
values
-Updated 1782000000Mbps link frequency in dt-bindings also
-Updated 3840x2160@60 mode array with default(reset) values

-Updated hblank __v4l2_ctrl_s_ctrl() to __v4l2_ctrl_modify_range()
Suggested-by: Jacopo Mondi <jacopo@jmondi.org>

-Current mode update only when we try to set V4L2_SUBDEV_FORMAT_ACTIVE
-Added link frequency (891000000Mbps) and pixel rate (74250000) to
1920x1080@30 mode
Suggested-by: Sakari Ailus <sakari.ailus@iki.fi>

-Updated commit message

V3 -> V4
- Make the 12 bit and 3840x2160 as default
- Set bus code SRGGB12 if set format fails

V2 -> V3
- Fixed the warning reported by kernel test robot

V1 -> V2
- Addressed the review comment given by Jacopo Mondi,
  Which has bug in imx334_enum_frame_size() loop function,
- Renamed array codes[] to imx334_mbus_codes[]


Shravan Chippa (5):
  media: i2c: imx334: modify link frequency as for the configureation
  media: i2c: imx334: replace __v4l2_ctrl_s_ctrl to
    __v4l2_ctrl_modify_range
  media: i2c: imx334: add missing reset values for mode 3840x2160_regs[]
  media: i2c: imx334: support lower bandwidth mode
  media: i2c: imx334: update pixel and link frequency

 drivers/media/i2c/imx334.c | 338 ++++++++++++++++++++++++++++++++++---
 1 file changed, 310 insertions(+), 28 deletions(-)

Comments

shravan kumar Dec. 12, 2022, 11:31 a.m. UTC | #1 
A gentle ping!
In the meanwhile the kernel test robot also reported a warning.
"drivers/media/i2c/imx334.c:767:15: warning: unused variable 'i' ", I
will fix this warning.


On Mon, Dec 5, 2022 at 10:53 AM shravan kumar
<shravan.chippa@microchip.com> wrote:
>
> From: Shravan Chippa <shravan.chippa@microchip.com>
>
> Hi
>
> This patch series is for imx334 sensor driver support for lower bandwidth
>
> Some platforms may not be capable of supporting the bandwidth
> required for 12 bit or 3840x2160@60 resolutions.
>
> Add support for dynamically selecting 10 bit and 1920x1080@30
> resolutions while leaving the existing configuration as default
>
> V5 -> V6
> -Drop the dt-binding patch
> -Optimize the code to avoid duplicating the lines
> -Added proper mutex while imx334_mbus_codes array
> -Modified Function __v4l2_ctrl_modify_range arguments as per the review commants
> -Added hblank dummy set ctrl
> -Removed Redundant comment
> -corrected code alignment
> -All commit msgs are re-written
>
> V4 -> V5
> -Added 5 more patchs as per the review comments witch has below updates
> -Updated 1782000000Mbps link frequency for 3840x2160@60 as per the mode
> values
> -Updated 1782000000Mbps link frequency in dt-bindings also
> -Updated 3840x2160@60 mode array with default(reset) values
>
> -Updated hblank __v4l2_ctrl_s_ctrl() to __v4l2_ctrl_modify_range()
> Suggested-by: Jacopo Mondi <jacopo@jmondi.org>
>
> -Current mode update only when we try to set V4L2_SUBDEV_FORMAT_ACTIVE
> -Added link frequency (891000000Mbps) and pixel rate (74250000) to
> 1920x1080@30 mode
> Suggested-by: Sakari Ailus <sakari.ailus@iki.fi>
>
> -Updated commit message
>
> V3 -> V4
> - Make the 12 bit and 3840x2160 as default
> - Set bus code SRGGB12 if set format fails
>
> V2 -> V3
> - Fixed the warning reported by kernel test robot
>
> V1 -> V2
> - Addressed the review comment given by Jacopo Mondi,
>   Which has bug in imx334_enum_frame_size() loop function,
> - Renamed array codes[] to imx334_mbus_codes[]
>
>
> Shravan Chippa (5):
>   media: i2c: imx334: modify link frequency as for the configureation
>   media: i2c: imx334: replace __v4l2_ctrl_s_ctrl to
>     __v4l2_ctrl_modify_range
>   media: i2c: imx334: add missing reset values for mode 3840x2160_regs[]
>   media: i2c: imx334: support lower bandwidth mode
>   media: i2c: imx334: update pixel and link frequency
>
>  drivers/media/i2c/imx334.c | 338 ++++++++++++++++++++++++++++++++++---
>  1 file changed, 310 insertions(+), 28 deletions(-)
>
> --
> 2.34.1
>