From patchwork Tue Nov 29 19:17:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Cercueil X-Patchwork-Id: 2387 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp523184wrr; Tue, 29 Nov 2022 11:18:39 -0800 (PST) X-Google-Smtp-Source: AA0mqf4LtcKFWuok2jdVcKzYbxaeCxcqj8+CHzjwfP48vQ8RKvsqaLigzKvjHkUEfnRbx4W+R0Ko X-Received: by 2002:a17:90a:dd82:b0:212:fdb1:720b with SMTP id l2-20020a17090add8200b00212fdb1720bmr67616946pjv.66.1669749518967; Tue, 29 Nov 2022 11:18:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669749518; cv=none; d=google.com; s=arc-20160816; b=G73+sT8LK5/v2xj/SO4hmpI8sUjf/gYWUOuLoF+pi1+gGhK+mhchYd2mVBPrfSEF84 oyoLPON7XW5PoEOc1ZjtRLBnCy70DZSKEszXYdv00I23SOLmF7wEa6Z8qcEOnEE3P58p F45MjI4Mn2oCXp9UmdR9tgLj3OJk+yTbmqv76w0Chzqx5kEUzvaSCCsAYOQwJGKA8cAK 1NocSiJAvDZKbvFoMwJj0pGrLw7sEtLAsLKfYkyc98wYGRooFrudnFtdv9TS0GSa2U6d RwEPVavi3C68UXqpg5hslJh56yQEMoLmVqZPxMDHFWx/z9VOJiRALIL9umDGwjWrCGC0 ANPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=x4ACPi/mFEo8bcgZDh23yUYuSMk3MfBQvJRzo/w5mRk=; b=PEGMwDti4nu4jYLI0mzkEG7CXZRTpvkgLfEaPOmlnjgESp3tEQD/1f/M8t/YcA8eeB 33hHsjIQMqAMP0VzBSG9+8G+LYVFB/VFeg5BJ7jj2aioJcBhcrSrLxvvjptBa+VLkeUj PL/WFF/KE5r+8+VcaHUVeLfeA0RQLl66HX8DMl4LGkjwrREvy7dop6ZFxjugf6eP0iMr NGwYBxV+kDGpSNlROzR+vX5WnSMKNRXsvc4WTtUqJEG8mEPfQ3sOYchkpm45r/r+E2hL cpH5M9Yca10KYfG0EW0hBu5aqWzdmn+LnkHCq8twstIbSoSB8L6ytzjGGgaozyuuZIdq CzRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=j4W68pBV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j6-20020a625506000000b0054307ac90f1si14837994pfb.319.2022.11.29.11.18.25; Tue, 29 Nov 2022 11:18:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=j4W68pBV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236198AbiK2TRx (ORCPT + 99 others); Tue, 29 Nov 2022 14:17:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235356AbiK2TRw (ORCPT ); Tue, 29 Nov 2022 14:17:52 -0500 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7203515824 for ; Tue, 29 Nov 2022 11:17:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1669749468; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=x4ACPi/mFEo8bcgZDh23yUYuSMk3MfBQvJRzo/w5mRk=; b=j4W68pBViRgv2A41FrCHCYDXpDP6TsDv5bNM8uiOzylCIHMKLUGSV7f7LF4Dj1Msuhjoo/ vVjS3JHL7KxEoq76+/3f22S1w2Gnxpn3ARW53F6Cjgc27wzwHcJ38ogiIVjzZiJ6kUuDVp OE4+MhuB/k4M32ZMrlpK6wjYYsdH3eM= From: Paul Cercueil To: David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Paul Cercueil Subject: [PATCH v2 00/26] drm: Get rid of #ifdef CONFIG_PM* guards Date: Tue, 29 Nov 2022 19:17:07 +0000 Message-Id: <20221129191733.137897-1-paul@crapouillou.net> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750859271913931170?= X-GMAIL-MSGID: =?utf-8?q?1750859271913931170?= Hi, This patchset updates the DRM drivers to use the new set of PM-related macros introduced recently. The point of these macros is to allow the PM functions to be automatically dropped by the compiler when CONFIG_PM or CONFIG_SUSPEND is disabled, without having to use #ifdef guards. This has the advantages of always compiling these functions in, independently of any Kconfig option. Thanks to that, bugs and other regressions are subsequently easier to catch. Checkpatch complains about patch [11/26], as I replaced a "#if defined(IS_NOT_BROKEN)" to a "if (IS_ENABLED(IS_NOT_BROKEN))". I don't really know how to make it better so I left it like that. Compile-tested with allyesconfig, with the following cases: - CONFIG_PM=y CONFIG_PM_SLEEP=y - CONFIG_PM=y CONFIG_PM_SLEEP=n - CONFIG_PM=n V2: - Patch [1/26] now adds a macro named DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS() instead of exporting a dev_pm_ops instance. - Patches [3/26] to [7/26] are updated accordingly. - I updated the description of patches [12/26], [20/26] and [23/26]. The code itself did not change. Note that I can commit to drm-misc-next but not drm-next, so I cannot apply this patchset myself when it's all properly tagged. Cheers, -Paul Paul Cercueil (26): drm: modeset-helper: Add DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS macro drm: bochs: Define and use generic PM ops drm: imx: Define and use generic PM ops drm: rockchip: Define and use generic PM ops drm: tegra: Define and use generic PM ops drm: sun4i: Define and use generic PM ops drm: mxsfb: Define and use generic PM ops drm: atmel-hlcdc: Remove #ifdef guards for PM related functions drm: exynos: Remove #ifdef guards for PM related functions drm: imx/dcss: Remove #ifdef guards for PM related functions drm: bridge/dw-hdmi: Remove #ifdef guards for PM related functions drm: etnaviv: Remove #ifdef guards for PM related functions drm: fsl-dcu: Remove #ifdef guards for PM related functions drm: mediatek: Remove #ifdef guards for PM related functions drm: omap: Remove #ifdef guards for PM related functions drm: panfrost: Remove #ifdef guards for PM related functions drm: rcar-du: Remove #ifdef guards for PM related functions drm: rockchip: Remove #ifdef guards for PM related functions drm: shmobile: Remove #ifdef guards for PM related functions drm: tegra: Remove #ifdef guards for PM related functions drm: tilcdc: Remove #ifdef guards for PM related functions drm: vboxvideo: Remove #ifdef guards for PM related functions drm: vc4: Remove #ifdef guards for PM related functions drm: gm12u320: Remove #ifdef guards for PM related functions drm: tidss: Remove #ifdef guards for PM related functions drm/i915/gt: Remove #ifdef guards for PM related functions drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 9 ++--- .../drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 17 ++++----- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 30 ++++++--------- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 13 ++----- drivers/gpu/drm/exynos/exynos7_drm_decon.c | 12 ++---- drivers/gpu/drm/exynos/exynos_dp.c | 11 ++---- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 11 ++---- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 11 ++---- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 10 ++--- drivers/gpu/drm/exynos/exynos_drm_mic.c | 11 ++---- drivers/gpu/drm/exynos/exynos_drm_rotator.c | 12 ++---- drivers/gpu/drm/exynos/exynos_drm_scaler.c | 12 ++---- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 9 ++--- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 8 +--- drivers/gpu/drm/imx/dcss/dcss-dev.c | 17 +++++---- drivers/gpu/drm/imx/dcss/dcss-dev.h | 7 ++-- drivers/gpu/drm/imx/dcss/dcss-drv.c | 8 +--- drivers/gpu/drm/imx/imx-drm-core.c | 23 ++--------- drivers/gpu/drm/mediatek/mtk_dp.c | 6 +-- drivers/gpu/drm/mediatek/mtk_hdmi.c | 9 ++--- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 22 +---------- drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 6 +-- drivers/gpu/drm/omapdrm/omap_drv.c | 7 ++-- drivers/gpu/drm/omapdrm/omap_gem.c | 5 ++- drivers/gpu/drm/omapdrm/omap_gem.h | 2 - drivers/gpu/drm/panfrost/panfrost_device.c | 10 +++-- drivers/gpu/drm/panfrost/panfrost_device.h | 4 +- drivers/gpu/drm/panfrost/panfrost_drv.c | 7 +--- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 9 ++--- .../gpu/drm/rockchip/analogix_dp-rockchip.c | 6 +-- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 25 ++---------- drivers/gpu/drm/shmobile/shmob_drm_drv.c | 9 ++--- drivers/gpu/drm/sun4i/sun4i_drv.c | 26 ++----------- drivers/gpu/drm/tegra/dpaux.c | 6 +-- drivers/gpu/drm/tegra/drm.c | 23 ++--------- drivers/gpu/drm/tidss/tidss_drv.c | 29 +++++++------- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 9 ++--- drivers/gpu/drm/tiny/bochs.c | 29 ++------------ drivers/gpu/drm/tiny/gm12u320.c | 15 ++++---- drivers/gpu/drm/vboxvideo/vbox_drv.c | 6 +-- drivers/gpu/drm/vc4/vc4_v3d.c | 6 +-- include/drm/drm_modeset_helper.h | 38 +++++++++++++++++++ 42 files changed, 184 insertions(+), 361 deletions(-)