Message ID | 20221129191023.936738-1-kan.liang@linux.intel.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp521305wrr; Tue, 29 Nov 2022 11:14:31 -0800 (PST) X-Google-Smtp-Source: AA0mqf4pwwzNVa0+gpJD3f1UfdDR50U9d/VuJ+Ea0TRDfSgIvj1jDLpocw+uFFcTWz34uPWbrfod X-Received: by 2002:a62:f211:0:b0:574:7931:98a2 with SMTP id m17-20020a62f211000000b00574793198a2mr30011300pfh.17.1669749271502; Tue, 29 Nov 2022 11:14:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669749271; cv=none; d=google.com; s=arc-20160816; b=qdF1xedJ7GXLIq4ctNt0IAwkQhUR64yI3yixohP9I20y41uwZioLyjRVZhtFbDtuUf oph/88OvBoDYmjUrrkUfJWrOt2m/yWvqjDD4O5vQryBN8ylAaKLXV++QEyDwU40FIFtr xh0dNEDUuU57rtTMVoWA+RA94STMnkffFqNph8RD7MdpefGDnYs3ImyajKgRq3jK367t 1yFH6q3AxdEVuik0xWR91B0XjOVDq7HEOF04Dqg5Y5vJaK5bPm3yekbOTsaAIliAzXHn hkSp87JKTpOe5V53B+WHE+ewa5Kbf+/5RBlzCg7e4IOjG8oX/rk/nTlpg9N6hdIcrBHr b5Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=VaU7gUH8prwgX97NtYi17OdI/y7serxbcbwpUf80Tn8=; b=Gfwf0QiCeylJSVQm8eJoE09zFU/bNkGwlxkLpcP43YT1STYc2IEgHdKqxH+au7Gbvi uA/A1fFbCIGHte1IHWrHFDD9VlxKuyRQyEKJ15gqZyvMUtFuqmMqIu5ThlPhz2lE/qdO CJer4IpGrvaJMzV+rz+sWuhUpDqaZHPk+OHYM4g7Mtp3FIRTiJOGhxG/s7cEcwOSlw3E jtrxAkksWQz1lFr2y6MDl2BtkbsBAdWuC7xTOHSJa86cyghtuiNebQ80Al39cYdeVjg0 HwDad3lXBw72LN4tecA98dnwgR9X9URgqsvgXnPx3Lkz7RGkoRlMEW2EdApTPci+4N7M T88A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=nMh3EGNX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v20-20020a631514000000b004772b3d0bafsi15965970pgl.354.2022.11.29.11.14.18; Tue, 29 Nov 2022 11:14:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=nMh3EGNX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236558AbiK2TKq (ORCPT <rfc822;rbbytesnap@gmail.com> + 99 others); Tue, 29 Nov 2022 14:10:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236306AbiK2TKp (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 29 Nov 2022 14:10:45 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 744C730556 for <linux-kernel@vger.kernel.org>; Tue, 29 Nov 2022 11:10:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669749044; x=1701285044; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=CRC1QpMRvg+SgNUKD7+JhmJV8K8WczePzSImvqnWffY=; b=nMh3EGNX/o1z6IUKF1Pep7qL98kqFlMnXp+S2ahYYPPc2ReT8PnDgR1x AFo+GQRTaLDBLJtfIMFyfORF3+NmBuFHSOYLnvml6D1t957zJEPwESfXc FNK3tmANC9iJTgkIWhjR2Zh/nOhL+RpZxLtDOtJQ+MjC6DE62gp2Pxtus EDk4c950p+WetYMH8v100qxzTHkk/obJtCgII0EFtDr1wASRua+DPFCN3 ck2e1PE2mzqVv16OrLliRBpJrcFqDI65VNXTRAMPPBMKWvpgbynKXfzs2 ovKW3xfzeNZBhqvfXYiu/sIGISNp/2s4rl4ho4lNCdBg752Oa06L8fpAw Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="379490757" X-IronPort-AV: E=Sophos;i="5.96,204,1665471600"; d="scan'208";a="379490757" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2022 11:10:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="749991987" X-IronPort-AV: E=Sophos;i="5.96,204,1665471600"; d="scan'208";a="749991987" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by fmsmga002.fm.intel.com with ESMTP; 29 Nov 2022 11:10:32 -0800 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org Cc: steve.wahl@hpe.com, alexander.antonov@linux.intel.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, Kan Liang <kan.liang@linux.intel.com> Subject: [PATCH 0/5] Fix UPI uncore issue on SPR Date: Tue, 29 Nov 2022 11:10:18 -0800 Message-Id: <20221129191023.936738-1-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750859012063909339?= X-GMAIL-MSGID: =?utf-8?q?1750859012063909339?= |
Series |
Fix UPI uncore issue on SPR
|
|
Message
Liang, Kan
Nov. 29, 2022, 7:10 p.m. UTC
From: Kan Liang <kan.liang@linux.intel.com>
The discovery table of UPI on SPR MCC is broken. The patch series is
to mitigate the issue by providing a hardcode pre-defined table.
The broken discovery table can trigger a kernel warning message, which
is overkilled. The patch series also refine the error handling code.
Kan Liang (5):
perf/x86/uncore: Factor out uncore_device_to_die()
perf/x86/uncore: Fix potential NULL pointer in uncore_get_alias_name
perf/x86/uncore: Ignore broken units in discovery table
perf/x86/uncore: Add a quirk for UPI on SPR
perf/x86/uncore: Don't WARN_ON_ONCE() for a broken discovery table
arch/x86/events/intel/uncore.c | 34 ++++-
arch/x86/events/intel/uncore.h | 4 +
arch/x86/events/intel/uncore_discovery.c | 60 ++++++---
arch/x86/events/intel/uncore_discovery.h | 14 +-
arch/x86/events/intel/uncore_snbep.c | 158 ++++++++++++++++++-----
5 files changed, 210 insertions(+), 60 deletions(-)
Comments
Hi Peter, Happy new year! Gentle Ping. Please let me know if you have any comments on the patch set. Thanks, Kan On 2022-11-29 2:10 p.m., kan.liang@linux.intel.com wrote: > From: Kan Liang <kan.liang@linux.intel.com> > > The discovery table of UPI on SPR MCC is broken. The patch series is > to mitigate the issue by providing a hardcode pre-defined table. > > The broken discovery table can trigger a kernel warning message, which > is overkilled. The patch series also refine the error handling code. > > Kan Liang (5): > perf/x86/uncore: Factor out uncore_device_to_die() > perf/x86/uncore: Fix potential NULL pointer in uncore_get_alias_name > perf/x86/uncore: Ignore broken units in discovery table > perf/x86/uncore: Add a quirk for UPI on SPR > perf/x86/uncore: Don't WARN_ON_ONCE() for a broken discovery table > > arch/x86/events/intel/uncore.c | 34 ++++- > arch/x86/events/intel/uncore.h | 4 + > arch/x86/events/intel/uncore_discovery.c | 60 ++++++--- > arch/x86/events/intel/uncore_discovery.h | 14 +- > arch/x86/events/intel/uncore_snbep.c | 158 ++++++++++++++++++----- > 5 files changed, 210 insertions(+), 60 deletions(-) >