From patchwork Tue Nov 29 11:10:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Newman X-Patchwork-Id: 2360 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp275094wrr; Tue, 29 Nov 2022 03:25:05 -0800 (PST) X-Google-Smtp-Source: AA0mqf7l4DDtB4aokhBSD0g/s3RXoUuOoRHVFSRHKWe9LZsyFsmtNsV9HDvqYPXfEdGWZxxQvzxT X-Received: by 2002:a17:906:a0d7:b0:7b2:7af0:c231 with SMTP id bh23-20020a170906a0d700b007b27af0c231mr6082525ejb.240.1669721105243; Tue, 29 Nov 2022 03:25:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669721105; cv=none; d=google.com; s=arc-20160816; b=qoZlBwZfUzAQMQEYQ6y6yuWH7QzlAtnyhJ5GvCdxp95Jxu218y2/TIN4vurXNWOMb7 okDj4dKZ1/vcqbVGLFx0pghSasaWmtON1WnwOCrO9J6uurbS5kuk339jNTgsLnI6eVQL Nr7hhD69Mhp9ogIRk1um+zT1CXH3CMRvXuN9GVcJz8SNys5cgJ0DjSaMRmQdrGGx7/T0 V7P/GIW3RpDEkRrLpChaiARJi9jXRZypiF4heHX00/ltH/tiwGqlDtj6+7oezD5Qi6/v fLyNgDXRIrjPJ+kuoO8H6c+YyeLKprunSEebxI2Gv5KZgTuXYgDMka2ppxSDl2Hd0i3e OWHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:mime-version:date :dkim-signature; bh=C35WM+rFOww9oANmi2XKIgD3lZZHmk9pCOYrcDGbk7A=; b=qKdqRjkzYwTL/Ih3X01QfcUHY5wTvfijMDVpEjWks6S2roIM1uaWhCRcb6yOsETqQa rWO1k9WuO71PNui21jq64flG+KIovQjOT1EstTl+k/3AbCeemrgVmhSR1TdSMTCA7f6Z iAW9NQqJHe5gf9qOYhCU6gtSVjalUBSQUhV7xW0wdt//+ldremWEs0D6iGQ5AK7NutKY 8tsMMLpELUDB8dbVUmUzSnFrCHmc9+9shV2Qq9f8vmPmuQ4ZlFzQzCIm3NUrF9/iyR8q k4vts3bZ8d+7QbkqwN75Jl2teYgHNotLE6rCw9thdEfN6nR1oCxYO9hJZFmh85y7BFpJ /Rqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=sMaUlF+m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o14-20020a170906974e00b007ba9c086b05si15243777ejy.497.2022.11.29.03.24.39; Tue, 29 Nov 2022 03:25:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=sMaUlF+m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232924AbiK2LLS (ORCPT + 99 others); Tue, 29 Nov 2022 06:11:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232884AbiK2LLK (ORCPT ); Tue, 29 Nov 2022 06:11:10 -0500 Received: from mail-wm1-x349.google.com (mail-wm1-x349.google.com [IPv6:2a00:1450:4864:20::349]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3CBB265F for ; Tue, 29 Nov 2022 03:11:03 -0800 (PST) Received: by mail-wm1-x349.google.com with SMTP id c10-20020a7bc84a000000b003cf81c2d3efso4589040wml.7 for ; Tue, 29 Nov 2022 03:11:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=C35WM+rFOww9oANmi2XKIgD3lZZHmk9pCOYrcDGbk7A=; b=sMaUlF+mKL0TN8tM/IH7nnj6EOZVAMDMNcq0DT6JcGOSAZaxnp5zeOKmanWdPq+0OO uA4KllZNoS8cHkAd01MItYNXSfwQGrPUp62pGTiwX/UvECX50Ol7dtOk07Em3thbzAq9 z7aKGINXnQyT90Jpl1HyejJ5oZuOVnFHE3wPAeXQfXf4U1TUmtJQHKblwDr3UxwzhV/G IZwSe585LTE0TscrmaMS0LBhYk6OkOh7DmYuOWYy86Lznsc/W2cAHOy6ydQWb+vcz+QL t4IIctSup2WnNTryME2HywbK+ezh5dvN5PIGlSzAMWZc80OzSQHm1QdTROKqCcRTnFFG 0ADg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=C35WM+rFOww9oANmi2XKIgD3lZZHmk9pCOYrcDGbk7A=; b=A86ua2WMC55O+Qe1oGVqfk+JIQ4hHhg1A8F7NiFn2iVmoJFzezoWo8+eMSn9GWLZm6 Pm52gRE0sCK3ddwiNnXZh865cuwbKM3xqvVT2RxD81VdFcI5LKlWuVr+Fc/Z1+leH93H i5x07pM7Di7Z8zKfclhm8aPMKuIj0NcsOb5NrraJR1Hv2T2oGa/9wE6WbGZNmQ/qyNkX AtrGG1zdVESS2HfXL+uSt2K/8YFL/CaCYQvR+heceTgkq1doZN1Zjjuyjq38OQJ5BbC9 D1Q8j/qAERdsXKYlYMtsO+cvc6mRX2VjHQWVm+1tGy+4M86aTVL2C5YmQf3kouUtmV/+ slew== X-Gm-Message-State: ANoB5pmrWTK2KQYCZECHm3lzh9WrWBeTyMirlHZkAhIdu79F3RVtXPc7 CyXYnyd9S17baO6BU09rhOd6PEHzKVCj5R/unw== X-Received: from peternewman10.zrh.corp.google.com ([2a00:79e0:9d:6:e398:2261:c909:b359]) (user=peternewman job=sendgmr) by 2002:a05:6000:1d92:b0:241:6e0a:bfe6 with SMTP id bk18-20020a0560001d9200b002416e0abfe6mr26088628wrb.34.1669720262242; Tue, 29 Nov 2022 03:11:02 -0800 (PST) Date: Tue, 29 Nov 2022 12:10:53 +0100 Mime-Version: 1.0 X-Mailer: git-send-email 2.38.1.584.g0f3c55d4c2-goog Message-ID: <20221129111055.953833-1-peternewman@google.com> Subject: [PATCH v4 0/2] x86/resctrl: Fix task CLOSID update race From: Peter Newman To: reinette.chatre@intel.com, fenghua.yu@intel.com Cc: bp@alien8.de, derkling@google.com, eranian@google.com, hpa@zytor.com, james.morse@arm.com, jannh@google.com, kpsingh@google.com, linux-kernel@vger.kernel.org, mingo@redhat.com, tglx@linutronix.de, x86@kernel.org, Peter Newman X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750829477787570254?= X-GMAIL-MSGID: =?utf-8?q?1750829477787570254?= Hi Reinette, Fenghua, I've fixed the wording in changelogs and code comments throughout and clarified the explanations as Reinette had requested. The patch series addresses the IPI race we discussed in the container move RFD thread[1]. The changelog in the patches should also provide a good description. Updates in v4: - Reorder the patches so that justification for sending more IPIs can reference the patch fixing __rdtgroup_move_task(). - Correct tense of wording used in changelog and comments Updates in v3: - Split the handling of multi-task and single-task operations into separate patches, now that they're handled differently. - Clarify justification in the commit message, including moving some of it out of inline code comment. Updates in v2: - Following Reinette's suggestion: use task_call_func() for single task, IPI broadcast for group movements. - Rebased to v6.1-rc4 v1: https://lore.kernel.org/lkml/20221103141641.3055981-1-peternewman@google.com/ v2: https://lore.kernel.org/lkml/20221110135346.2209839-1-peternewman@google.com/ v3: https://lore.kernel.org/lkml/20221115141953.816851-1-peternewman@google.com/ Thanks! -Peter [1] https://lore.kernel.org/all/CALPaoCg2-9ARbK+MEgdvdcjJtSy_2H6YeRkLrT97zgy8Aro3Vg@mail.gmail.com/ Peter Newman (2): x86/resctrl: Update task closid/rmid with task_call_func() x86/resctrl: IPI all online CPUs for group updates arch/x86/kernel/cpu/resctrl/rdtgroup.c | 130 ++++++++++++------------- 1 file changed, 60 insertions(+), 70 deletions(-) base-commit: eb7081409f94a9a8608593d0fb63a1aa3d6f95d8 --- 2.38.1.584.g0f3c55d4c2-goog