From patchwork Tue Nov 29 07:11:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 2351 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp178106wrr; Mon, 28 Nov 2022 23:14:22 -0800 (PST) X-Google-Smtp-Source: AA0mqf6XWBdmDgzdDDaaTOwKT/S/5gLF9I56Cp2JOZuiU2u5e/NdVjU+l88L2kS7tbZDCx1h9b2u X-Received: by 2002:a63:f00a:0:b0:460:ea43:93c6 with SMTP id k10-20020a63f00a000000b00460ea4393c6mr30883735pgh.173.1669706062111; Mon, 28 Nov 2022 23:14:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669706062; cv=none; d=google.com; s=arc-20160816; b=D341C8P+df880VEfg+xS75Z1Vp0hBLMwIgvq6FQsfgBWOQOtDPAtRlBSHzpXmhfgPh 2/sPODmPm/aScwA0AK2mSd3z6DTUaQHnGA3TsYwsuzRxtXnRrQ24jbvGCY0OHB7fULWj ymOFu49Ly6ercKlw7zLIv2RKoABdjvcVnGM5Fvde9BZybp9nMp/axmr9zJIG2cikW8gJ wkQxBcB//jF8qsOAAeAhpGGC+tqYLbrGogViDVoiEFCCnIZMma7kROnPzFbAFFc/8fCn j8EzNf8e/SCQZ3hMl3gYwbDJaxguQo72IxaCfbhFqfFUeWQZOCXP7H1VG19dyH7TUJjh oa3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=1BYbRDXPGcQcPqTkrRbe5deFveMBdsfHu4xmu6DCjgI=; b=a8dnMfddDjNuiobyBhZvih8/QZtiEa8Rg0jZQNUF82NYQtF0IzzYPdus3s0BeVOcph rxRp95A6ExabFWQ070l9Ju4GmWCNRZZrkd/T9o4Ul/+YWpYa0d5qG3HUCxhzex2ykUSY 3nDvhJFYnaEbweNsTUA1U5rIGiDe9bnuhHaqs11WjxJQLfbstIC8vxFB+E4unLFRO7O3 obqkuB4zA9oYcmBWpdeiyrTCWHAxM+nFexgjiHWMfznOUUc+Gs9ooKB7idHwdHpoX1YB 3YyxQiCsxKbwaKFp0xf0Q3MozxVr+2/JkCtGCk1KH5AzRAVEXvZQ555EeiXvTonPqJ9y ovFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mdX4Jq7G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oj15-20020a17090b4d8f00b00218cf92fc62si1059890pjb.89.2022.11.28.23.14.09; Mon, 28 Nov 2022 23:14:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mdX4Jq7G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229705AbiK2HM5 (ORCPT + 99 others); Tue, 29 Nov 2022 02:12:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229907AbiK2HMz (ORCPT ); Tue, 29 Nov 2022 02:12:55 -0500 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D2111EAF7 for ; Mon, 28 Nov 2022 23:12:54 -0800 (PST) Received: by mail-pf1-x436.google.com with SMTP id 130so12820564pfu.8 for ; Mon, 28 Nov 2022 23:12:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1BYbRDXPGcQcPqTkrRbe5deFveMBdsfHu4xmu6DCjgI=; b=mdX4Jq7Gyk1rEVAiudR1pYpqGjGHLrK89wTJNOntjp4sXsiU4+okSAw+FpWlqCBCV1 ZRwRftH+oNnCAGs6Naumkg7aXI5oJPJMAqCuiHQoZ7vg1m2IfVI4BZZrKxrF1WkxDGji A6Kx9Na35bj7jVToM02a1ogZNGqcagtlxZgch0VxfvclH3edHEk/GSj5oL0nHq0KNOKG CLZERW3VUPDAc14NF8MOt76ZAkCC5mo4DTyK3TzhVqkO5i6gfEco2rCShOeeZAkUmk3S o5up2fwoTw8lRRy/S1oGpqPnH2XFiE8Wj+C+DfeN7Utkm+JKf4FVF5hO+COr6qp66xZg i+3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1BYbRDXPGcQcPqTkrRbe5deFveMBdsfHu4xmu6DCjgI=; b=5CJRiA2KofG8EdZdOpQcH7kUicxPkR33CVD/yiKs9h6+4tTU/2gtZjaqTgfigUStqg 65uiiN978cfc56sFDpgmYGUUibuaSJToPxJ77Spv+cHb8K8RmQvG1aAuUSzX4FvPX2HI bndg50+LJ9F9FMYTNz55TLtgCZMuhm4fax93/XMoTXxf10f0V1c/cGrJSVsGUyWWfUHT VzQyo615OXhVJR5jIRtnXwcFwifPhGV9kUdSXDwJH482AI2D9x0GzvlWhsAwKX69T2DK UzLZxGUh0X22gxsNJKuTaOIMuQpfuGj7D3CQC3hHVFaNBtkyVULTd4WVvCJtrxjRhjJF HHqA== X-Gm-Message-State: ANoB5pljMVQT/dkzzLlcCdgeACFITH3GCIMeFHajvy+eRiYT4luEWhW5 mrRgOPY0nDHNrrIfpZ1+xRHF X-Received: by 2002:a63:f845:0:b0:478:1187:b58 with SMTP id v5-20020a63f845000000b0047811870b58mr8757510pgj.43.1669705973588; Mon, 28 Nov 2022 23:12:53 -0800 (PST) Received: from localhost.localdomain ([117.248.1.95]) by smtp.gmail.com with ESMTPSA id u6-20020a170903124600b00188fc6766d6sm10009264plh.219.2022.11.28.23.12.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 23:12:52 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, bp@alien8.de, mchehab@kernel.org Cc: james.morse@arm.com, rric@kernel.org, linux-arm-msm@vger.kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, quic_saipraka@quicinc.com, Manivannan Sadhasivam Subject: [PATCH v5 0/3] Fix crash when using Qcom LLCC/EDAC drivers Date: Tue, 29 Nov 2022 12:41:58 +0530 Message-Id: <20221129071201.30024-1-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750813703818725071?= X-GMAIL-MSGID: =?utf-8?q?1750813703818725071?= Hello, This series fixes the crash seen on the Qualcomm SM8450 chipset with the LLCC/EDAC drivers. The problem was due to the Qcom EDAC driver using the fixed LLCC register offsets for detecting the LLCC errors. This seems to have worked for SoCs till SM8450. But in SM8450, the LLCC register offsets were changed. So accessing the fixed offsets causes the crash on this platform. So for fixing this issue, and also to make it work on future SoCs, let's pass the LLCC offsets from the Qcom LLCC driver based on the individual SoCs and let the EDAC driver make use of them. This series has been tested on SM8450 based dev board. Thanks, Mani Changes in v5: * Added fixes tag and CCed stable mentioning the dependency * Added a patch to fix the build error with COMPILE_TEST Changes in v4: * Dropped the patches that were already applied * Rebased on top of v6.1-rc5 Changes in v3: * Instead of using SoC specific register offset naming convention, used LLCC version based as suggested by Sai * Fixed the existing reg_offset naming convention to clearly represent the LLCC version from which the offsets were changed * Added Sai's Acked-by to MAINTAINERS patch * Added a new patch that removes an extra error no assignment Changes in v2: * Volunteered myself as a maintainer for the EDAC driver since the current maintainers have left Qualcomm and I couldn't get hold of them. Manivannan Sadhasivam (3): soc: qcom: Select REMAP_MMIO for LLCC driver EDAC/qcom: Remove extra error no assignment in qcom_llcc_core_setup() EDAC/qcom: Get rid of hardcoded register offsets drivers/edac/qcom_edac.c | 119 ++++++++++++++--------------- drivers/soc/qcom/Kconfig | 1 + include/linux/soc/qcom/llcc-qcom.h | 6 -- 3 files changed, 60 insertions(+), 66 deletions(-)