Message ID | 20221129030147.27400-1-shikemeng@huawei.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp94369wrr; Mon, 28 Nov 2022 19:03:09 -0800 (PST) X-Google-Smtp-Source: AA0mqf7eqyuENoWI5WixGthhtTRJoGEupHG016HSA+zkDAQkGJ595jMmghkCoGXRrLO/rRQep4Dj X-Received: by 2002:aa7:d68d:0:b0:46a:e912:fbcd with SMTP id d13-20020aa7d68d000000b0046ae912fbcdmr13020898edr.378.1669690989165; Mon, 28 Nov 2022 19:03:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669690989; cv=none; d=google.com; s=arc-20160816; b=tE7MdDGAvVw8+AmSEkQKf2kOADDxq/VroJZBM1ztX/H8PXw0qA1hWUihMx15fwF7W4 YuaAXR55v8EJdSfRdki6B616YncPmNYr4n/b0MOYna7B+q5++eRZRRtH0PJT7kbC+vvr 6kQ+ZbGtDCXxnX/sSJ65qu55ciy+rIhjri5MVfcFFnCcVVA8gkpP+zqNzvIV5qa5ez1n hQ91S3mKmkPlNLAPfy0d1ODY82PVuUkyCbil0xldcWVE9puSXMYwnyxdQEvJ9F9ZMWq7 eeTDHnqc56H1BijH9fMs9DesBRIfOrYhFh9cCEAIJsS8Jwe6a1cCrpCx3AECRRGp3Q6m BDSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=SgW+A8AZSdHjhPK11PLN1J0oQHonpcJUU7H2I8BJz2g=; b=mrFkvLYqlgRIQQBl9W4rbHVaiZ9ifPR57aFpMRP3Ac7ZmH/TmNNt3jkwjMpDejTVAl Waeh+cWvNowfSDhW76UE+lzM9lzmSaxUWOfvsDiFpPJQtW5BvOu36QxzPoFL8Ioly1tU zNIMrPiZ5z9eOQIm1hFk1Hh2NWzvoTd3S6EQ+EzW0BtF9G7M8DAZEJVbQrkhSyKgPxNn t/0AWfgkEWKzxH7YEHOT7fXTqLCa7G4AdWPwyNS9GmlmTU9Fo1BILbrVzKyPGqJerlS5 2VHRlUa2Zhe4MLYo2+bx0BLIDR7K4PBorrUVW563Wq99PYzierB5i2tyZLfEIU/55WpE WI/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id vr5-20020a170907a50500b0078cc4a8a956si9681617ejc.881.2022.11.28.19.02.38; Mon, 28 Nov 2022 19:03:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235358AbiK2DCL (ORCPT <rfc822;gah0developer@gmail.com> + 99 others); Mon, 28 Nov 2022 22:02:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235288AbiK2DBx (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 28 Nov 2022 22:01:53 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 816C3303F3; Mon, 28 Nov 2022 19:01:52 -0800 (PST) Received: from kwepemi500016.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NLnCq75GNzRpVS; Tue, 29 Nov 2022 11:01:11 +0800 (CST) Received: from huawei.com (10.174.178.129) by kwepemi500016.china.huawei.com (7.221.188.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 29 Nov 2022 11:01:49 +0800 From: Kemeng Shi <shikemeng@huawei.com> To: <tj@kernel.org>, <josef@toxicpanda.com>, <axboe@kernel.dk> CC: <cgroups@vger.kernel.org>, <linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <shikemeng@huawei.com> Subject: [PATCH v2 00/10] A few bugfix and cleanup patches for blk-throttle Date: Tue, 29 Nov 2022 11:01:37 +0800 Message-ID: <20221129030147.27400-1-shikemeng@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.178.129] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500016.china.huawei.com (7.221.188.220) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750797898762975349?= X-GMAIL-MSGID: =?utf-8?q?1750797898762975349?= |
Series |
A few bugfix and cleanup patches for blk-throttle
|
|
Message
Kemeng Shi
Nov. 29, 2022, 3:01 a.m. UTC
Hi, this series contain a few patches to fix problem when on the default hierarchy, corrent comment and so on. More detail can be found in respective changelogs. Thanks. --- V1->V2: -Thanks for the review and advice from Tejun. The corrected comment of "blk-throttle: correct stale comment in throtl_pd_init" and the solution of "blk-throttle: Fix that bps of child could exceed bps limited in parent" are from reply of Tejun. -Collect Ack from Tejun. -Fix the compile problem when CONFIG_BLK_DEV_THROTTLING_LOW is set. -Drop "blk-throttle: Limit whole system if root group is configured when on the default hierarchy", "blk-throttle: remove unnecessary check for validation of limit index" and "blk-throttle: remove unused variable td in tg_update_has_rules" -Add "blk-throttle: correct stale comment in throtl_pd_init" and "blk-throttle: avoid dead code in throtl_hierarchy_can_upgrade" -Use solution that set the BIO_BPS_THROTTLED flag only when the bio traversed the entire tree to fix that bps of child could exceed bps limited in parent in patch 2/10. -Improve the description and comment of most commits. --- Kemeng Shi (10): blk-throttle: correct stale comment in throtl_pd_init blk-throttle: Fix that bps of child could exceed bps limited in parent blk-throttle: ignore cgroup without io queued in blk_throtl_cancel_bios blk-throttle: correct calculation of wait time in tg_may_dispatch blk-throttle: simpfy low limit reached check in throtl_tg_can_upgrade blk-throttle: fix typo in comment of throtl_adjusted_limit blk-throttle: remove incorrect comment for tg_last_low_overflow_time blk-throttle: remove repeat check of elapsed time from last upgrade in throtl_hierarchy_can_downgrade blk-throttle: Use more siutable time_after check for update of slice_start blk-throttle: avoid dead code in throtl_hierarchy_can_upgrade block/blk-throttle.c | 104 +++++++++++++++++++++++-------------------- 1 file changed, 56 insertions(+), 48 deletions(-)