mbox series

[v2,0/2] gpiolib: don't allow user-space to crash the kernel with hot-unplugs

Message ID 20221128175214.602612-1-brgl@bgdev.pl
Headers
Series gpiolib: don't allow user-space to crash the kernel with hot-unplugs |

Message

Bartosz Golaszewski Nov. 28, 2022, 5:52 p.m. UTC 
  From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

This is a second iteration of the changes that aim at fixing the situation
in which the user-space can provoke a NULL-pointer derefence in the kernel
when a GPIO device that's in use by user-space is removed.

v1 -> v2:
- add missing gdev->chip checks in patch 1/2
- add a second patch that protects the structures that can be accessed
  by user-space calls against concurrent removal

Bartosz Golaszewski (2):
  gpiolib: cdev: fix NULL-pointer dereferences
  gpiolib: protect the GPIO device against being dropped while in use by
    user-space

 drivers/gpio/gpiolib-cdev.c | 240 +++++++++++++++++++++++++++++-------
 drivers/gpio/gpiolib.c      |   3 +
 drivers/gpio/gpiolib.h      |   5 +
 3 files changed, 205 insertions(+), 43 deletions(-)

Comments

Linus Walleij Nov. 28, 2022, 8:37 p.m. UTC | #1 
On Mon, Nov 28, 2022 at 6:52 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> This is a second iteration of the changes that aim at fixing the situation
> in which the user-space can provoke a NULL-pointer derefence in the kernel
> when a GPIO device that's in use by user-space is removed.
>
> v1 -> v2:
> - add missing gdev->chip checks in patch 1/2
> - add a second patch that protects the structures that can be accessed
>   by user-space calls against concurrent removal

Thanks for looking into this.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
for the series.

Yours,
Linus Walleij