mbox series

[V3,0/2] PCI/DOE: Remove asynchronous task support

Message ID 20221128040338.1936529-1-ira.weiny@intel.com
Headers
Series PCI/DOE: Remove asynchronous task support |

Message

Ira Weiny Nov. 28, 2022, 4:03 a.m. UTC 
  From: Ira Weiny <ira.weiny@intel.com>

Changes from V2
	From Jonathan
		Add comment about change in PCI_DOE_POLL_INTERVAL value
		Remove additional code

Changes from V1
	Address comments around locking
	Add patch to remove unneeded pci_doe_flush_mb() call

The asynchronous task support in the PCI DOE mailboxes has become a
maintenance burden.

Remove the code associated with that support.

Ira Weiny (2):
  PCI/DOE: Remove the pci_doe_flush_mb() call
  PCI/DOE: Remove asynchronous task support

 drivers/cxl/core/pci.c  |  16 +----
 drivers/pci/doe.c       | 135 ++++++++++------------------------------
 include/linux/pci-doe.h |  11 +---
 3 files changed, 36 insertions(+), 126 deletions(-)


base-commit: b6e7fdfd6f6a8bf88fcdb4a45da52c42ba238c25

Comments

Ira Weiny Nov. 28, 2022, 4:57 p.m. UTC | #1 
On Mon, Nov 28, 2022 at 05:51:12PM +0800, Hillf Danton wrote:
> On 27 Nov 2022 20:03:38 -0800 Ira Weiny <ira.weiny@intel.com>
> > @@ -49,7 +48,7 @@ struct pci_doe_mb {
> >  	struct xarray prots;
> >  
> >  	wait_queue_head_t wq;
> > -	struct workqueue_struct *work_queue;
> > +	struct mutex lock;
> >  	unsigned long flags;
> >  };
> 
> Add a followup cleanup patch to cut wait queue off as the wakeup in
> pci_doe_flush_mb() is gone.

Thanks.  That should have been part of patch 1/2 as it is gone then.

Ira