mbox series

[0/2] x86/xen: don't return from xen_pv_play_dead()

Message ID 20221125063248.30256-1-jgross@suse.com
Headers
Series x86/xen: don't return from xen_pv_play_dead() |

Message

Juergen Gross Nov. 25, 2022, 6:32 a.m. UTC 
  All play_dead() functions but xen_pv_play_dead() don't return to the
caller.

Adapt xen_pv_play_dead() to behave like the other play_dead() variants.

Juergen Gross (2):
  x86/xen: don't let xen_pv_play_dead() return
  x86/xen: mark xen_pv_play_dead() as __noreturn

 arch/x86/xen/smp.h      |  2 ++
 arch/x86/xen/smp_pv.c   | 17 ++++-------------
 arch/x86/xen/xen-head.S |  7 +++++++
 tools/objtool/check.c   |  1 +
 4 files changed, 14 insertions(+), 13 deletions(-)

Comments

Juergen Gross Jan. 16, 2023, 7:49 a.m. UTC | #1 
On 25.11.22 07:32, Juergen Gross wrote:
> All play_dead() functions but xen_pv_play_dead() don't return to the
> caller.
> 
> Adapt xen_pv_play_dead() to behave like the other play_dead() variants.
> 
> Juergen Gross (2):
>    x86/xen: don't let xen_pv_play_dead() return
>    x86/xen: mark xen_pv_play_dead() as __noreturn
> 
>   arch/x86/xen/smp.h      |  2 ++
>   arch/x86/xen/smp_pv.c   | 17 ++++-------------
>   arch/x86/xen/xen-head.S |  7 +++++++
>   tools/objtool/check.c   |  1 +
>   4 files changed, 14 insertions(+), 13 deletions(-)
> 

Ping?


Juergen
Peter Zijlstra Jan. 16, 2023, 9:12 a.m. UTC | #2 
On Fri, Nov 25, 2022 at 07:32:46AM +0100, Juergen Gross wrote:
> All play_dead() functions but xen_pv_play_dead() don't return to the
> caller.
> 
> Adapt xen_pv_play_dead() to behave like the other play_dead() variants.
> 
> Juergen Gross (2):
>   x86/xen: don't let xen_pv_play_dead() return
>   x86/xen: mark xen_pv_play_dead() as __noreturn
> 
>  arch/x86/xen/smp.h      |  2 ++
>  arch/x86/xen/smp_pv.c   | 17 ++++-------------
>  arch/x86/xen/xen-head.S |  7 +++++++
>  tools/objtool/check.c   |  1 +
>  4 files changed, 14 insertions(+), 13 deletions(-)

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Boris Ostrovsky Jan. 16, 2023, 8:46 p.m. UTC | #3 
On 1/16/23 2:49 AM, Juergen Gross wrote:
> On 25.11.22 07:32, Juergen Gross wrote:
>> All play_dead() functions but xen_pv_play_dead() don't return to the
>> caller.
>>
>> Adapt xen_pv_play_dead() to behave like the other play_dead() variants.
>>
>> Juergen Gross (2):
>>    x86/xen: don't let xen_pv_play_dead() return
>>    x86/xen: mark xen_pv_play_dead() as __noreturn
>>
>>   arch/x86/xen/smp.h      |  2 ++
>>   arch/x86/xen/smp_pv.c   | 17 ++++-------------
>>   arch/x86/xen/xen-head.S |  7 +++++++
>>   tools/objtool/check.c   |  1 +
>>   4 files changed, 14 insertions(+), 13 deletions(-)
>>
>
> Ping?
>
>

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>