Message ID | 20221121174228.93670-1-fnkl.kernel@gmail.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1735614wrr; Mon, 21 Nov 2022 09:46:09 -0800 (PST) X-Google-Smtp-Source: AA0mqf6eaW4Z/B9Y9V45gxNWqa2iaithNOgURPKJ06pdBB68oTOz2ptPIy/WAjD4esx0tmFnZe0R X-Received: by 2002:a50:ec01:0:b0:461:8dc1:10b with SMTP id g1-20020a50ec01000000b004618dc1010bmr22114edr.113.1669052769462; Mon, 21 Nov 2022 09:46:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669052769; cv=none; d=google.com; s=arc-20160816; b=tjxkdcMISreyNfzuSlVS81t+6qWepl1Wb+0yTCAXFyiKTzZssn876RnV2EGGH2tr/X hwE5gCsLr+QV5vhT2nq5HqXGoy8wQugMTM6pEQ/a6y6BKIMc9xQJcpVbpDwI2ruMa5Vz l83KHafxoKpabyf98niybU+QX1u77yr9eXDq2ZXjxvbgoiBX93qV9xwygG7Kud/d5YdU rsSx+tfxXHmZjcZjgI4ON22Kdg8Pc7zXWKAoVsBJe03rtF1OkV8AzpNPGQ7o015piHc2 FTB+pxXHb6oiMExMEtrlKPMOZVDTpIEb6FqWzyTpWgWqHcD4n3fwTAUzNKl6JzSRgJI1 jb5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=RLnharg7HDG4tuhJcBKXRgEiJmoIlGVpeHO4ji1PupQ=; b=C92+9J2M8AlUeTuwmwcjIYR+K5KcpZQw0Eo7PKpEwVYqh16YQAzV7LKUpEnm4pQJt9 z6LKuW2OoEj5AxcqQjCFjcZZi9jquyA+juc2Vu9k2udfwiN0nIZguu/v6sOCwis3lGTr PTZe20iemz2m3yWR1ZU66XICJOY+ts1VDQhd2TQkmi/bdr5eaTzS/rSiSIcYV8Za9n+c uBY/VF6GpodmYoii4aewGRyJA91XCb1LkrjU4w70aFKEhVtqxLhmnLgDAai6eO21UzUX QhXLMwkP95B1lL9qQ7Q1KG32V5/7hS2fRDi4jgRWxWmqTt0Z5GMfKajaAc/XMTdGAshH RQWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=QMxs7gt0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w18-20020a056402269200b00461e122a4e4si10482253edd.314.2022.11.21.09.45.29; Mon, 21 Nov 2022 09:46:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=QMxs7gt0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229476AbiKURoo (ORCPT <rfc822;cjcooper78@gmail.com> + 99 others); Mon, 21 Nov 2022 12:44:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbiKURom (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 21 Nov 2022 12:44:42 -0500 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D5452C131; Mon, 21 Nov 2022 09:44:40 -0800 (PST) Received: by mail-ej1-x62f.google.com with SMTP id f27so30350832eje.1; Mon, 21 Nov 2022 09:44:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=RLnharg7HDG4tuhJcBKXRgEiJmoIlGVpeHO4ji1PupQ=; b=QMxs7gt0GdJyUwOlWlUC7k8EYUiuFa2UjgYIVh3FqAjs64LLxkxattfbJ6q9RN1/Xt UjgjDR2kn7+E1O5kJc+eIcAE2y5BELiDUH2a5ShKVTlU2XfWFWS8b9U615oGAaOZlu5W +zPWFpWn/EWRE8EgId63QukTU3LKvFicXp387MXKZtE87pailleizraUkcGWBTKwCAP2 jVfbC4J410Qr6kd/PVSo3cLwXm7N5Zg/bADMRrhobWTBlJ6CZV9WQQY/dObzVCwiJ7cZ /4xtai8Q71kHnPOjG0zCZtJTbCs07MeXUTmettAKy84z8xbSjOX/O2zHh+BZm0mB4WyV UmRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RLnharg7HDG4tuhJcBKXRgEiJmoIlGVpeHO4ji1PupQ=; b=3E2kCkA2nrF5rK9QKcf5AKl+W+6VJzM1Cei5oTHsbNUxPuxwtBKsfREq+oPAflkwf8 +jQe+KdRcXjiz6ekaf7jriez/bUcmxjiqhGuaL8IlxiEpvAiF7rQGCsw+ldFR8oynHNV zdbqGy4QHXWiTLbX58VDTAtbslIPIMK2nXJ28dUjlRvfxip7pifNnyjdTOf/NS8P+/0+ b9E5CNi+QZEOxwcPXJ4WN3CkqrM+sAto1UJ2kI97N63wTbeoJsrSuiLDF/JPp004T6KC 5hrTtwq/0+CqK2aM/EHIug3+PovRTxiCbnAwpqFaiHWy5uCGsbZun8QKbuTlr3UOAo1m Xeew== X-Gm-Message-State: ANoB5pkuCkIr+5nAoNfus34wE96VYwS7aunqkifHXRD8aw47B3RfWPSB H8XtLuTM8OwG9MkR2SC6zBE= X-Received: by 2002:a17:906:85d2:b0:78e:ebd:bf96 with SMTP id i18-20020a17090685d200b0078e0ebdbf96mr16597014ejy.625.1669052678827; Mon, 21 Nov 2022 09:44:38 -0800 (PST) Received: from localhost ([217.131.81.52]) by smtp.gmail.com with UTF8SMTPSA id 14-20020a170906308e00b007b29a6bec24sm5172485ejv.32.2022.11.21.09.44.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 09:44:38 -0800 (PST) From: Sasha Finkelstein <fnkl.kernel@gmail.com> To: thierry.reding@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sasha Finkelstein <fnkl.kernel@gmail.com> Subject: [PATCH RESEND v3 0/4] PWM and keyboard backlight driver for ARM Macs Date: Mon, 21 Nov 2022 20:42:24 +0300 Message-Id: <20221121174228.93670-1-fnkl.kernel@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750128676884927963?= X-GMAIL-MSGID: =?utf-8?q?1750128676884927963?= |
Series |
PWM and keyboard backlight driver for ARM Macs
|
|
Message
Sasha Finkelstein
Nov. 21, 2022, 5:42 p.m. UTC
Hi, This is a resend of the v3 of the patch series to add PWM and keyboard backlight driver for ARM macs. Changes in v1: Addressing the review comments. Changes in v2: Added the reviewed-by and acked-by tags. Addressing a review comment. v1: https://www.spinics.net/lists/linux-pwm/msg19500.html v2: https://www.spinics.net/lists/linux-pwm/msg19562.html Sasha Finkelstein (4): dt-bindings: pwm: Add Apple PWM controller pwm: Add Apple PWM controller arm64: dts: apple: t8103: Add PWM controller MAINTAINERS: Add entries for Apple PWM driver .../bindings/pwm/apple,s5l-fpwm.yaml | 51 +++++++ MAINTAINERS | 2 + arch/arm64/boot/dts/apple/t8103-j293.dts | 20 +++ arch/arm64/boot/dts/apple/t8103-j313.dts | 20 +++ arch/arm64/boot/dts/apple/t8103.dtsi | 9 ++ drivers/pwm/Kconfig | 12 ++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-apple.c | 127 ++++++++++++++++++ 8 files changed, 242 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml create mode 100644 drivers/pwm/pwm-apple.c
Comments
On Mon, Nov 21, 2022 at 08:42:26PM +0300, Sasha Finkelstein wrote: > Adds the Apple PWM controller driver. > > Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com> > Acked-by: Sven Peter <sven@svenpeter.dev> > --- > drivers/pwm/Kconfig | 12 ++++ > drivers/pwm/Makefile | 1 + > drivers/pwm/pwm-apple.c | 127 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 140 insertions(+) > create mode 100644 drivers/pwm/pwm-apple.c > > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig > index 60d13a949bc5..c3be11468414 100644 > --- a/drivers/pwm/Kconfig > +++ b/drivers/pwm/Kconfig > @@ -51,6 +51,18 @@ config PWM_AB8500 > To compile this driver as a module, choose M here: the module > will be called pwm-ab8500. > > +config PWM_APPLE > + tristate "Apple SoC PWM support" > + depends on ARCH_APPLE || COMPILE_TEST > + help > + Generic PWM framework driver for PWM controller present on > + Apple SoCs > + > + Say Y here if you have an ARM Apple laptop, otherwise say N > + > + To compile this driver as a module, choose M here: the module > + will be called pwm-apple. > + > config PWM_ATMEL > tristate "Atmel PWM support" > depends on ARCH_AT91 || COMPILE_TEST > diff --git a/drivers/pwm/Makefile b/drivers/pwm/Makefile > index 7bf1a29f02b8..19899b912e00 100644 > --- a/drivers/pwm/Makefile > +++ b/drivers/pwm/Makefile > @@ -2,6 +2,7 @@ > obj-$(CONFIG_PWM) += core.o > obj-$(CONFIG_PWM_SYSFS) += sysfs.o > obj-$(CONFIG_PWM_AB8500) += pwm-ab8500.o > +obj-$(CONFIG_PWM_APPLE) += pwm-apple.o > obj-$(CONFIG_PWM_ATMEL) += pwm-atmel.o > obj-$(CONFIG_PWM_ATMEL_HLCDC_PWM) += pwm-atmel-hlcdc.o > obj-$(CONFIG_PWM_ATMEL_TCB) += pwm-atmel-tcb.o > diff --git a/drivers/pwm/pwm-apple.c b/drivers/pwm/pwm-apple.c > new file mode 100644 > index 000000000000..b0c3f86fd578 > --- /dev/null > +++ b/drivers/pwm/pwm-apple.c > @@ -0,0 +1,127 @@ > +// SPDX-License-Identifier: GPL-2.0 OR MIT Kernel code is generally GPL-2.0 only. No other PWM driver is MIT licensed. So why this one. Mixing licenses is a problem because few people look at the licenses when copying code around. > +/* > + * Driver for the Apple SoC PWM controller > + * > + * Copyright The Asahi Linux Contributors > + */ > + > +#include <linux/clk.h> > +#include <linux/io.h> > +#include <linux/math64.h> > +#include <linux/module.h> > +#include <linux/of.h> > +#include <linux/of_device.h> > +#include <linux/platform_device.h> > +#include <linux/pm_runtime.h> > +#include <linux/pwm.h> > + > +#define PWM_CONTROL 0x00 > +#define PWM_ON_CYCLES 0x1c > +#define PWM_OFF_CYCLES 0x18 > + > +#define CTRL_ENABLE BIT(0) > +#define CTRL_MODE BIT(2) > +#define CTRL_UPDATE BIT(5) > +#define CTRL_TRIGGER BIT(9) > +#define CTRL_INVERT BIT(10) > +#define CTRL_OUTPUT_ENABLE BIT(14) > + > +struct apple_pwm { > + struct pwm_chip chip; > + void __iomem *base; > + u64 clkrate; > +}; > + > +static int apple_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, > + const struct pwm_state *state) > +{ > + struct apple_pwm *fpwm; > + u64 on_cycles, off_cycles; > + > + fpwm = container_of(chip, struct apple_pwm, chip); > + if (state->enabled) { > + on_cycles = mul_u64_u64_div_u64(fpwm->clkrate, > + state->duty_cycle, NSEC_PER_SEC); > + off_cycles = mul_u64_u64_div_u64(fpwm->clkrate, > + state->period, NSEC_PER_SEC) - on_cycles; > + writel(on_cycles, fpwm->base + PWM_ON_CYCLES); > + writel(off_cycles, fpwm->base + PWM_OFF_CYCLES); > + writel(CTRL_ENABLE | CTRL_OUTPUT_ENABLE | CTRL_UPDATE, > + fpwm->base + PWM_CONTROL); > + } else { > + writel(0, fpwm->base + PWM_CONTROL); > + } > + return 0; > +} > + > +static void apple_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, > + struct pwm_state *state) > +{ > + struct apple_pwm *fpwm; > + u32 on_cycles, off_cycles, ctrl; > + > + fpwm = container_of(chip, struct apple_pwm, chip); > + > + ctrl = readl(fpwm->base + PWM_CONTROL); > + on_cycles = readl(fpwm->base + PWM_ON_CYCLES); > + off_cycles = readl(fpwm->base + PWM_OFF_CYCLES); > + > + state->enabled = (ctrl & CTRL_ENABLE) && (ctrl & CTRL_OUTPUT_ENABLE); > + state->polarity = PWM_POLARITY_NORMAL; > + state->duty_cycle = div_u64(on_cycles, fpwm->clkrate) * NSEC_PER_SEC; > + state->period = div_u64(off_cycles + on_cycles, fpwm->clkrate) * NSEC_PER_SEC; > +} > + > +static const struct pwm_ops apple_pwm_ops = { > + .apply = apple_pwm_apply, > + .get_state = apple_pwm_get_state, > + .owner = THIS_MODULE, > +}; > + > +static int apple_pwm_probe(struct platform_device *pdev) > +{ > + struct apple_pwm *pwm; > + struct clk *clk; > + int ret; > + > + pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); > + if (!pwm) > + return -ENOMEM; > + > + pwm->base = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(pwm->base)) > + return PTR_ERR(pwm->base); > + > + platform_set_drvdata(pdev, pwm); > + > + clk = devm_clk_get_enabled(&pdev->dev, NULL); > + if (IS_ERR(clk)) > + return PTR_ERR(clk); > + > + pwm->clkrate = clk_get_rate(clk); > + pwm->chip.dev = &pdev->dev; > + pwm->chip.npwm = 1; > + pwm->chip.ops = &apple_pwm_ops; > + > + ret = devm_pwmchip_add(&pdev->dev, &pwm->chip); This symbol is EXPORT_SYMBOL_GPL. So how can this module be MIT licensed? > + return ret; > +} > + > +static const struct of_device_id apple_pwm_of_match[] = { > + { .compatible = "apple,s5l-fpwm" }, > + {} > +}; > +MODULE_DEVICE_TABLE(of, apple_pwm_of_match); > + > +static struct platform_driver apple_pwm_driver = { > + .probe = apple_pwm_probe, > + .driver = { > + .name = "apple-pwm", > + .owner = THIS_MODULE, This line should be dropped. > + .of_match_table = apple_pwm_of_match, > + }, > +}; > +module_platform_driver(apple_pwm_driver); > + > +MODULE_DESCRIPTION("Apple SoC PWM driver"); > +MODULE_LICENSE("Dual MIT/GPL"); > -- > 2.38.1 > >
On 23/11/2022 11.24, Rob Herring wrote: > On Mon, Nov 21, 2022 at 08:42:26PM +0300, Sasha Finkelstein wrote: >> diff --git a/drivers/pwm/pwm-apple.c b/drivers/pwm/pwm-apple.c >> new file mode 100644 >> index 000000000000..b0c3f86fd578 >> --- /dev/null >> +++ b/drivers/pwm/pwm-apple.c >> @@ -0,0 +1,127 @@ >> +// SPDX-License-Identifier: GPL-2.0 OR MIT > > Kernel code is generally GPL-2.0 only. No other PWM driver is MIT > licensed. So why this one. > > Mixing licenses is a problem because few people look at the licenses > when copying code around. *Sigh*. We encourage the use of MIT dual-licensing as a project to allow other OSes to port the drivers over without having to rewrite them, for any driver written from scratch. We've had this conversation quite a few times already... >> + >> + ret = devm_pwmchip_add(&pdev->dev, &pwm->chip); > > This symbol is EXPORT_SYMBOL_GPL. So how can this module be MIT > licensed? Because they are compatible licenses. The combination of this driver and the kernel is GPL, but this driver itself is MIT. People are free to port it to other OSes and reimplement devm_pwmchip_add or replace the call with something else. The EXPORT_SYMBOL_GPL stuff is about blocking *proprietary* GPL-incompatible modules from using those symbols. This is a GPL-compatible, explicitly dual-licensed module. In this case the driver is trivial enough there isn't much to gain from dual-licensing since the parts that matter (the reverse engineering) are not copyrightable, but I still find it silly that we keep getting told more permissive licensing is a problem. People are free to dual-license their work as they see fit, it's a fundamental freedom in free software, and plenty of kernel code is dual-licensed like this (including much of DRM and entire GPU drivers). - Hector
Hello, On Mon, Nov 21, 2022 at 08:42:26PM +0300, Sasha Finkelstein wrote: > Adds the Apple PWM controller driver. > > Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com> > Acked-by: Sven Peter <sven@svenpeter.dev> > --- > drivers/pwm/Kconfig | 12 ++++ > drivers/pwm/Makefile | 1 + > drivers/pwm/pwm-apple.c | 127 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 140 insertions(+) > create mode 100644 drivers/pwm/pwm-apple.c > > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig > index 60d13a949bc5..c3be11468414 100644 > --- a/drivers/pwm/Kconfig > +++ b/drivers/pwm/Kconfig > @@ -51,6 +51,18 @@ config PWM_AB8500 > To compile this driver as a module, choose M here: the module > will be called pwm-ab8500. > > +config PWM_APPLE > + tristate "Apple SoC PWM support" > + depends on ARCH_APPLE || COMPILE_TEST > + help > + Generic PWM framework driver for PWM controller present on > + Apple SoCs > + > + Say Y here if you have an ARM Apple laptop, otherwise say N > + > + To compile this driver as a module, choose M here: the module > + will be called pwm-apple. > + > config PWM_ATMEL > tristate "Atmel PWM support" > depends on ARCH_AT91 || COMPILE_TEST > diff --git a/drivers/pwm/Makefile b/drivers/pwm/Makefile > index 7bf1a29f02b8..19899b912e00 100644 > --- a/drivers/pwm/Makefile > +++ b/drivers/pwm/Makefile > @@ -2,6 +2,7 @@ > obj-$(CONFIG_PWM) += core.o > obj-$(CONFIG_PWM_SYSFS) += sysfs.o > obj-$(CONFIG_PWM_AB8500) += pwm-ab8500.o > +obj-$(CONFIG_PWM_APPLE) += pwm-apple.o > obj-$(CONFIG_PWM_ATMEL) += pwm-atmel.o > obj-$(CONFIG_PWM_ATMEL_HLCDC_PWM) += pwm-atmel-hlcdc.o > obj-$(CONFIG_PWM_ATMEL_TCB) += pwm-atmel-tcb.o > diff --git a/drivers/pwm/pwm-apple.c b/drivers/pwm/pwm-apple.c > new file mode 100644 > index 000000000000..b0c3f86fd578 > --- /dev/null > +++ b/drivers/pwm/pwm-apple.c > @@ -0,0 +1,127 @@ > +// SPDX-License-Identifier: GPL-2.0 OR MIT > +/* > + * Driver for the Apple SoC PWM controller > + * > + * Copyright The Asahi Linux Contributors > + */ > + > +#include <linux/clk.h> > +#include <linux/io.h> > +#include <linux/math64.h> > +#include <linux/module.h> > +#include <linux/of.h> > +#include <linux/of_device.h> > +#include <linux/platform_device.h> > +#include <linux/pm_runtime.h> > +#include <linux/pwm.h> > + > +#define PWM_CONTROL 0x00 > +#define PWM_ON_CYCLES 0x1c > +#define PWM_OFF_CYCLES 0x18 > + > +#define CTRL_ENABLE BIT(0) > +#define CTRL_MODE BIT(2) > +#define CTRL_UPDATE BIT(5) > +#define CTRL_TRIGGER BIT(9) > +#define CTRL_INVERT BIT(10) > +#define CTRL_OUTPUT_ENABLE BIT(14) Please use a driver specific prefix on these defines to make it obvious that they are driver specific. > +struct apple_pwm { > + struct pwm_chip chip; > + void __iomem *base; > + u64 clkrate; > +}; > + > +static int apple_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, > + const struct pwm_state *state) > +{ > + struct apple_pwm *fpwm; > + u64 on_cycles, off_cycles; > + > + fpwm = container_of(chip, struct apple_pwm, chip); Please introduce a macro or static inline for that. > + if (state->enabled) { > + on_cycles = mul_u64_u64_div_u64(fpwm->clkrate, > + state->duty_cycle, NSEC_PER_SEC); This might overflow for big values of clkrate and duty_cycle. The usual approach is to check for clkrate <= NSEC_PER_SEC. See pwm-lpc18xx-sct.c for an example. > + off_cycles = mul_u64_u64_div_u64(fpwm->clkrate, > + state->period, NSEC_PER_SEC) - on_cycles; > + writel(on_cycles, fpwm->base + PWM_ON_CYCLES); You're assuming on_cycles to fit into an u32 here. Please ensure that's a valid claim. > + writel(off_cycles, fpwm->base + PWM_OFF_CYCLES); > + writel(CTRL_ENABLE | CTRL_OUTPUT_ENABLE | CTRL_UPDATE, > + fpwm->base + PWM_CONTROL); How does the hardware behave on updates? Are the register values shadowed until PWM_CONTROL is written? Or until the next period starts? Please document this at the top of the driver file, in the same format as e.g. pwm-sl28cpld.c does. (The relevant section is called "Limitations", actually "Hardware properties" would be a better name, but please stick to the former for easier greppability.) > + } else { > + writel(0, fpwm->base + PWM_CONTROL); > + } > + return 0; > +} > + > +static void apple_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, > + struct pwm_state *state) > +{ > + struct apple_pwm *fpwm; > + u32 on_cycles, off_cycles, ctrl; > + > + fpwm = container_of(chip, struct apple_pwm, chip); > + > + ctrl = readl(fpwm->base + PWM_CONTROL); > + on_cycles = readl(fpwm->base + PWM_ON_CYCLES); > + off_cycles = readl(fpwm->base + PWM_OFF_CYCLES); > + > + state->enabled = (ctrl & CTRL_ENABLE) && (ctrl & CTRL_OUTPUT_ENABLE); > + state->polarity = PWM_POLARITY_NORMAL; > + state->duty_cycle = div_u64(on_cycles, fpwm->clkrate) * NSEC_PER_SEC; > + state->period = div_u64(off_cycles + on_cycles, fpwm->clkrate) * NSEC_PER_SEC; You're loosing precision here, always do the division last. Also the rounding is wrong. Enabling PWM_DEBUG + some non-trivial testing should tell you that. > +} > + > +static const struct pwm_ops apple_pwm_ops = { > + .apply = apple_pwm_apply, > + .get_state = apple_pwm_get_state, > + .owner = THIS_MODULE, > +}; > + > +static int apple_pwm_probe(struct platform_device *pdev) > +{ > + struct apple_pwm *pwm; The name "pwm" is usually (only) used for struct pwm_device variables. Please pick another name (something like ddata or pc are usual names), above you picked "fpwm", which I could live with, too. > + struct clk *clk; > + int ret; > + > + pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); > + if (!pwm) > + return -ENOMEM; > + > + pwm->base = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(pwm->base)) > + return PTR_ERR(pwm->base); > + > + platform_set_drvdata(pdev, pwm); This is unused. > + clk = devm_clk_get_enabled(&pdev->dev, NULL); > + if (IS_ERR(clk)) Error message please, preferably using dev_err_probe. > + return PTR_ERR(clk); > + > + pwm->clkrate = clk_get_rate(clk); > + pwm->chip.dev = &pdev->dev; > + pwm->chip.npwm = 1; > + pwm->chip.ops = &apple_pwm_ops; > + > + ret = devm_pwmchip_add(&pdev->dev, &pwm->chip); Ditto. > + return ret; > +} > + > +static const struct of_device_id apple_pwm_of_match[] = { > + { .compatible = "apple,s5l-fpwm" }, > + {} > +}; > +MODULE_DEVICE_TABLE(of, apple_pwm_of_match); > + > +static struct platform_driver apple_pwm_driver = { > + .probe = apple_pwm_probe, > + .driver = { > + .name = "apple-pwm", > + .owner = THIS_MODULE, > + .of_match_table = apple_pwm_of_match, > + }, > +}; > +module_platform_driver(apple_pwm_driver); > + > +MODULE_DESCRIPTION("Apple SoC PWM driver"); > +MODULE_LICENSE("Dual MIT/GPL");