mbox series

[v2,0/5] arm64: dts: qcom: msm8916-gplus-fl8005a: Add initial device tree

Message ID 20221121004813.3883-1-linmengbo0689@protonmail.com
Headers
Series arm64: dts: qcom: msm8916-gplus-fl8005a: Add initial device tree |

Message

Lin, Meng-Bo Nov. 21, 2022, 12:49 a.m. UTC 
  v2: Set property status = "okay"; as the last property.
Reword the bindings patch.

GPLUS FL8005A is a tablet using the MSM8916 SoC released in 2015.

Add a device tree for with initial support for:

- GPIO keys
- GPIO LEDs
- pm8916-vibrator
- SDHCI (internal and external storage)
- USB Device Mode
- UART
- WCNSS (WiFi/BT)
- Regulators
- Focaltech FT5402 touchscreen
- SGM3140 Flash LED

Comments

Linus Walleij Nov. 21, 2022, 10:27 a.m. UTC | #1 
On Mon, Nov 21, 2022 at 1:49 AM Lin, Meng-Bo
<linmengbo0689@protonmail.com> wrote:

> GPLUS FL8005A is a tablet using the MSM8916 SoC released in 2015.
>
> Add a device tree for with initial support for:
>
> - GPIO keys
> - GPIO LEDs
> - pm8916-vibrator
> - SDHCI (internal and external storage)
> - USB Device Mode
> - UART
> - WCNSS (WiFi/BT)

I don't see this WCNSS in your initial device tree?
Which one is is, BTW?

The WCN36xx actually supported by the kernel or older
such as WCN1314?

Yours,
Linus Walleij
Stephan Gerhold Nov. 21, 2022, 10:38 a.m. UTC | #2 
On Mon, Nov 21, 2022 at 11:27:30AM +0100, Linus Walleij wrote:
> On Mon, Nov 21, 2022 at 1:49 AM Lin, Meng-Bo
> <linmengbo0689@protonmail.com> wrote:
> 
> > GPLUS FL8005A is a tablet using the MSM8916 SoC released in 2015.
> >
> > Add a device tree for with initial support for:
> >
> > - GPIO keys
> > - GPIO LEDs
> > - pm8916-vibrator
> > - SDHCI (internal and external storage)
> > - USB Device Mode
> > - UART
> > - WCNSS (WiFi/BT)
> 
> I don't see this WCNSS in your initial device tree?

The WCNSS remoteproc currently has the &pronto label in msm8916.dtsi.
This can be quite confusing, I know. :/

(I think "pronto" is the code name for the implementation version in
 MSM8916 and a few related SoCs or something. On APQ8064 this is called
 "riva"...)

> Which one is is, BTW?
> 
> The WCN36xx actually supported by the kernel or older
> such as WCN1314?
> 

It's the WCN36xx that is supported by the kernel. :)
Probably WCN3620 in this case.

Stephan