mbox series

[0/2] x86/xen: Fix memory leak issue

Message ID 20221119085923.114889-1-xiujianfeng@huawei.com
Headers
Series x86/xen: Fix memory leak issue |

Message

Xiu Jianfeng Nov. 19, 2022, 8:59 a.m. UTC 
  The new string allocated by kasprintf() is leaked on error path

Xiu Jianfeng (2):
  x86/xen: Fix memory leak in xen_smp_intr_init{_pv}()
  x86/xen: Fix memory leak in xen_init_lock_cpu()

 arch/x86/xen/smp.c      | 16 ++++++++++++----
 arch/x86/xen/smp_pv.c   |  8 ++++++--
 arch/x86/xen/spinlock.c |  3 ++-
 3 files changed, 20 insertions(+), 7 deletions(-)

Comments

Juergen Gross Nov. 23, 2022, 3:23 p.m. UTC | #1 
On 19.11.22 09:59, Xiu Jianfeng wrote:
> The new string allocated by kasprintf() is leaked on error path
> 
> Xiu Jianfeng (2):
>    x86/xen: Fix memory leak in xen_smp_intr_init{_pv}()
>    x86/xen: Fix memory leak in xen_init_lock_cpu()
> 
>   arch/x86/xen/smp.c      | 16 ++++++++++++----
>   arch/x86/xen/smp_pv.c   |  8 ++++++--
>   arch/x86/xen/spinlock.c |  3 ++-
>   3 files changed, 20 insertions(+), 7 deletions(-)
> 

Hmm, I think it would make more sense to always store the name generated
via kasprintf() in the percpu variable (independently from succeeding to
bind the irq), and in the related free function to always kfree() it and
set it to NULL again.

This would result in less code.


Juergen
Xiu Jianfeng Nov. 23, 2022, 4:03 p.m. UTC | #2 
Hi,

在 2022/11/23 23:23, Juergen Gross 写道:
> On 19.11.22 09:59, Xiu Jianfeng wrote:
>> The new string allocated by kasprintf() is leaked on error path
>>
>> Xiu Jianfeng (2):
>>    x86/xen: Fix memory leak in xen_smp_intr_init{_pv}()
>>    x86/xen: Fix memory leak in xen_init_lock_cpu()
>>
>>   arch/x86/xen/smp.c      | 16 ++++++++++++----
>>   arch/x86/xen/smp_pv.c   |  8 ++++++--
>>   arch/x86/xen/spinlock.c |  3 ++-
>>   3 files changed, 20 insertions(+), 7 deletions(-)
>>
> 
> Hmm, I think it would make more sense to always store the name generated
> via kasprintf() in the percpu variable (independently from succeeding to
> bind the irq), and in the related free function to always kfree() it and
> set it to NULL again.
> 
> This would result in less code.

Thanks, It's good to me, already sent v2.
> 
> 
> Juergen