Message ID | 20221117160015.344528-1-umang.jain@ideasonboard.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp481164wrr; Thu, 17 Nov 2022 08:04:15 -0800 (PST) X-Google-Smtp-Source: AA0mqf4/E8F8I2/B+/Uj31spPx8CrqqYQzkx6jB06dKGdb+wq8aKAgLiQ5M60bCZYBBJ+1gfjQ4M X-Received: by 2002:a17:902:7e88:b0:17f:6e07:74ed with SMTP id z8-20020a1709027e8800b0017f6e0774edmr3380651pla.67.1668701050019; Thu, 17 Nov 2022 08:04:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668701050; cv=none; d=google.com; s=arc-20160816; b=WZlHMz+b2P3DqzqiZjNAKiYIKj8Vi9O8b2392f9ioNbjOnNISEQiFI7Sq6sRlDjM7A 63RYdvOM2DjGET7sLOJV8Z+d8AYFzc99p/5coZp4fWl15LeKGmUvgi15lumV4CS0S7mF m2WDSS1Zp+47L9FgotBz5DCL25EEl0ujyHvtmDt9GYVdS919IBSMA3Yl4zFjLFdlGPA9 pt76jqcxhmLtvDU9yJlei+hwnmWDvu71csEzLy7t4lmRnJ0S4F5X8n21eE44tceFOpPO chjnB6iDV+BxUKOeZYcG4rBNU4Vnytlhrucp4PH5+srcgwwZg6C3n4uXAe+Q0Sse/Kqs FCgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=nC5lwa9qyXE6yv8nCo6rGOFnigcpUzHFd3IO9ucpbWA=; b=BczWnlIgXOP2y35gw3H/SVIzTI6mskiwoiFVc/X80jZc6ZUvj8vpfv+zRN7IcBKs7U YeKUvOXakKw52K2bpXhc/yTq718VuXYHf1d/cTezKrDN5xEuD+wZNM2qpSef/3mSl7Ya OilPaj5nPw+CPtY52CWqoeszNkW2+S9j8InBZeQphUf7SewOHW8PbuoLLK8rQGRXSIvb jfLx+f/2vIEke06fvoza8HszJRsDVKZT0GpB2xdOAvKISTd+OrEZMDLDWWssck7zISYb p66N5H5nSo4/dAc2pd9I5Au1knjCouFgmOZ0M7BbOMNj5ojMfeAy5x2GiCKSlcsE1jZI JRZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=t8O5JmSt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j25-20020a635519000000b00460a6ee5b53si1302590pgb.37.2022.11.17.08.03.29; Thu, 17 Nov 2022 08:04:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=t8O5JmSt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239874AbiKQQAd (ORCPT <rfc822;a1648639935@gmail.com> + 99 others); Thu, 17 Nov 2022 11:00:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234802AbiKQQAb (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 17 Nov 2022 11:00:31 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FA87260 for <linux-kernel@vger.kernel.org>; Thu, 17 Nov 2022 08:00:29 -0800 (PST) Received: from ideasonboard.com (unknown [103.251.226.79]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A3F26929; Thu, 17 Nov 2022 17:00:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668700827; bh=I80Tp79qaCwo6ciskJK+YDceactFw/U1YNWBgPsEn2A=; h=From:To:Cc:Subject:Date:From; b=t8O5JmSt0OkQpDdVs4jVRkYSElAtfH7sVJKhEZ7lcLmrpYADbJgA4QchJb8m/f8Y0 bRZcXDV/uaZTZPwE1INty6jpQCXgB2Sna5lICJs+6L080mrtNpgW4ZFm2hPS3unqYP KOJeBEOCrbdwHHF+zQWaHxOHOevnc/S8oNM/L+ds= From: Umang Jain <umang.jain@ideasonboard.com> To: Florian Fainelli <f.fainelli@gmail.com>, Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, Ray Jui <rjui@broadcom.com>, Dan Carpenter <error27@gmail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Dave Stevenson <dave.stevenson@raspberrypi.com>, Mauro Carvalho Chehab <mchehab+samsung@kernel.org>, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: kieran.bingham@ideasonboard.com, Umang Jain <umang.jain@ideasonboard.com> Subject: [PATCH 0/3] vc04_services: Promote bool usage Date: Thu, 17 Nov 2022 21:30:12 +0530 Message-Id: <20221117160015.344528-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749759872550262200?= X-GMAIL-MSGID: =?utf-8?q?1749759872550262200?= |
Series | vc04_services: Promote bool usage | |
Message
Umang Jain
Nov. 17, 2022, 4 p.m. UTC
In commit 7967656ffbfa ("coding-style: Clarify the expectations around bool") the check to dis-allow bool structure members was removed from checkpatch.pl. It promotes bool structure members to store boolean values. This enhances code readability. Umang Jain (3): Revert "staging: mmal-vchiq: Avoid use of bool in structures" vc04_services: mmal-vchiq: Use bool for vchiq_mmal_component.in_use vc04_services: bcm2835-camera: Use bool values for mmal_fmt.remove_padding .../bcm2835-camera/bcm2835-camera.c | 30 +++++++++---------- .../vc04_services/vchiq-mmal/mmal-vchiq.c | 18 +++++------ .../vc04_services/vchiq-mmal/mmal-vchiq.h | 6 ++-- 3 files changed, 27 insertions(+), 27 deletions(-)
Comments
Hi Dave, Am 17.11.22 um 17:00 schrieb Umang Jain: > In commit 7967656ffbfa ("coding-style: Clarify the expectations around > bool") the check to dis-allow bool structure members was removed from > checkpatch.pl. It promotes bool structure members to store boolean > values. This enhances code readability. > > Umang Jain (3): > Revert "staging: mmal-vchiq: Avoid use of bool in structures" > vc04_services: mmal-vchiq: Use bool for vchiq_mmal_component.in_use > vc04_services: bcm2835-camera: Use bool values for > mmal_fmt.remove_padding > > .../bcm2835-camera/bcm2835-camera.c | 30 +++++++++---------- > .../vc04_services/vchiq-mmal/mmal-vchiq.c | 18 +++++------ > .../vc04_services/vchiq-mmal/mmal-vchiq.h | 6 ++-- could you please check these changes to be safe? I'm not sure that the affected declarations are really internal. I'm afraid this might affect firmware or userspace. > 3 files changed, 27 insertions(+), 27 deletions(-) >
On Thu, Nov 17, 2022 at 07:11:41PM +0100, Stefan Wahren wrote: > Hi Dave, > > Am 17.11.22 um 17:00 schrieb Umang Jain: > > In commit 7967656ffbfa ("coding-style: Clarify the expectations around > > bool") the check to dis-allow bool structure members was removed from > > checkpatch.pl. It promotes bool structure members to store boolean > > values. This enhances code readability. > > > > Umang Jain (3): > > Revert "staging: mmal-vchiq: Avoid use of bool in structures" > > vc04_services: mmal-vchiq: Use bool for vchiq_mmal_component.in_use > > vc04_services: bcm2835-camera: Use bool values for > > mmal_fmt.remove_padding > > > > .../bcm2835-camera/bcm2835-camera.c | 30 +++++++++---------- > > .../vc04_services/vchiq-mmal/mmal-vchiq.c | 18 +++++------ > > .../vc04_services/vchiq-mmal/mmal-vchiq.h | 6 ++-- > could you please check these changes to be safe? I'm not sure that the > affected declarations are really internal. I'm afraid this might affect > firmware or userspace. The structs have a bunch of kernel pointers in them so hopefully they are internal. Otherwise we have a different sort of problem. regards, dan carpenter
Hi Stefan On Thu, 17 Nov 2022 at 18:11, Stefan Wahren <stefan.wahren@i2se.com> wrote: > > Hi Dave, > > Am 17.11.22 um 17:00 schrieb Umang Jain: > > In commit 7967656ffbfa ("coding-style: Clarify the expectations around > > bool") the check to dis-allow bool structure members was removed from > > checkpatch.pl. It promotes bool structure members to store boolean > > values. This enhances code readability. > > > > Umang Jain (3): > > Revert "staging: mmal-vchiq: Avoid use of bool in structures" > > vc04_services: mmal-vchiq: Use bool for vchiq_mmal_component.in_use > > vc04_services: bcm2835-camera: Use bool values for > > mmal_fmt.remove_padding > > > > .../bcm2835-camera/bcm2835-camera.c | 30 +++++++++---------- > > .../vc04_services/vchiq-mmal/mmal-vchiq.c | 18 +++++------ > > .../vc04_services/vchiq-mmal/mmal-vchiq.h | 6 ++-- > could you please check these changes to be safe? I'm not sure that the > affected declarations are really internal. I'm afraid this might affect > firmware or userspace. No problem. These are totally safe. As I've commented on the v2 patch, if it were in the mmal-msg*.h files then I'd be more concerned as those are matching the firmware structures, but these are just internal state. Dave > > 3 files changed, 27 insertions(+), 27 deletions(-) > >