mbox series

[v5,0/2] soc: ti: Add module build support to the k3 socinfo driver

Message ID 20221116145103.26744-1-nfrayer@baylibre.com
Headers
Series soc: ti: Add module build support to the k3 socinfo driver |

Message

Nicolas Frayer Nov. 16, 2022, 2:51 p.m. UTC 
  In order for the TI K3 SoC info driver to be built as a module, the
following changes have been made:
- Converted memory allocations to devm and added the remove callback
- Added necessary code to build the driver as a module

v2->v3:
dropped module conversion part of this series while other driver
dependencies on socinfo are worked out.
A dependency issue is introduced by changing subsys_initcall()
to module_platform_driver(). Some drivers using the socinfo information
probe before the socinfo driver itself and it makes their probe fail.

v3->v4:
reintegrated the module build support and added patches for udma and mdio
drivers to allow for deferred probe if socinfo hasn't probed yet.

v4->v5:
Remove the k3 udma and mdio patches from this series and sent them
individually

Nicolas Frayer (2):
  soc: ti: Convert allocations to devm
  soc: ti: Add module build support

 arch/arm64/Kconfig.platforms |  1 -
 drivers/soc/ti/Kconfig       |  3 ++-
 drivers/soc/ti/k3-socinfo.c  | 47 +++++++++++++++++++++++-------------
 3 files changed, 32 insertions(+), 19 deletions(-)

Comments

Nishanth Menon Nov. 17, 2022, 7:28 a.m. UTC | #1 
On 15:51-20221116, Nicolas Frayer wrote:
> In order for the TI K3 SoC info driver to be built as a module, the
> following changes have been made:
> - Converted memory allocations to devm and added the remove callback
> - Added necessary code to build the driver as a module
> 
> v2->v3:
> dropped module conversion part of this series while other driver
> dependencies on socinfo are worked out.
> A dependency issue is introduced by changing subsys_initcall()
> to module_platform_driver(). Some drivers using the socinfo information
> probe before the socinfo driver itself and it makes their probe fail.
> 
> v3->v4:
> reintegrated the module build support and added patches for udma and mdio
> drivers to allow for deferred probe if socinfo hasn't probed yet.
> 
> v4->v5:
> Remove the k3 udma and mdio patches from this series and sent them
> individually
> 
> Nicolas Frayer (2):
>   soc: ti: Convert allocations to devm
>   soc: ti: Add module build support
> 
>  arch/arm64/Kconfig.platforms |  1 -
>  drivers/soc/ti/Kconfig       |  3 ++-
>  drivers/soc/ti/k3-socinfo.c  | 47 +++++++++++++++++++++++-------------
>  3 files changed, 32 insertions(+), 19 deletions(-)

Sorry about another respin, but could you fix up $subject as per
git log --oneline drivers/soc/ti/k3-socinfo.c

I think you might want to use "soc: ti: k3-socinfo:"
>
Nicolas Frayer Nov. 17, 2022, 9:55 a.m. UTC | #2 
Le jeu. 17 nov. 2022 à 08:28, Nishanth Menon <nm@ti.com> a écrit :
>
> On 15:51-20221116, Nicolas Frayer wrote:
> > In order for the TI K3 SoC info driver to be built as a module, the
> > following changes have been made:
> > - Converted memory allocations to devm and added the remove callback
> > - Added necessary code to build the driver as a module
> >
> > v2->v3:
> > dropped module conversion part of this series while other driver
> > dependencies on socinfo are worked out.
> > A dependency issue is introduced by changing subsys_initcall()
> > to module_platform_driver(). Some drivers using the socinfo information
> > probe before the socinfo driver itself and it makes their probe fail.
> >
> > v3->v4:
> > reintegrated the module build support and added patches for udma and mdio
> > drivers to allow for deferred probe if socinfo hasn't probed yet.
> >
> > v4->v5:
> > Remove the k3 udma and mdio patches from this series and sent them
> > individually
> >
> > Nicolas Frayer (2):
> >   soc: ti: Convert allocations to devm
> >   soc: ti: Add module build support
> >
> >  arch/arm64/Kconfig.platforms |  1 -
> >  drivers/soc/ti/Kconfig       |  3 ++-
> >  drivers/soc/ti/k3-socinfo.c  | 47 +++++++++++++++++++++++-------------
> >  3 files changed, 32 insertions(+), 19 deletions(-)
>
> Sorry about another respin, but could you fix up $subject as per
> git log --oneline drivers/soc/ti/k3-socinfo.c
>
> I think you might want to use "soc: ti: k3-socinfo:"
> >
>
I'll send a v6 with the modified subject.

Thanks.
> --
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D