From patchwork Tue Nov 15 17:18:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Guittot X-Patchwork-Id: 1686 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2850740wru; Tue, 15 Nov 2022 09:24:21 -0800 (PST) X-Google-Smtp-Source: AA0mqf4eZOLM7mrj3Q3kKSe9D0z4C6r8nzWGQqgbSbOVnhjeflM3sbMwK6jbmTFabENyzh7cEhlb X-Received: by 2002:aa7:c993:0:b0:461:4fd3:377f with SMTP id c19-20020aa7c993000000b004614fd3377fmr15749430edt.234.1668533061011; Tue, 15 Nov 2022 09:24:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668533061; cv=none; d=google.com; s=arc-20160816; b=vyYHkMSjgSOCeZqbdimV/1DRy6ZjLoXyQJilwzyXbnjBp4VxQxc+YS6cHArBQmq9zV jywvzI66trixaqns+ck/MhZNO96JREsQl16PCt4GlNFvXKgOg81SwL+JIzEHzzXjDSDB 3Zp132HdlGDCg+ZyD2SRzBvScxQK/76DQQZ6+MQubZ102yF/r29ugJAIR60wtg3E1VUp Xq4dgLKUnv+DQTXoDWodb1Xmu5cbpF1s0ObDZW3y6pMV2U20+YQ/F7zPpCcDt14lRQcx frXouPcemqcp2JZGQgHADRAGkgsBdqWsRJsA31u4+vGb5iBhbQ2Wo+6fLpo9m1ExKIpL e25Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=H1ihDDubQnzVTvOXXe9DVf3BQyDu+DU5t/3cX5utHNE=; b=c5nPiRMq62pzsoZtEGV+CfC4BS+kDq1jwhEBBaP4zt+lYCon4ZstFh9QZBdSs/Hxhv 2dQqzxtDBMi5g2C0JjcPnuGnye5IBNVgeKhuIQ3CiVA4oVRHME9Nw4uE1OmCrZMCRNJo zMWs4jIDLAem9+NdgVxCUOZDAP3D/zB85ZWDXKkCiDKnIKdyVRExFU0R8sguVTaeWtmD 6mz+zdVX2l1jfy0SIMnffJN/+4Gd/q9bprctk0hKoEFsHKepeHC6xky9D/f1ZMU3/YFC 2AB1k8h7ZzC+YBxluAyMVysPmpAoyvzqBsjeTOnHpDtxri2j6QELHe9kSPCnaPd48Xrv ElVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vhs+mrFt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qk30-20020a1709077f9e00b007830f14fffesi12758739ejc.375.2022.11.15.09.23.56; Tue, 15 Nov 2022 09:24:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vhs+mrFt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230150AbiKORTQ (ORCPT + 99 others); Tue, 15 Nov 2022 12:19:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231705AbiKORTD (ORCPT ); Tue, 15 Nov 2022 12:19:03 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7542F585 for ; Tue, 15 Nov 2022 09:18:59 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id g12so25254892wrs.10 for ; Tue, 15 Nov 2022 09:18:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H1ihDDubQnzVTvOXXe9DVf3BQyDu+DU5t/3cX5utHNE=; b=vhs+mrFtOYyBA78Um2G35bHjJ+LJwb3kC93yOoNf10lJXMRC2u7G3aHQDx/MTLZ376 gpRdasH5U//hJzIMVd1PR9dABy3gNEKBzM/whev7T/1Q90dofPmvzyKZf4svXLl4xq8q 9J9eWPgBnNCXZmamA/XNIxrVs/KJkDGFPmjmg+AHpJBsjR+XzF986GUu0qIvIyAEQGJZ B/Ya0y4VmJ+JGqI1HeWfVhwj5H5WNWwLv1TbXnOuPUX8Z2jiWUYyv2B7JQ8jD3pGAiiK pbcr4ZpBjLG2427J0QAFOSYmX/iYJufEwtLQAlWNBQZrl1YbcYPESpBYWMA7j8rzgVr8 S/BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H1ihDDubQnzVTvOXXe9DVf3BQyDu+DU5t/3cX5utHNE=; b=cduJP1x84AoDUwOgXrgzryVA6iGadhWahw7r/qEL/zwdGgbO/MphoVDfLH0IIGUEZn 3h7ct16/NJ/OqkYXJQ7gnv9Whv5XoaHcpEJFQn3zO6S8WlxbHXSvLXnpN36coe0OnLNU aHkwLEgsdSMPit+CVQ5Kut7TqdTC+GgYOZxe/4USOqH1A5RGYUJdpTK3TISVAoulnrX+ KXzl6C56+qYFM/D3C2H6j+8s9MWanJWvdmA29ja8U52whgj9+0SV+EJTsQ0Ie+RzdW/x ikM4wJCNGZ2Y5XRa7O35pY6FsPrdZB9FzyYVTeh7+9SM6zEVTv8Ky2O0O0nS7O3AYGDW Osng== X-Gm-Message-State: ANoB5pmhV/YJrKF0+s1X+Vzb3k8Ror0T5zKUb5S1VOOoPVD97kU7rK9a ITti79kVEobSl8FmKqLpVpS1Ow== X-Received: by 2002:adf:f5c5:0:b0:22e:597:8541 with SMTP id k5-20020adff5c5000000b0022e05978541mr11845141wrp.612.1668532737954; Tue, 15 Nov 2022 09:18:57 -0800 (PST) Received: from localhost.localdomain ([2a01:e0a:f:6020:91c8:7496:8b73:811f]) by smtp.gmail.com with ESMTPSA id bg40-20020a05600c3ca800b003cf78aafdd7sm16846461wmb.39.2022.11.15.09.18.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 09:18:54 -0800 (PST) From: Vincent Guittot To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, linux-kernel@vger.kernel.org, parth@linux.ibm.com Cc: qyousef@layalina.io, chris.hyser@oracle.com, patrick.bellasi@matbug.net, David.Laight@aculab.com, pjt@google.com, pavel@ucw.cz, tj@kernel.org, qperret@google.com, tim.c.chen@linux.intel.com, joshdon@google.com, timj@gnu.org, kprateek.nayak@amd.com, yu.c.chen@intel.com, youssefesmat@chromium.org, joel@joelfernandes.org, Vincent Guittot Subject: [PATCH v9 0/9] Add latency priority for CFS class Date: Tue, 15 Nov 2022 18:18:42 +0100 Message-Id: <20221115171851.835-1-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749583723024950773?= X-GMAIL-MSGID: =?utf-8?q?1749583723024950773?= This patchset restarts the work about adding a latency priority to describe the latency tolerance of cfs tasks. Patch [1] is a new one that has been added with v6. It fixes an unfairness for low prio tasks because of wakeup_gran() being bigger than the maximum vruntime credit that a waking task can keep after sleeping. The patches [2-4] have been done by Parth: https://lore.kernel.org/lkml/20200228090755.22829-1-parth@linux.ibm.com/ I have just rebased and moved the set of latency priority outside the priority update. I have removed the reviewed tag because the patches are 2 years old. This aims to be a generic interface and the following patches is one use of it to improve the scheduling latency of cfs tasks. Patch [5] uses latency nice priority to define a latency offset and then decide if a cfs task can or should preempt the current running task. The patch gives some tests results with cyclictests and hackbench to highlight the benefit of latency priority for short interactive task or long intensive tasks. Patch [6] adds the support of latency nice priority to task group by adding a cpu.latency.nice field. The range is [-20:19] as for setting task latency priority. Patch [7] makes sched_core taking into account the latency offset. Patch [8] adds a rb tree to cover some corner cases where the latency sensitive task (priority < 0) is preempted by high priority task (RT/DL) or fails to preempt them. This patch ensures that tasks will have at least a slice of sched_min_granularity in priority at wakeup. Patch [9] removes useless check after adding a latency rb tree. I have also backported the patchset on a dragonboard RB3 with an android mainline kernel based on v5.18 for a quick test. I have used the TouchLatency app which is part of AOSP and described to be a very good test to highlight jitter and jank frame sources of a system [1]. In addition to the app, I have added some short running tasks waking-up regularly (to use the 8 cpus for 4 ms every 37777us) to stress the system without overloading it (and disabling EAS). The 1st results shows that the patchset helps to reduce the missed deadline frames from 5% to less than 0.1% when the cpu.latency.nice of task group are set. I haven't rerun the test with latest version. I have also tested the patchset with the modified version of the alsa latency test that has been shared by Tim. The test quickly xruns with default latency nice priority 0 but is able to run without underuns with a latency -20 and hackbench running simultaneously. While preparing the version 8, I have evaluated the benefit of using an augmented rbtree instead of adding a rbtree for latency sensitive entities, which was a relevant suggestion done by PeterZ. Although the augmented rbtree enables to sort additional information in the tree with a limited overhead, it has more impact on legacy use cases (latency_nice >= 0) because the augmented callbacks are always called to maintain this additional information even when there is no sensitive tasks. In such cases, the dedicated rbtree remains empty and the overhead is reduced to loading a cached null node pointer. Nevertheless, we might want to reconsider the augmented rbtree once the use of negative latency_nice will be more widlely deployed. At now, the different tests that I have done, have not shown improvements with augmented rbtree. Below are some hackbench results: 2 rbtrees augmented rbtree augmented rbtree sorted by vruntime sorted by wakeup_vruntime sched pipe avg 26311,000 25976,667 25839,556 stdev 0,15 % 0,28 % 0,24 % vs tip 0,50 % -0,78 % -1,31 % hackbench 1 group avg 1,315 1,344 1,359 stdev 0,88 % 1,55 % 1,82 % vs tip -0,47 % -2,68 % -3,87 % hackbench 4 groups avg 1,339 1,365 1,367 stdev 2,39 % 2,26 % 3,58 % vs tip -0,08 % -2,01 % -2,22 % hackbench 8 groups avg 1,233 1,286 1,301 stdev 0,74 % 1,09 % 1,52 % vs tip 0,29 % -4,05 % -5,27 % hackbench 16 groups avg 1,268 1,313 1,319 stdev 0,85 % 1,60 % 0,68 % vs tip -0,02 % -3,56 % -4,01 % [1] https://source.android.com/docs/core/debug/eval_perf#touchlatency Change since v8: - Rename get_sched_latency by get_sleep_latency - move latency nice defines in sched/prio.h and fix latency_prio init value - Fix typo and comments Change since v7: - Replaced se->on_latency by using RB_CLEAR_NODE() and RB_EMPTY_NODE() - Clarify the limit behavior fo the cgroup cpu.latenyc_nice Change since v6: - Fix compilation error for !CONFIG_SCHED_DEBUG Change since v5: - Add patch 1 to fix unfairness for low prio task. This has been discovered while studying Youssef's tests results with latency nice which were hitting the same problem. - Fixed latency_offset computation to take into account GENTLE_FAIR_SLEEPERS. This has diseappeared with v2and has been raised by Youssef's tests. - Reworked and optimized how latency_offset in used to check for preempting current task at wakeup and tick. This cover more cases too. - Add patch 9 to remove check_preempt_from_others() which is not needed anymore with the rb tree. Change since v4: - Removed permission checks to set latency priority. This enables user without elevated privilege like audio application to set their latency priority as requested by Tim. - Removed cpu.latency and replaced it by cpu.latency.nice so we keep a generic interface not tied to latency_offset which can be used to implement other latency features. - Added an entry in Documentation/admin-guide/cgroup-v2.rst to describe cpu.latency.nice. - Fix some typos. Change since v3: - Fix 2 compilation warnings raised by kernel test robot Change since v2: - Set a latency_offset field instead of saving a weight and computing it on the fly. - Make latency_offset available for task group: cpu.latency - Fix some corner cases to make latency sensitive tasks schedule first and add a rb tree for latency sensitive task. Change since v1: - fix typo - move some codes in the right patch to make bisect happy - simplify and fixed how the weight is computed - added support of sched core patch 7 Parth Shah (3): sched: Introduce latency-nice as a per-task attribute sched/core: Propagate parent task's latency requirements to the child task sched: Allow sched_{get,set}attr to change latency_nice of the task Vincent Guittot (6): sched/fair: fix unfairness at wakeup sched/fair: Take into account latency priority at wakeup sched/fair: Add sched group latency support sched/core: Support latency priority with sched core sched/fair: Add latency list sched/fair: remove check_preempt_from_others Documentation/admin-guide/cgroup-v2.rst | 10 ++ include/linux/sched.h | 4 + include/linux/sched/prio.h | 27 +++ include/uapi/linux/sched.h | 4 +- include/uapi/linux/sched/types.h | 19 +++ init/init_task.c | 1 + kernel/sched/core.c | 106 ++++++++++++ kernel/sched/debug.c | 1 + kernel/sched/fair.c | 209 ++++++++++++++++++++---- kernel/sched/sched.h | 45 ++++- tools/include/uapi/linux/sched.h | 4 +- 11 files changed, 394 insertions(+), 36 deletions(-) Tested-by: K Prateek Nayak