From patchwork Tue Nov 29 14:47:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neil Armstrong X-Patchwork-Id: 2373 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp383704wrr; Tue, 29 Nov 2022 06:49:43 -0800 (PST) X-Google-Smtp-Source: AA0mqf508VXTJdY5bN/qg7/wGiIGXnB255c774/X/Oa1dB1BgDfNE/FlzVLqmsQexRa8LGeS6Gu0 X-Received: by 2002:a05:6a00:e89:b0:56b:e64c:5c7e with SMTP id bo9-20020a056a000e8900b0056be64c5c7emr58408350pfb.18.1669733383142; Tue, 29 Nov 2022 06:49:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669733383; cv=none; d=google.com; s=arc-20160816; b=V7mUj+aG4pm80E4kbSa0NI9raE/b+M1E/wgp5seBnBJbf23EVE/RqAzrG6QpCkBHLW RU2xxdHjfPSTtIpYL367fFLtU2gRHh2WXsnA6aTakR0BVEWgERxVAYKbiUeQIwPwc8lz 4SaiumbWGwE+Hedd0HjcO/yqY+3EobAOZZjWcxi0I4CITJhfMKxQFqW4ITqVhZiEq5wq lFz+L/m7VCOHPAQNmQI2tQBvqKLUejDasZrd6C/blgTwwwpMNkY2kO/47YFkfC+3cmdn A5clKpS7sbwVxkZVUljR+AqunYsr2ejJmWi6rdPwbqTyGcHkwOoHKQGXn845r80y22+V Pq8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:message-id:date:from :content-transfer-encoding:mime-version:subject:dkim-signature; bh=kifJd8r2Xa1q+K0dxzGSjChYAfuX1ssub9et6+nGfyA=; b=UiTju9qUVbunelMQJm+207BCuJGJRUnO02YJpT/YitJTIoQHk1FtLtfLn0ynAGNsSx 4f7IGagpjC6pRycdS9ySlNpxfPXWUHMrC5YiFX4X3DvZvS+KeNEeT1Y+h9C1UhKvZJes ZO7SxfxpDw1DiPJTs2J+/icVmoa3cBNTzHJ5r4KqH3MgPeByT1F8jij4ZEJp+NcJ4hUp UvjoiDzx1B8MEIj70nP+Eu0YCi2p672+o7fw1Z/C8excqidxt8xAVw8+0wNtFiwD22HH QVggOvGzRo9crWnk+7I/JNGkoRJwc1krpNX/WZMoy9sdnSl2YTNyLzoURP6EI9U2TBR3 XlBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dChll5z5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s23-20020a170902989700b0018962fa3890si12465126plp.601.2022.11.29.06.49.29; Tue, 29 Nov 2022 06:49:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dChll5z5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235790AbiK2OrK (ORCPT + 99 others); Tue, 29 Nov 2022 09:47:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235412AbiK2OrH (ORCPT ); Tue, 29 Nov 2022 09:47:07 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB90358BEB for ; Tue, 29 Nov 2022 06:47:04 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id m7-20020a05600c090700b003cf8a105d9eso10983406wmp.5 for ; Tue, 29 Nov 2022 06:47:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:message-id:date:from:content-transfer-encoding:mime-version :subject:from:to:cc:subject:date:message-id:reply-to; bh=kifJd8r2Xa1q+K0dxzGSjChYAfuX1ssub9et6+nGfyA=; b=dChll5z5Y5NlSI5MIwkb56C1byWbdDhw5sfw0hWQweOzWb315QmrF7ZsQNBydiL/Es g6KdP2sjNwoAXznEhddww57/tLTot5VL7d4DF0Zvz9vPwn3lVU9U1iByOtmlB4VXyPGC EGCmxK36DDUO/OmQMwsol6duRdnkyx/7+D81pSxCWxjlhfMNxptUhobRvE6mCIOdfpDt mZtOhHIyX9gQYjyClgwT34s79zegD76CGZQqaMgFXQR2uUkzssgOm9LJNKvsy85d5HUH 5xcP/ykkhOpMy2uUiords+k4ktBDOvW6ZS3XRR1pXXia5IMXIrAK0escOcmMdTyCfOj5 QJwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:message-id:date:from:content-transfer-encoding:mime-version :subject:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kifJd8r2Xa1q+K0dxzGSjChYAfuX1ssub9et6+nGfyA=; b=rfyPJ6lZNORyL4FDXqDCGKwEihaq7VGb7rpttdkkhJd+GuYj52h1gZL7j5LzctTCq6 8ZWkZho/c7aW7OtCgyz0E6RLUEnntF7l7GB+EKGKfvchneO5cksUxK9PkpbY0ihwmOOM dUx/g6gxUpnMpfuSsyhKbOHBmgiZzric8BVIzYsTaQwn5CH/4j1VCvb2EA61IqQwQEr5 /hD1gDaSUn9kR3hE3APzdAzh06iTokdJ/h4BSWiQyKrxRR07LdwqSYByzKcbhNzdwzLb I8AgUQvJuoind7NbfMsjADFa2r0dk0pHgc3Kfzh1lmhDOvftsTHLtNL0CZWxWdYRzMeV ISFA== X-Gm-Message-State: ANoB5pnXwQudF94PJAE5oMdiJSfRbp7V9SGQRYL2AghsJ/II9vEaYEhg d2wdv2XxrPqeVng0OI+YtGWOkg== X-Received: by 2002:a1c:4b12:0:b0:3cf:90de:7724 with SMTP id y18-20020a1c4b12000000b003cf90de7724mr45158928wma.18.1669733223362; Tue, 29 Nov 2022 06:47:03 -0800 (PST) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:52eb:f6ff:feb3:451a]) by smtp.gmail.com with ESMTPSA id b10-20020adfee8a000000b00241dec4ad16sm13717792wro.96.2022.11.29.06.47.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Nov 2022 06:47:02 -0800 (PST) Subject: [PATCH v3 0/6] soc: qcom: add support for the I2C Master Hub MIME-Version: 1.0 X-b4-tracking: H4sIAGQbhmMC/52NzQ7CIBAGX6Xh7BpA+oMn38N4WFosJAUMtCSm6bu78ebV02Y2+WZ2Vmz2trBrs7 Nsqy8+RYLLqWGjwzhb8BMxk1xKIYSCiDmUNac4QwlD23LYXsQWA3g5QsCy2gxuM6AU9k8jtOpby8hn sFgwGePoyBi3ZaGn82VN+f3tV0Hn/k+qCuDQKaW04B0KNdwWT+t0TnlmD8pU+bdakhpxQuy07o38VR /H8QHEAKbnQwEAAA== From: Neil Armstrong Date: Tue, 29 Nov 2022 15:47:00 +0100 Message-Id: <20221114-narmstrong-sm8550-upstream-i2c-master-hub-v3-0-f6a20dc9996e@linaro.org> To: Bjorn Andersson , Rob Herring , Andy Gross , Krzysztof Kozlowski Cc: Krzysztof Kozlowski , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, Konrad Dybcio , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong X-Mailer: b4 0.10.1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750842351764919361?= X-GMAIL-MSGID: =?utf-8?q?1750842351764919361?= The I2C Master Hub is a stripped down version of the GENI Serial Engine QUP Wrapper Controller but only supporting I2C serial engines without DMA support. The I2C Master Hub only supports a variant of the I2C serial engine with: - a separate "core" clock - no DMA support - non discoverable fixed FIFO size Since DMA isn't supported, the wrapper doesn't need the Master AHB clock and the iommus property neither. This patchset adds the bindings changes to the QUPv3 wrapper and I2C serial element bindings to reflect the different resources requirements. In order to reuse the QUPv3 wrapper and I2C serial element driver support, the I2C Master Hub requirements are expressed in new desc structs passed as device match data. To: Andy Gross To: Bjorn Andersson Cc: Konrad Dybcio To: Rob Herring To: Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-i2c@vger.kernel.org Signed-off-by: Neil Armstrong --- Changes in v3: - Fixed check of DT clocks count on geni-se.c with Kondar help - Added Krzysztof's Reviewed-by on patches 1 & 2 - Link to v2: https://lore.kernel.org/r/20221114-narmstrong-sm8550-upstream-i2c-master-hub-v2-0-aadaa6997b28@linaro.org Changes in v2: - Fixed all commits messages to remove "This" and fix grammar - Fixed the bindings by moving the if in allOf:if - Fixed the bindings by adding minItems: & maxItems: instead of true - Added a warning about clock count in patch 3 - Added Reviewed-by from Konrad on patches 3, 4 & 5 - Link to v1: https://lore.kernel.org/r/20221114-narmstrong-sm8550-upstream-i2c-master-hub-v1-0-64449106a148@linaro.org --- Neil Armstrong (6): dt-bindings: qcom: geni-se: document I2C Master Hub wrapper variant dt-bindings: i2c: qcom-geni: document I2C Master Hub serial I2C engine soc: qcom: geni-se: add desc struct to specify clocks from device match data soc: qcom: geni-se: add support for I2C Master Hub wrapper variant i2c: qcom-geni: add desc struct to prepare support for I2C Master Hub variant i2c: qcom-geni: add support for I2C Master Hub variant .../bindings/i2c/qcom,i2c-geni-qcom.yaml | 64 +++++++++++++++--- .../devicetree/bindings/soc/qcom/qcom,geni-se.yaml | 44 ++++++++++-- drivers/i2c/busses/i2c-qcom-geni.c | 58 +++++++++++++++- drivers/soc/qcom/qcom-geni-se.c | 79 ++++++++++++++++++---- 4 files changed, 212 insertions(+), 33 deletions(-) --- base-commit: 094226ad94f471a9f19e8f8e7140a09c2625abaa change-id: 20221114-narmstrong-sm8550-upstream-i2c-master-hub-44a7fb19475e Best regards,