mbox series

[0/7] vdpa/mlx5: Add debugfs subtree and fixes

Message ID 20221113134442.152695-1-elic@nvidia.com
Headers
Series vdpa/mlx5: Add debugfs subtree and fixes |

Message

Eli Cohen Nov. 13, 2022, 1:44 p.m. UTC 
  This series is a resend of previously sent patch list. It adds a few
fixes so I treat as a v0 of a new series.

It adds a kernel config param CONFIG_MLX5_VDPA_STEERING_DEBUG that when
eabled allows to read rx unicast and multicast counters per tagged or untagged traffic.

Examples:
$ cat /sys/kernel/debug/mlx5/mlx5_core.sf.1/vdpa-0/rx/untagged/mcast/packets
$ cat /sys/kernel/debug/mlx5/mlx5_core.sf.1/vdpa-0/rx/untagged/ucast/bytes


Eli Cohen (7):
  vdpa/mlx5: Fix rule forwarding VLAN to TIR
  vdpa/mlx5: Fix wrong mac address deletion
  vdpa/mlx5: Move some definitions to a new header file
  vdpa/mlx5: Add debugfs subtree
  vdpa/mlx5: Add RX counters to debugfs
  vdpa/mlx5: Avoid using reslock in event_handler
  vdpa/mlx5: Avoid overwriting CVQ iotlb

 drivers/vdpa/Kconfig               |  12 ++
 drivers/vdpa/mlx5/Makefile         |   2 +-
 drivers/vdpa/mlx5/core/mlx5_vdpa.h |   5 +-
 drivers/vdpa/mlx5/core/mr.c        |  44 ++---
 drivers/vdpa/mlx5/net/debug.c      | 152 ++++++++++++++++++
 drivers/vdpa/mlx5/net/mlx5_vnet.c  | 248 ++++++++++++++---------------
 drivers/vdpa/mlx5/net/mlx5_vnet.h  |  94 +++++++++++
 7 files changed, 411 insertions(+), 146 deletions(-)
 create mode 100644 drivers/vdpa/mlx5/net/debug.c
 create mode 100644 drivers/vdpa/mlx5/net/mlx5_vnet.h

Comments

Michael S. Tsirkin Nov. 13, 2022, 1:51 p.m. UTC | #1 
On Sun, Nov 13, 2022 at 03:44:35PM +0200, Eli Cohen wrote:
> This series is a resend of previously sent patch list. It adds a few
> fixes so I treat as a v0 of a new series.
> 
> It adds a kernel config param CONFIG_MLX5_VDPA_STEERING_DEBUG that when
> eabled allows to read rx unicast and multicast counters per tagged or untagged traffic.
> 
> Examples:
> $ cat /sys/kernel/debug/mlx5/mlx5_core.sf.1/vdpa-0/rx/untagged/mcast/packets
> $ cat /sys/kernel/debug/mlx5/mlx5_core.sf.1/vdpa-0/rx/untagged/ucast/bytes


Thanks!
Is this patchset intended for 6.2 then?

> 
> Eli Cohen (7):
>   vdpa/mlx5: Fix rule forwarding VLAN to TIR
>   vdpa/mlx5: Fix wrong mac address deletion
>   vdpa/mlx5: Move some definitions to a new header file
>   vdpa/mlx5: Add debugfs subtree
>   vdpa/mlx5: Add RX counters to debugfs
>   vdpa/mlx5: Avoid using reslock in event_handler
>   vdpa/mlx5: Avoid overwriting CVQ iotlb
> 
>  drivers/vdpa/Kconfig               |  12 ++
>  drivers/vdpa/mlx5/Makefile         |   2 +-
>  drivers/vdpa/mlx5/core/mlx5_vdpa.h |   5 +-
>  drivers/vdpa/mlx5/core/mr.c        |  44 ++---
>  drivers/vdpa/mlx5/net/debug.c      | 152 ++++++++++++++++++
>  drivers/vdpa/mlx5/net/mlx5_vnet.c  | 248 ++++++++++++++---------------
>  drivers/vdpa/mlx5/net/mlx5_vnet.h  |  94 +++++++++++
>  7 files changed, 411 insertions(+), 146 deletions(-)
>  create mode 100644 drivers/vdpa/mlx5/net/debug.c
>  create mode 100644 drivers/vdpa/mlx5/net/mlx5_vnet.h
> 
> -- 
> 2.38.1
Eli Cohen Nov. 13, 2022, 1:56 p.m. UTC | #2 
> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Sunday, 13 November 2022 15:52
> To: Eli Cohen <elic@nvidia.com>
> Cc: jasowang@redhat.com; linux-kernel@vger.kernel.org;
> virtualization@lists.linux-foundation.org; si-wei.liu@oracle.com;
> eperezma@redhat.com; lulu@redhat.com
> Subject: Re: [PATCH 0/7] vdpa/mlx5: Add debugfs subtree and fixes
> 
> On Sun, Nov 13, 2022 at 03:44:35PM +0200, Eli Cohen wrote:
> > This series is a resend of previously sent patch list. It adds a few
> > fixes so I treat as a v0 of a new series.
> >
> > It adds a kernel config param CONFIG_MLX5_VDPA_STEERING_DEBUG that
> when
> > eabled allows to read rx unicast and multicast counters per tagged or
> untagged traffic.
> >
> > Examples:
> > $ cat /sys/kernel/debug/mlx5/mlx5_core.sf.1/vdpa-
> 0/rx/untagged/mcast/packets
> > $ cat /sys/kernel/debug/mlx5/mlx5_core.sf.1/vdpa-
> 0/rx/untagged/ucast/bytes
> 
> 
> Thanks!
> Is this patchset intended for 6.2 then?
> 

The debugfs part can go to 6.2 but maybe the fixes should go to 6.1.

> >
> > Eli Cohen (7):
> >   vdpa/mlx5: Fix rule forwarding VLAN to TIR
> >   vdpa/mlx5: Fix wrong mac address deletion
> >   vdpa/mlx5: Move some definitions to a new header file
> >   vdpa/mlx5: Add debugfs subtree
> >   vdpa/mlx5: Add RX counters to debugfs
> >   vdpa/mlx5: Avoid using reslock in event_handler
> >   vdpa/mlx5: Avoid overwriting CVQ iotlb
> >
> >  drivers/vdpa/Kconfig               |  12 ++
> >  drivers/vdpa/mlx5/Makefile         |   2 +-
> >  drivers/vdpa/mlx5/core/mlx5_vdpa.h |   5 +-
> >  drivers/vdpa/mlx5/core/mr.c        |  44 ++---
> >  drivers/vdpa/mlx5/net/debug.c      | 152 ++++++++++++++++++
> >  drivers/vdpa/mlx5/net/mlx5_vnet.c  | 248 ++++++++++++++---------------
> >  drivers/vdpa/mlx5/net/mlx5_vnet.h  |  94 +++++++++++
> >  7 files changed, 411 insertions(+), 146 deletions(-)
> >  create mode 100644 drivers/vdpa/mlx5/net/debug.c
> >  create mode 100644 drivers/vdpa/mlx5/net/mlx5_vnet.h
> >
> > --
> > 2.38.1
Michael S. Tsirkin Nov. 13, 2022, 1:57 p.m. UTC | #3 
On Sun, Nov 13, 2022 at 01:56:00PM +0000, Eli Cohen wrote:
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Sunday, 13 November 2022 15:52
> > To: Eli Cohen <elic@nvidia.com>
> > Cc: jasowang@redhat.com; linux-kernel@vger.kernel.org;
> > virtualization@lists.linux-foundation.org; si-wei.liu@oracle.com;
> > eperezma@redhat.com; lulu@redhat.com
> > Subject: Re: [PATCH 0/7] vdpa/mlx5: Add debugfs subtree and fixes
> > 
> > On Sun, Nov 13, 2022 at 03:44:35PM +0200, Eli Cohen wrote:
> > > This series is a resend of previously sent patch list. It adds a few
> > > fixes so I treat as a v0 of a new series.
> > >
> > > It adds a kernel config param CONFIG_MLX5_VDPA_STEERING_DEBUG that
> > when
> > > eabled allows to read rx unicast and multicast counters per tagged or
> > untagged traffic.
> > >
> > > Examples:
> > > $ cat /sys/kernel/debug/mlx5/mlx5_core.sf.1/vdpa-
> > 0/rx/untagged/mcast/packets
> > > $ cat /sys/kernel/debug/mlx5/mlx5_core.sf.1/vdpa-
> > 0/rx/untagged/ucast/bytes
> > 
> > 
> > Thanks!
> > Is this patchset intended for 6.2 then?
> > 
> 
> The debugfs part can go to 6.2 but maybe the fixes should go to 6.1.


Tat's fine - do they apply cleanly if I just drop 4/7?

> > >
> > > Eli Cohen (7):
> > >   vdpa/mlx5: Fix rule forwarding VLAN to TIR
> > >   vdpa/mlx5: Fix wrong mac address deletion
> > >   vdpa/mlx5: Move some definitions to a new header file
> > >   vdpa/mlx5: Add debugfs subtree
> > >   vdpa/mlx5: Add RX counters to debugfs
> > >   vdpa/mlx5: Avoid using reslock in event_handler
> > >   vdpa/mlx5: Avoid overwriting CVQ iotlb
> > >
> > >  drivers/vdpa/Kconfig               |  12 ++
> > >  drivers/vdpa/mlx5/Makefile         |   2 +-
> > >  drivers/vdpa/mlx5/core/mlx5_vdpa.h |   5 +-
> > >  drivers/vdpa/mlx5/core/mr.c        |  44 ++---
> > >  drivers/vdpa/mlx5/net/debug.c      | 152 ++++++++++++++++++
> > >  drivers/vdpa/mlx5/net/mlx5_vnet.c  | 248 ++++++++++++++---------------
> > >  drivers/vdpa/mlx5/net/mlx5_vnet.h  |  94 +++++++++++
> > >  7 files changed, 411 insertions(+), 146 deletions(-)
> > >  create mode 100644 drivers/vdpa/mlx5/net/debug.c
> > >  create mode 100644 drivers/vdpa/mlx5/net/mlx5_vnet.h
> > >
> > > --
> > > 2.38.1
>
Eli Cohen Nov. 13, 2022, 2:01 p.m. UTC | #4 
> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Sunday, 13 November 2022 15:58
> To: Eli Cohen <elic@nvidia.com>
> Cc: jasowang@redhat.com; linux-kernel@vger.kernel.org;
> virtualization@lists.linux-foundation.org; si-wei.liu@oracle.com;
> eperezma@redhat.com; lulu@redhat.com
> Subject: Re: [PATCH 0/7] vdpa/mlx5: Add debugfs subtree and fixes
> 
> On Sun, Nov 13, 2022 at 01:56:00PM +0000, Eli Cohen wrote:
> > > From: Michael S. Tsirkin <mst@redhat.com>
> > > Sent: Sunday, 13 November 2022 15:52
> > > To: Eli Cohen <elic@nvidia.com>
> > > Cc: jasowang@redhat.com; linux-kernel@vger.kernel.org;
> > > virtualization@lists.linux-foundation.org; si-wei.liu@oracle.com;
> > > eperezma@redhat.com; lulu@redhat.com
> > > Subject: Re: [PATCH 0/7] vdpa/mlx5: Add debugfs subtree and fixes
> > >
> > > On Sun, Nov 13, 2022 at 03:44:35PM +0200, Eli Cohen wrote:
> > > > This series is a resend of previously sent patch list. It adds a few
> > > > fixes so I treat as a v0 of a new series.
> > > >
> > > > It adds a kernel config param CONFIG_MLX5_VDPA_STEERING_DEBUG
> that
> > > when
> > > > eabled allows to read rx unicast and multicast counters per tagged or
> > > untagged traffic.
> > > >
> > > > Examples:
> > > > $ cat /sys/kernel/debug/mlx5/mlx5_core.sf.1/vdpa-
> > > 0/rx/untagged/mcast/packets
> > > > $ cat /sys/kernel/debug/mlx5/mlx5_core.sf.1/vdpa-
> > > 0/rx/untagged/ucast/bytes
> > >
> > >
> > > Thanks!
> > > Is this patchset intended for 6.2 then?
> > >
> >
> > The debugfs part can go to 6.2 but maybe the fixes should go to 6.1.
> 
> 
> Tat's fine - do they apply cleanly if I just drop 4/7?

Yes, just checked 0002, 0003, and 0007 fixes apply cleanly
> 
> > > >
> > > > Eli Cohen (7):
> > > >   vdpa/mlx5: Fix rule forwarding VLAN to TIR
> > > >   vdpa/mlx5: Fix wrong mac address deletion
> > > >   vdpa/mlx5: Move some definitions to a new header file
> > > >   vdpa/mlx5: Add debugfs subtree
> > > >   vdpa/mlx5: Add RX counters to debugfs
> > > >   vdpa/mlx5: Avoid using reslock in event_handler
> > > >   vdpa/mlx5: Avoid overwriting CVQ iotlb
> > > >
> > > >  drivers/vdpa/Kconfig               |  12 ++
> > > >  drivers/vdpa/mlx5/Makefile         |   2 +-
> > > >  drivers/vdpa/mlx5/core/mlx5_vdpa.h |   5 +-
> > > >  drivers/vdpa/mlx5/core/mr.c        |  44 ++---
> > > >  drivers/vdpa/mlx5/net/debug.c      | 152 ++++++++++++++++++
> > > >  drivers/vdpa/mlx5/net/mlx5_vnet.c  | 248 ++++++++++++++---------------
> > > >  drivers/vdpa/mlx5/net/mlx5_vnet.h  |  94 +++++++++++
> > > >  7 files changed, 411 insertions(+), 146 deletions(-)
> > > >  create mode 100644 drivers/vdpa/mlx5/net/debug.c
> > > >  create mode 100644 drivers/vdpa/mlx5/net/mlx5_vnet.h
> > > >
> > > > --
> > > > 2.38.1
> >