mbox series

[v7,0/3] xhci: tegra: USB2 pad power controls

Message ID 20221111101813.32482-1-jilin@nvidia.com
Headers
Series xhci: tegra: USB2 pad power controls |

Message

Jim Lin Nov. 11, 2022, 10:18 a.m. UTC 
  1. Export symbol on xhci_hub_control
2. Add hub_control to xhci_driver_overrides
3. Program USB2 pad PD controls during port connect/disconnect, port
suspend/resume, and test mode, to reduce power consumption on
disconnect or suspend.

Patch
xhci: tegra: USB2 pad power controls
depends on
xhci: hub: export symbol on xhci_hub_control
xhci: Add hub_control to xhci_driver_overrides

Jim Lin (3):
  xhci: Add hub_control to xhci_driver_overrides
  xhci: hub: export symbol on xhci_hub_control
  xhci: tegra: USB2 pad power controls

 drivers/usb/host/xhci-hub.c   |   1 +
 drivers/usb/host/xhci-tegra.c | 125 ++++++++++++++++++++++++++++++++++
 drivers/usb/host/xhci.c       |   2 +
 drivers/usb/host/xhci.h       |   2 +
 4 files changed, 130 insertions(+)

Comments

Jon Hunter Jan. 6, 2023, 2:56 p.m. UTC | #1 
Hi Greg,

On 11/11/2022 10:18, Jim Lin wrote:
> 1. Export symbol on xhci_hub_control
> 2. Add hub_control to xhci_driver_overrides
> 3. Program USB2 pad PD controls during port connect/disconnect, port
> suspend/resume, and test mode, to reduce power consumption on
> disconnect or suspend.
> 
> Patch
> xhci: tegra: USB2 pad power controls
> depends on
> xhci: hub: export symbol on xhci_hub_control
> xhci: Add hub_control to xhci_driver_overrides
> 
> Jim Lin (3):
>    xhci: Add hub_control to xhci_driver_overrides
>    xhci: hub: export symbol on xhci_hub_control
>    xhci: tegra: USB2 pad power controls
> 
>   drivers/usb/host/xhci-hub.c   |   1 +
>   drivers/usb/host/xhci-tegra.c | 125 ++++++++++++++++++++++++++++++++++
>   drivers/usb/host/xhci.c       |   2 +
>   drivers/usb/host/xhci.h       |   2 +
>   4 files changed, 130 insertions(+)
> 


I have verified that this still applies cleanly on top of -next. Please 
let us know if this can be queued up for Linux v6.3?

Thanks
Jon
Greg KH Jan. 6, 2023, 3:25 p.m. UTC | #2 
On Fri, Jan 06, 2023 at 02:56:51PM +0000, Jon Hunter wrote:
> Hi Greg,
> 
> On 11/11/2022 10:18, Jim Lin wrote:
> > 1. Export symbol on xhci_hub_control
> > 2. Add hub_control to xhci_driver_overrides
> > 3. Program USB2 pad PD controls during port connect/disconnect, port
> > suspend/resume, and test mode, to reduce power consumption on
> > disconnect or suspend.
> > 
> > Patch
> > xhci: tegra: USB2 pad power controls
> > depends on
> > xhci: hub: export symbol on xhci_hub_control
> > xhci: Add hub_control to xhci_driver_overrides
> > 
> > Jim Lin (3):
> >    xhci: Add hub_control to xhci_driver_overrides
> >    xhci: hub: export symbol on xhci_hub_control
> >    xhci: tegra: USB2 pad power controls
> > 
> >   drivers/usb/host/xhci-hub.c   |   1 +
> >   drivers/usb/host/xhci-tegra.c | 125 ++++++++++++++++++++++++++++++++++
> >   drivers/usb/host/xhci.c       |   2 +
> >   drivers/usb/host/xhci.h       |   2 +
> >   4 files changed, 130 insertions(+)
> > 
> 
> 
> I have verified that this still applies cleanly on top of -next. Please let
> us know if this can be queued up for Linux v6.3?

Normally for xhci stuff I want it to go through Mathias for things that
are outside of just xhci-tegra.c.

thanks,

greg k-h
Mathias Nyman Jan. 9, 2023, 8:28 a.m. UTC | #3 
On 6.1.2023 17.25, Greg KH wrote:
> On Fri, Jan 06, 2023 at 02:56:51PM +0000, Jon Hunter wrote:
>> Hi Greg,
>>
>> On 11/11/2022 10:18, Jim Lin wrote:
>>> 1. Export symbol on xhci_hub_control
>>> 2. Add hub_control to xhci_driver_overrides
>>> 3. Program USB2 pad PD controls during port connect/disconnect, port
>>> suspend/resume, and test mode, to reduce power consumption on
>>> disconnect or suspend.
>>>
>>> Patch
>>> xhci: tegra: USB2 pad power controls
>>> depends on
>>> xhci: hub: export symbol on xhci_hub_control
>>> xhci: Add hub_control to xhci_driver_overrides
>>>
>>> Jim Lin (3):
>>>     xhci: Add hub_control to xhci_driver_overrides
>>>     xhci: hub: export symbol on xhci_hub_control
>>>     xhci: tegra: USB2 pad power controls
>>>
>>>    drivers/usb/host/xhci-hub.c   |   1 +
>>>    drivers/usb/host/xhci-tegra.c | 125 ++++++++++++++++++++++++++++++++++
>>>    drivers/usb/host/xhci.c       |   2 +
>>>    drivers/usb/host/xhci.h       |   2 +
>>>    4 files changed, 130 insertions(+)
>>>
>>
>>
>> I have verified that this still applies cleanly on top of -next. Please let
>> us know if this can be queued up for Linux v6.3?
> 
> Normally for xhci stuff I want it to go through Mathias for things that
> are outside of just xhci-tegra.c.

Looks good to me, can be picked up directly
Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>

Or I can add this to the series going to usb-next if that is preferred.

Thanks
Mathias


> 
> thanks,
> 
> greg k-h
Jon Hunter Jan. 16, 2023, 11:50 a.m. UTC | #4 
On 09/01/2023 08:28, Mathias Nyman wrote:
> On 6.1.2023 17.25, Greg KH wrote:
>> On Fri, Jan 06, 2023 at 02:56:51PM +0000, Jon Hunter wrote:
>>> Hi Greg,
>>>
>>> On 11/11/2022 10:18, Jim Lin wrote:
>>>> 1. Export symbol on xhci_hub_control
>>>> 2. Add hub_control to xhci_driver_overrides
>>>> 3. Program USB2 pad PD controls during port connect/disconnect, port
>>>> suspend/resume, and test mode, to reduce power consumption on
>>>> disconnect or suspend.
>>>>
>>>> Patch
>>>> xhci: tegra: USB2 pad power controls
>>>> depends on
>>>> xhci: hub: export symbol on xhci_hub_control
>>>> xhci: Add hub_control to xhci_driver_overrides
>>>>
>>>> Jim Lin (3):
>>>>     xhci: Add hub_control to xhci_driver_overrides
>>>>     xhci: hub: export symbol on xhci_hub_control
>>>>     xhci: tegra: USB2 pad power controls
>>>>
>>>>    drivers/usb/host/xhci-hub.c   |   1 +
>>>>    drivers/usb/host/xhci-tegra.c | 125 
>>>> ++++++++++++++++++++++++++++++++++
>>>>    drivers/usb/host/xhci.c       |   2 +
>>>>    drivers/usb/host/xhci.h       |   2 +
>>>>    4 files changed, 130 insertions(+)
>>>>
>>>
>>>
>>> I have verified that this still applies cleanly on top of -next. 
>>> Please let
>>> us know if this can be queued up for Linux v6.3?
>>
>> Normally for xhci stuff I want it to go through Mathias for things that
>> are outside of just xhci-tegra.c.
> 
> Looks good to me, can be picked up directly
> Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> 
> Or I can add this to the series going to usb-next if that is preferred.


I did not see this in -next yet.

Mathias, are you able to pick this up?

Thanks Jon
Greg KH Jan. 16, 2023, 12:23 p.m. UTC | #5 
On Mon, Jan 16, 2023 at 11:50:19AM +0000, Jon Hunter wrote:
> 
> On 09/01/2023 08:28, Mathias Nyman wrote:
> > On 6.1.2023 17.25, Greg KH wrote:
> > > On Fri, Jan 06, 2023 at 02:56:51PM +0000, Jon Hunter wrote:
> > > > Hi Greg,
> > > > 
> > > > On 11/11/2022 10:18, Jim Lin wrote:
> > > > > 1. Export symbol on xhci_hub_control
> > > > > 2. Add hub_control to xhci_driver_overrides
> > > > > 3. Program USB2 pad PD controls during port connect/disconnect, port
> > > > > suspend/resume, and test mode, to reduce power consumption on
> > > > > disconnect or suspend.
> > > > > 
> > > > > Patch
> > > > > xhci: tegra: USB2 pad power controls
> > > > > depends on
> > > > > xhci: hub: export symbol on xhci_hub_control
> > > > > xhci: Add hub_control to xhci_driver_overrides
> > > > > 
> > > > > Jim Lin (3):
> > > > >     xhci: Add hub_control to xhci_driver_overrides
> > > > >     xhci: hub: export symbol on xhci_hub_control
> > > > >     xhci: tegra: USB2 pad power controls
> > > > > 
> > > > >    drivers/usb/host/xhci-hub.c   |   1 +
> > > > >    drivers/usb/host/xhci-tegra.c | 125
> > > > > ++++++++++++++++++++++++++++++++++
> > > > >    drivers/usb/host/xhci.c       |   2 +
> > > > >    drivers/usb/host/xhci.h       |   2 +
> > > > >    4 files changed, 130 insertions(+)
> > > > > 
> > > > 
> > > > 
> > > > I have verified that this still applies cleanly on top of -next.
> > > > Please let
> > > > us know if this can be queued up for Linux v6.3?
> > > 
> > > Normally for xhci stuff I want it to go through Mathias for things that
> > > are outside of just xhci-tegra.c.
> > 
> > Looks good to me, can be picked up directly
> > Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> > 
> > Or I can add this to the series going to usb-next if that is preferred.
> 
> 
> I did not see this in -next yet.
> 
> Mathias, are you able to pick this up?

I will when I catch up with linux-usb patches this week, sorry for the
delay, too many fires this early in the year...