From patchwork Thu Nov 10 20:31:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Xu X-Patchwork-Id: 1468 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp364707wru; Thu, 10 Nov 2022 12:39:21 -0800 (PST) X-Google-Smtp-Source: AMsMyM7NvzSN/btYIFQgUH7pfyKNBQuU7N0jw41G9GqgAjr+EoqXdNG/+/q85kENckvPwioUPhNj X-Received: by 2002:a17:906:d286:b0:7ae:37a8:9b5c with SMTP id ay6-20020a170906d28600b007ae37a89b5cmr3565242ejb.241.1668112760982; Thu, 10 Nov 2022 12:39:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668112760; cv=none; d=google.com; s=arc-20160816; b=VoaFASX3kOF4IQ7Rg2U79H2OuNUxU51sWcfRz5H9lWzLZ+RAWKu8RlMmUskAFEbqBl 461swg/sL9f7y+rLK03y62A3eKTNOJRoSbPRkqeJI/w7OWd36ezBJGPXncIVNqvgKpGQ xbntEU0Y4oDMLnfQxn6vMEFzDETh2Xwmxeoht77D4ireG5IZVv0CGDwuvYrllEUoUqsO 7/GwrgQkJdNpy5k+UF+sDOQycxCEOd39bKQpIlaDHR6d45+nrK87GgNI1aB7vNMkpD2S fnMzKwn5m5XNxHWu4Mo2WW6SpzohgyRqEslYWEtYlCOGT9GkrahEjtvKqTQ5MlSQwi8q uyUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ubDOzq2ubfJnUIZlKZc1NgXFcoLakRaKWn8ZApn11x4=; b=sBaIBXrAILobtryKz+FlQ/KG/iOpBuVU3Fq3so/SPUPDyeyQSbIlMxnDYrWaWg2g4F vIGI84iz94+9nLxbYtKtMJjvLvLA4U90w3VhmM/49btMwZmmVukZ5Y/1xNoZ+D/rfr82 /jygI2ewjm0gmDz5pXRJ8siwQJrJSjbf1W4Xv4DJhk5OIOrXRcNgBUP4akdL0/SGuErx vZoFpHHaeeeMZKTtlc9i/ZxTfs4nl301lKc6PTdlZBPXYwJBwzfXGKkqDOKCfxfSU5/C 8sys7cujK+oIyyCx+GKfKph2pcnPJVP/ktA0UUozsKprH3ZaAgZkW9XNnzXZD5oF/5LR t8kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="hEdit3h/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wt13-20020a170906ee8d00b0073d9c29892csi220167ejb.939.2022.11.10.12.38.57; Thu, 10 Nov 2022 12:39:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="hEdit3h/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231878AbiKJUcn (ORCPT + 99 others); Thu, 10 Nov 2022 15:32:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231702AbiKJUcg (ORCPT ); Thu, 10 Nov 2022 15:32:36 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1986D1D330 for ; Thu, 10 Nov 2022 12:31:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668112296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ubDOzq2ubfJnUIZlKZc1NgXFcoLakRaKWn8ZApn11x4=; b=hEdit3h/fAoOj39puh9r8BV+rtVtMpzFdF1hfvDlio1vhlx/275y38rpEIy8+dOpe8G3i7 W7G94jZkuM6CctU6ehOLSIgIMYHNaueU8gqXB5BESQ4bIKCVtNPJoWWn0thIAp24SeegFF n8ZGwo3C1R7Cdd9dFYtHdYYHjrzpKhs= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-360-NHAxEnYBN8itLtkt8Hn-eg-1; Thu, 10 Nov 2022 15:31:35 -0500 X-MC-Unique: NHAxEnYBN8itLtkt8Hn-eg-1 Received: by mail-qk1-f198.google.com with SMTP id bk30-20020a05620a1a1e00b006fb2378c857so2241204qkb.18 for ; Thu, 10 Nov 2022 12:31:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ubDOzq2ubfJnUIZlKZc1NgXFcoLakRaKWn8ZApn11x4=; b=pnqz9M/YxD6sEs3uFKhJcD3uxKljezXVnZkZuXyXibezO8WHzBY3vr9b7pp8YERGt9 S3z3oYzACRuo9SrQdhqQjOw9vXMs75vYSsfSLypUKvLjAAupNnu/dpMK2xDXjGdo402b +W3rFp6t74hjN1wLkcdEqk/VDKvXk2/ofaWg+RUqCR32jrnj7NSQVQjlYrvfsKh6IxCk +cjQWJRkiYY80AH2pTAW9Q6ViSo6QktDp/sWQVj34ojC4lB/vku6QIqBiXepfK3qdDcx 3iFKRE1DQK+Tcasn5jlPLwOaq3/M3KpSofxYwS/UXA6uHrKT4BllPkiPxNBcvT6gUnat 1Kow== X-Gm-Message-State: ACrzQf2XSe4laJ2OmYRNa20jZmtOKQGLRKKB/oZ5tb5UR5WpVpbvOBlg hdT48riAYOKiR2ib4dhUiCAyl/hOO87HMijKKn6IVUM7cIOtYisN1hM8azBNNl09y8OEk+nPwuU XpEQyhUo53BF+v398x1pvJYOwxCYH4nheOfB7JfliJOsPXJAnd52CZ0rtk1WIrqWeqvhl8a4lKw == X-Received: by 2002:a05:620a:2205:b0:6fa:3043:8898 with SMTP id m5-20020a05620a220500b006fa30438898mr1727181qkh.190.1668112294389; Thu, 10 Nov 2022 12:31:34 -0800 (PST) X-Received: by 2002:a05:620a:2205:b0:6fa:3043:8898 with SMTP id m5-20020a05620a220500b006fa30438898mr1727157qkh.190.1668112294088; Thu, 10 Nov 2022 12:31:34 -0800 (PST) Received: from x1n.redhat.com (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id i1-20020ac860c1000000b00399edda03dfsm123588qtm.67.2022.11.10.12.31.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 12:31:33 -0800 (PST) From: Peter Xu To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: peterx@redhat.com, Andrea Arcangeli , Axel Rasmussen , Ives van Hoorne , Nadav Amit , Andrew Morton , Mike Rapoport Subject: [PATCH v2 0/2] mm/migrate: Fix writable pte for read migration entry Date: Thu, 10 Nov 2022 15:31:30 -0500 Message-Id: <20221110203132.1498183-1-peterx@redhat.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749122857924924147?= X-GMAIL-MSGID: =?utf-8?q?1749143006695200242?= v2: - Replace WARN_ON_ONCE with VM_WARN_ON_ONCE in patch 2 [Nadav] This comes from a report from Ives on using uffd-wp on shmem. More information can be found in patch 1 commit message. Patch 2 added some more sanity check when walking pgtables and when we convert the ptes into other forms e.g. for migration and swap. It will make the error trigger even earlier than the user could notice, meanwhile nail down the case if it's a wrong pgtable setup. Ives, I only attached the reported-by tag for you but not tested-by because the fix patch (patch 1) has a slight change compared to what I sent you before, but hopefully it should also work for you. If you want, feel free to reply directly here if the patch also works for you. We probably need patch 1 for stable (5.19+). Please have a look, thanks. Peter Xu (2): mm/migrate: Fix read-only page got writable when recover pte mm/uffd: Sanity check write bit for uffd-wp protected ptes arch/x86/include/asm/pgtable.h | 16 +++++++++++++++- mm/migrate.c | 8 +++++++- 2 files changed, 22 insertions(+), 2 deletions(-)