| Message ID | 20221110174056.393697-1-jose.exposito89@gmail.com |
|---|---|
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp285182wru;
Thu, 10 Nov 2022 09:49:58 -0800 (PST)
X-Google-Smtp-Source:
AMsMyM4A8ZS6Vxdq+ARyoUmnVrexmL5hcnGpRJUKeIX1mvmrZcbaeoIjmO4+zdwlx0vfZA1Tfjg2
X-Received: by 2002:a63:b0d:0:b0:46f:cec6:8805 with SMTP id
13-20020a630b0d000000b0046fcec68805mr3009456pgl.612.1668102598119;
Thu, 10 Nov 2022 09:49:58 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1668102598; cv=none;
d=google.com; s=arc-20160816;
b=pjuB0QrqA4j/UZzLH3vGJFBNdtNKpD6xhMifSFkisYnWV0rPix4yXykeRx5dmyksXD
Sx6Y2jrCKl3tr/kzfd30QyCmpV61Gi5GOota72XoCSCkuNIEnWu2FpfaAPf298CE0iO2
ltJ+/pVHr9TMDX54uhnBTr5X3NSi2XVUIhrtX52a7nBENQgDQBZ/mTENSq/FsV8jVqGx
LDnaKmWnVlGz7XjpAk0dcTFyKy7nararIcFmLajx/8cYGzXj5W1UalFGaxQi+kZ/YbIt
1hNlnFFJ0khmM+6hMk345ka7YVBocG8p+LT9UKvmvZgHq4SRAbi/ROmLyP+/xBuKcgMU
n/JQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=Up6hiDVLuWAaCEN91nYS7vd27XRu7U8JIDCkwO+t6lI=;
b=CI20WRL4++8E0oYjWZENiM45LbBVWljWU4NCzj8nXYGORySbEfAU4QDlyYgGMQ8Boq
dleawJSC0spBZxOMF+LMYLijoN1ZQifFxVvyM0ylQrV+e4vH8vQxoCJ9kFGi0hWvdYUS
61j5ugEwalFsR+uayGtgZqKIdJX/MVODJRBzIm4bMxo/p8/myVEslFuJpiuQb8eEKaz+
KYjGj4mNto+YX6ocegRoFJ37pR2kvJUMIeCBmQZyAORPEt2w1w1NyW92e8TAuZqjeo8e
UHXchGxWX446YM6XPCWUjwd09VdraRZtvmHrEknAiNyk+HYhGJhC8wyzjAVrzl2oYlfA
JwmA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@gmail.com header.s=20210112 header.b=E0uv4fSb;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
z5-20020a636505000000b0046eda1d5784si20326304pgb.462.2022.11.10.09.49.43;
Thu, 10 Nov 2022 09:49:58 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@gmail.com header.s=20210112 header.b=E0uv4fSb;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230411AbiKJRlE (ORCPT <rfc822;winker.wchi@gmail.com>
+ 99 others); Thu, 10 Nov 2022 12:41:04 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56920 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229757AbiKJRlB (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 10 Nov 2022 12:41:01 -0500
Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com
[IPv6:2a00:1450:4864:20::429])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C821627FD8;
Thu, 10 Nov 2022 09:41:00 -0800 (PST)
Received: by mail-wr1-x429.google.com with SMTP id v1so3303146wrt.11;
Thu, 10 Nov 2022 09:41:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20210112;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=Up6hiDVLuWAaCEN91nYS7vd27XRu7U8JIDCkwO+t6lI=;
b=E0uv4fSb9P0wlitTRStqfRsf0aV2OKoYbr14lqt/oMRU+SON8yHHC1Jk85u31a8szc
deN20WYp7dTMccJoFy1hk7/ZZ23WxWDYLAV3HGv7nelChydO9rkmKHkzlUJJC5ZPjg9X
se5IXrPIGDaZ9DfmfOFYaklSCcfxulgcauEAIXJpg/RRoOjYkHnrUPXv76g7c7YFFqVz
b310a6EnhQf2R1ekUr9quG72BQ+EcCx9RZVCUTXEq8rHGzNUYlYbT9Vr30ovG2ksBAVL
3XuKvcoRuTMyQuwvffx01qnVS4rZuq0hm9nAbeX0jF4MKTwFkva6BV26wtY6jt6s2co8
OE0Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=Up6hiDVLuWAaCEN91nYS7vd27XRu7U8JIDCkwO+t6lI=;
b=chqw6jA+QCF+kM77MVmwowI3wSCNK5f37BzEkmH8MdjGyYm6l/mVvurFjjhKkkglOs
GkHwTvhmoLsyAmVBiFvkQjhJOETtQahRe3mxkVd/FFYd85D4LQpWn5wFotSanx3vDaH2
iKGooo4PMi7g5bjl79g9zevIali/inOVBUpjHXVscxm+lvB9g5BeYJ8uiIkBNmlcZ0lh
Q/fCaPvgYFLFJ6J3cM4Txykzq6ZAiTwemsBHpEW//MxVY6dueIl+hA4qbTwYle6cQ1WX
ucQOdN5UUnFRkCR+G/NrkkMVJsTG65p2G4V2JBhGdgrEAwnps0Qqz1ItXrc/1djyaiCF
YPSA==
X-Gm-Message-State: ANoB5pnB9yElhs5kipffc4zWkokK4366zadIQSFhkqBHa2icc+WrMKMN
CrquQVqF+AdpWTBC4/wNuYJyYdH8TF5gEg==
X-Received: by 2002:a5d:6248:0:b0:23e:245b:edf1 with SMTP id
m8-20020a5d6248000000b0023e245bedf1mr676186wrv.142.1668102059257;
Thu, 10 Nov 2022 09:40:59 -0800 (PST)
Received: from localhost.localdomain ([94.73.35.109])
by smtp.gmail.com with ESMTPSA id
n10-20020a5d420a000000b0023682011c1dsm16268026wrq.104.2022.11.10.09.40.58
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 10 Nov 2022 09:40:58 -0800 (PST)
From: =?utf-8?b?Sm9zw6kgRXhww7NzaXRv?= <jose.exposito89@gmail.com>
To: jikos@kernel.org
Cc: benjamin.tissoires@redhat.com, openglfreak@googlemail.com,
alex@alexyzhang.dev, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org,
=?utf-8?b?Sm9zw6kgRXhww7NzaXRv?= <jose.exposito89@gmail.com>
Subject: [PATCH 0/1] HID: uclogic: Add HID_QUIRK_HIDINPUT_FORCE quirk
Date: Thu, 10 Nov 2022 18:40:55 +0100
Message-Id: <20221110174056.393697-1-jose.exposito89@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,
FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1749132303168554373?=
X-GMAIL-MSGID: =?utf-8?q?1749132349898495489?=
|
| Series |
HID: uclogic: Add HID_QUIRK_HIDINPUT_FORCE quirk
|
|
Message
José Expósito
Nov. 10, 2022, 5:40 p.m. UTC
Hi everyone, About 3 months ago, Torge Matthies sent a patch fixing an issue with his XP-Pen Star G640 [1]. His patch changes the IS_INPUT_APPLICATION() macro to accept HID_DG_DIGITIZER. However, it looks like it is not being merged because of the possible side effects that changing that macro could generate. This patch aims to fix the same issue but using a more conservative approach hoping that the bug can be fixed. Torge, Alexander, could you test it and confirm that it fixes your issues, please? Thanks a lot in advance, José Expósito [1] https://lore.kernel.org/linux-input/20220804151832.30373-1-openglfreak@googlemail.com/ José Expósito (1): HID: uclogic: Add HID_QUIRK_HIDINPUT_FORCE quirk drivers/hid/hid-uclogic-core.c | 1 + 1 file changed, 1 insertion(+)
Comments
Hi José, On 11/10/22 9:40 AM, José Expósito wrote: > Hi everyone, > > About 3 months ago, Torge Matthies sent a patch fixing an issue with > his XP-Pen Star G640 [1]. > > His patch changes the IS_INPUT_APPLICATION() macro to accept > HID_DG_DIGITIZER. However, it looks like it is not being merged because > of the possible side effects that changing that macro could generate. > > This patch aims to fix the same issue but using a more conservative > approach hoping that the bug can be fixed. > > Torge, Alexander, could you test it and confirm that it fixes your > issues, please? I tested the patch on commit 4bbf3422df78 and it fixes the issue. Thank you, Alexander Zhang > Thanks a lot in advance, > José Expósito > > [1] https://lore.kernel.org/linux-input/20220804151832.30373-1-openglfreak@googlemail.com/ > > José Expósito (1): > HID: uclogic: Add HID_QUIRK_HIDINPUT_FORCE quirk > > drivers/hid/hid-uclogic-core.c | 1 + > 1 file changed, 1 insertion(+) >
On Thu, 10 Nov 2022, Alexander Zhang wrote: > Hi José, > > On 11/10/22 9:40 AM, José Expósito wrote: > > Hi everyone, > > > > About 3 months ago, Torge Matthies sent a patch fixing an issue with > > his XP-Pen Star G640 [1]. > > > > His patch changes the IS_INPUT_APPLICATION() macro to accept > > HID_DG_DIGITIZER. However, it looks like it is not being merged because > > of the possible side effects that changing that macro could generate. > > > > This patch aims to fix the same issue but using a more conservative > > approach hoping that the bug can be fixed. > > > > Torge, Alexander, could you test it and confirm that it fixes your > > issues, please? > > I tested the patch on commit 4bbf3422df78 and it fixes the issue. I will add Tested-by: Alexander Zhang <alex@alexyzhang.dev> to the commit; please speak up if you disagree. Thanks,
On 11/14/22 6:10 AM, Jiri Kosina wrote: > On Thu, 10 Nov 2022, Alexander Zhang wrote: > >> Hi José, >> >> On 11/10/22 9:40 AM, José Expósito wrote: >>> Hi everyone, >>> >>> About 3 months ago, Torge Matthies sent a patch fixing an issue with >>> his XP-Pen Star G640 [1]. >>> >>> His patch changes the IS_INPUT_APPLICATION() macro to accept >>> HID_DG_DIGITIZER. However, it looks like it is not being merged because >>> of the possible side effects that changing that macro could generate. >>> >>> This patch aims to fix the same issue but using a more conservative >>> approach hoping that the bug can be fixed. >>> >>> Torge, Alexander, could you test it and confirm that it fixes your >>> issues, please? >> >> I tested the patch on commit 4bbf3422df78 and it fixes the issue. > > I will add > > Tested-by: Alexander Zhang <alex@alexyzhang.dev> > > to the commit; please speak up if you disagree. I'm not sure if you're still waiting for a response from me but I'm fine with that. Thanks, Alexander Zhang
Hello, On 11/19/22 11:01 PM, Alexander Zhang wrote: > On 11/14/22 6:10 AM, Jiri Kosina wrote: >> On Thu, 10 Nov 2022, Alexander Zhang wrote: >> >>> Hi José, >>> >>> On 11/10/22 9:40 AM, José Expósito wrote: >>>> Hi everyone, >>>> >>>> About 3 months ago, Torge Matthies sent a patch fixing an issue with >>>> his XP-Pen Star G640 [1]. >>>> >>>> His patch changes the IS_INPUT_APPLICATION() macro to accept >>>> HID_DG_DIGITIZER. However, it looks like it is not being merged because >>>> of the possible side effects that changing that macro could generate. >>>> >>>> This patch aims to fix the same issue but using a more conservative >>>> approach hoping that the bug can be fixed. >>>> >>>> Torge, Alexander, could you test it and confirm that it fixes your >>>> issues, please? >>> >>> I tested the patch on commit 4bbf3422df78 and it fixes the issue. >> >> I will add >> >> Tested-by: Alexander Zhang <alex@alexyzhang.dev> >> >> to the commit; please speak up if you disagree. > > I'm not sure if you're still waiting for a response from me but I'm fine > with that. Is there something preventing this patch from being merged? I'm not very familiar with the kernel development process. Best, Alexander Zhang
Hi Alexander, On Mon, Dec 05, 2022 at 04:49:10PM -0800, Alexander Zhang wrote: > Hello, > > On 11/19/22 11:01 PM, Alexander Zhang wrote: > > On 11/14/22 6:10 AM, Jiri Kosina wrote: > > > On Thu, 10 Nov 2022, Alexander Zhang wrote: > > > > > > > Hi José, > > > > > > > > On 11/10/22 9:40 AM, José Expósito wrote: > > > > > Hi everyone, > > > > > > > > > > About 3 months ago, Torge Matthies sent a patch fixing an issue with > > > > > his XP-Pen Star G640 [1]. > > > > > > > > > > His patch changes the IS_INPUT_APPLICATION() macro to accept > > > > > HID_DG_DIGITIZER. However, it looks like it is not being merged because > > > > > of the possible side effects that changing that macro could generate. > > > > > > > > > > This patch aims to fix the same issue but using a more conservative > > > > > approach hoping that the bug can be fixed. > > > > > > > > > > Torge, Alexander, could you test it and confirm that it fixes your > > > > > issues, please? > > > > > > > > I tested the patch on commit 4bbf3422df78 and it fixes the issue. > > > > > > I will add > > > > > > Tested-by: Alexander Zhang <alex@alexyzhang.dev> > > > > > > to the commit; please speak up if you disagree. > > > > I'm not sure if you're still waiting for a response from me but I'm fine > > with that. > > Is there something preventing this patch from being merged? I'm not very > familiar with the kernel development process. The patch is already applied in the for-next branch, you can find it here: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-next&id=3405a4beaaa8 Jose > Best, > Alexander Zhang
On 12/7/22 3:09 AM, José Expósito wrote: > Hi Alexander, > > On Mon, Dec 05, 2022 at 04:49:10PM -0800, Alexander Zhang wrote: >> Hello, >> >> On 11/19/22 11:01 PM, Alexander Zhang wrote: >>> On 11/14/22 6:10 AM, Jiri Kosina wrote: >>>> On Thu, 10 Nov 2022, Alexander Zhang wrote: >>>> >>>>> Hi José, >>>>> >>>>> On 11/10/22 9:40 AM, José Expósito wrote: >>>>>> Hi everyone, >>>>>> >>>>>> About 3 months ago, Torge Matthies sent a patch fixing an issue with >>>>>> his XP-Pen Star G640 [1]. >>>>>> >>>>>> His patch changes the IS_INPUT_APPLICATION() macro to accept >>>>>> HID_DG_DIGITIZER. However, it looks like it is not being merged because >>>>>> of the possible side effects that changing that macro could generate. >>>>>> >>>>>> This patch aims to fix the same issue but using a more conservative >>>>>> approach hoping that the bug can be fixed. >>>>>> >>>>>> Torge, Alexander, could you test it and confirm that it fixes your >>>>>> issues, please? >>>>> >>>>> I tested the patch on commit 4bbf3422df78 and it fixes the issue. >>>> >>>> I will add >>>> >>>> Tested-by: Alexander Zhang <alex@alexyzhang.dev> >>>> >>>> to the commit; please speak up if you disagree. >>> >>> I'm not sure if you're still waiting for a response from me but I'm fine >>> with that. >> >> Is there something preventing this patch from being merged? I'm not very >> familiar with the kernel development process. > > The patch is already applied in the for-next branch, you can find it here: > https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-next&id=3405a4beaaa8 I see, thank you very much! Best, Alexander Zhang