From patchwork Thu Nov 10 01:48:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Christopherson X-Patchwork-Id: 1420 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp668627wru; Wed, 9 Nov 2022 17:49:48 -0800 (PST) X-Google-Smtp-Source: AA0mqf4wOxFQm8ToqyfLlVv+EgbLXiS7n88hMDrpY4dGEdw+FTF0NutaowDhN7kkBMpWYfZ8agbE X-Received: by 2002:aa7:93ad:0:b0:571:2b7c:5e98 with SMTP id x13-20020aa793ad000000b005712b7c5e98mr6177663pff.44.1668044988376; Wed, 09 Nov 2022 17:49:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668044988; cv=none; d=google.com; s=arc-20160816; b=yyCresQB16TJe31oN12WacIFEeMkcvsAeJFS94iicc9DlxGDWVdPuvTlQYsq/d/Pdo L7gFttOKbDNKZIqTaaeUQ+ilOcPHJ4KqJI8B0jVH71ktHBdv8wQs4kVVq0qSCtSfC+Hk v4/gXMXvEEKwqd5Lc/hGUPEvst6pyI43RAvvoNzGYEC4L1FlQTM2I50x3sdkDdzt8M5r I/lj31tDAgN6j1QtT4tR0lTq/n+pAOTVRsNC0nQaS2viCWm7FK5Y0HVrHtAII2KMQn8s ZCexrQWzG3kZB4wxj8wPaUSJpFPfONBhkUwkxHbOEynr/N7WHSmuXn6/P9ZvB9GeGOtP JGAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:mime-version:date :reply-to:dkim-signature; bh=czRAUIKopWS6UNhZrlaJNdPvNfcaMl7pKNzRt/2ikJM=; b=OCY7ZpEpHfkCUXjfEFe8YUexngaILSmjOhgnWdFG0j/url14o3UHvV57zfZ3/rmFYi uUzA20Y0mRcjw0fSn82J4kQsxNFaB3YFLW+AKDtfvz5bL7gvusmukkb/rwBE4aNZZiU6 nckXpXfu6aRl/tLkYrjmPUhAQN869e4853wDL1rXSQdQ3kAT07gbZj34fwPbiHUVU+5B JP56aZShNeObCK6x7LDYS+jI9zoyiVFUtVkuqM4NBJqWun5ZpXYZL5xaKKrB1qN4CNeC RPaZXkxk8MsjUO8vNAleFfCBniVzVLvGjl54ZJianXStaowbvCEodfdl7svk7465t952 lLIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=fpoDzxDM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j34-20020a635962000000b0046fb275ee55si18971160pgm.507.2022.11.09.17.49.35; Wed, 09 Nov 2022 17:49:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=fpoDzxDM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232174AbiKJBs2 (ORCPT + 99 others); Wed, 9 Nov 2022 20:48:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230323AbiKJBsZ (ORCPT ); Wed, 9 Nov 2022 20:48:25 -0500 Received: from mail-pj1-x104a.google.com (mail-pj1-x104a.google.com [IPv6:2607:f8b0:4864:20::104a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA1FCB78 for ; Wed, 9 Nov 2022 17:48:24 -0800 (PST) Received: by mail-pj1-x104a.google.com with SMTP id pj8-20020a17090b4f4800b002140219b2b3so3281883pjb.0 for ; Wed, 09 Nov 2022 17:48:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:reply-to:from:to:cc :subject:date:message-id:reply-to; bh=czRAUIKopWS6UNhZrlaJNdPvNfcaMl7pKNzRt/2ikJM=; b=fpoDzxDMW+3u08v36DNw63uremA9sbsMmIFu2x8khM3/gBySJsYse9ASpc0svRbvn3 WQfcM4iyPITgrDTDgu2S+qClNj83o6nuifGmu20kTjfEirlD/zB2d5DAxK+98c5vAtNY 4EqK+gmP3PZu4PVATaG3O6S9sjZ3mhBPlKsQZnOiDOKOKlP0GVBzxW/QYbH1w9P71/Ch 3NKukEyx9UR9a0oNc8eyQWd/KcZHZBuzxeiSeCmK6itvS7/7XGxSuME1jWAUJKhbEdRq hRBlvRJb58rTmNTItfyIlGspaQC3OCJAVlM3te1nuqOjNjiR2hNHdUbClxbUl80OrtAZ +3kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:reply-to :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=czRAUIKopWS6UNhZrlaJNdPvNfcaMl7pKNzRt/2ikJM=; b=2eEL8KSU/3iiA8swVucFi9Sx1HrdH79Neg3QWwlrTj1eacPpCZe9FLdoWaLLAgHdv0 p2pQiK4S4dyO4RTyo7uhVtyvqLnula+Rp2eMZpEuSYCM1RAZ2vmPT+J3SPjZMyhMmj55 n+5YMspr5vzrdF3rb1qiWya+wrT1T4mfDZ1dfMgHJUiUhvAPZzC/KaQNx4NvaAGuzQvU XO01bxHhgl7zB/JEsksOIhTLjTDkPw++YXIvcrLdxzS6cTmQnsyayRvAVL39tSq5XGw0 1FvxeD4C7wzHsOY4g9Nh4jGOqLnPUQhesLaJsZRgMQWpYrK6t0UMEy4gJJCo949WLc0j 8/YA== X-Gm-Message-State: ACrzQf2MLXHNGEdHIlOtKErJLM/999mRsp7UmaB3AfUqiYc3qW2rj272 qDxeaOXNa27CPEoZItQuzitmSzwpF2U= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a62:1b11:0:b0:56d:568d:c293 with SMTP id b17-20020a621b11000000b0056d568dc293mr55789021pfb.41.1668044904195; Wed, 09 Nov 2022 17:48:24 -0800 (PST) Reply-To: Sean Christopherson Date: Thu, 10 Nov 2022 01:48:19 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.38.1.431.g37b22c650d-goog Message-ID: <20221110014821.1548347-1-seanjc@google.com> Subject: [PATCH 0/2] KVM: x86/mmu: Use page-track only for... page tracking From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Yan Zhao X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749071941582317043?= X-GMAIL-MSGID: =?utf-8?q?1749071941582317043?= Don't bounce through the page-track notifier when zapping+flushing SPTEs in response to memslot changes as the need to zap+flush isn't strictly limited to page-tracking. With that done, register KVM's notifier on the first allocation of a shadow root, as KVM's ->track_write() hook is used only to react to writes to gPTEs. Aside from avoiding a RETPOLINE on emulated writes, dropping KVM's internal use will allow removing ->track_flush_slot() altogether once KVM-GT moves to a different hook[*]. Tracking "flushes" of slots is a poor fit for KVM-GT's needs as KVM-GT needs to drop its write-protection only when a memslot change is guaranteed to be committed, whereas the "flush" call is speculative in the sense that KVM may abort a memslot update after flushing the original memslot. https://lore.kernel.org/all/20221108084416.11447-1-yan.y.zhao@intel.com Sean Christopherson (2): KVM: x86/mmu: Don't rely on page-track mechanism to flush on memslot change KVM: x86/mmu: Register page-tracker on first shadow root allocation arch/x86/include/asm/kvm_host.h | 1 + arch/x86/kvm/mmu/mmu.c | 24 ++++++++---------------- arch/x86/kvm/x86.c | 2 ++ 3 files changed, 11 insertions(+), 16 deletions(-) base-commit: d663b8a285986072428a6a145e5994bc275df994