mbox series

[v2,0/2] net: fec: optimization and statistics

Message ID 20221108172105.3760656-1-shenwei.wang@nxp.com
Headers
Series net: fec: optimization and statistics |

Message

Shenwei Wang Nov. 8, 2022, 5:21 p.m. UTC 
  As the patch to add XDP statistics is based on the previous optimization
patch, I've put the two patches together. The link to the optimization
is the following:

https://lore.kernel.org/imx/20221104024754.2756412-1-shenwei.wang@nxp.com/

Changes in v2:
 - clean up and restructure the codes per Andrew Lunn's review comments
 - clear the statistics when the adaptor is down

Shenwei Wang (2):
  net: fec: simplify the code logic of quirks
  net: fec: add xdp and page pool statistics

 drivers/net/ethernet/freescale/fec.h      |  14 +++
 drivers/net/ethernet/freescale/fec_main.c | 134 ++++++++++++++++++----
 2 files changed, 124 insertions(+), 24 deletions(-)

--
2.34.1

Comments

Jakub Kicinski Nov. 9, 2022, 1:57 a.m. UTC | #1 
On Tue,  8 Nov 2022 11:21:03 -0600 Shenwei Wang wrote:
> As the patch to add XDP statistics is based on the previous optimization
> patch, I've put the two patches together. The link to the optimization
> is the following:
> 
> https://lore.kernel.org/imx/20221104024754.2756412-1-shenwei.wang@nxp.com/

This set doesn't apply to net-next, is it on top of some
not-yet-applied patches ?
Shenwei Wang Nov. 9, 2022, 2:15 a.m. UTC | #2 
> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Tuesday, November 8, 2022 7:57 PM
> To: Shenwei Wang <shenwei.wang@nxp.com>
> Cc: David S. Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Paolo Abeni <pabeni@redhat.com>; Alexei
> Starovoitov <ast@kernel.org>; Daniel Borkmann <daniel@iogearbox.net>;
> Jesper Dangaard Brouer <hawk@kernel.org>; John Fastabend
> <john.fastabend@gmail.com>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; imx@lists.linux.dev
> Subject: [EXT] Re: [PATCH v2 0/2] net: fec: optimization and statistics
> 
> Caution: EXT Email
> 
> On Tue,  8 Nov 2022 11:21:03 -0600 Shenwei Wang wrote:
> > As the patch to add XDP statistics is based on the previous
> > optimization patch, I've put the two patches together. The link to the
> > optimization is the following:
> >
> 
> This set doesn't apply to net-next, is it on top of some not-yet-applied patches ?

I saw the first patch " net: fec: simplify the code logic of quirks" had already been
applied a day ago. May only need to apply the second one: " net: fec: add xdp and page pool statistics".

Sorry for the confusion.
Thanks,
Shenwei
Jakub Kicinski Nov. 9, 2022, 2:20 a.m. UTC | #3 
On Wed, 9 Nov 2022 02:15:28 +0000 Shenwei Wang wrote:
> > This set doesn't apply to net-next, is it on top of some not-yet-applied patches ?  
> 
> I saw the first patch " net: fec: simplify the code logic of quirks" had already been
> applied a day ago. May only need to apply the second one: " net: fec: add xdp and page pool statistics".

Oh, I see. You can wait for reviews a bit longer, but you'll have 
to repost just the parts that can be applied separately.
It's fairly tricky to skip the first patch when applying,
and the build bot will definitely not be able to cope.