mbox series

[v4,0/3] Add support for QSGMII mode for J721e CPSW9G to am65-cpsw driver

Message ID 20221108080606.124596-1-s-vadapalli@ti.com
Headers
Series Add support for QSGMII mode for J721e CPSW9G to am65-cpsw driver |

Message

Siddharth Vadapalli Nov. 8, 2022, 8:06 a.m. UTC 
  Add compatible to am65-cpsw driver for J721e CPSW9G, which contains 8
external ports and 1 internal host port.

Add support to power on and power off the SERDES PHY which is used by the
CPSW MAC.

=========
Changelog
=========
v3 -> v4:
1. Fix subject of patch-1/3, updating it to:
   "dt-bindings: net: ti: k3-am654-cpsw-nuss: Add J721e CPSW9G support"
   and collect Reviewed-by tag.
2. Rebase series on linux-next tree tagged: next-20221107.

v2 -> v3:
1. Run 'make DT_CHECKER_FLAGS=-m dt_binding_check' and fix errors and
   warnings corresponding to the patch for:
   Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
   with the latest dt-schema and yamllint.

v1 -> v2:
1. Drop all patches corresponding to SGMII mode. This is done since I do
   not have a method to test SGMII in the standard mode which uses an
   SGMII PHY. The previous series used SGMII in a fixed-link mode,
   bypassing the SGMII PHY. I will post the SGMII patches in a future
   series after testing them.
2. Drop all patches corresponding to fixed-link in the am65-cpsw driver.
   This is done since PHYLINK takes care of fixed-link automatically and
   there is no need to deal with fixed-link in a custom fashion.
3. Fix indentation errors in k3-am65-cpsw-nuss.yaml.
4. Remove the stale code which tries to power on and power off the CPSW
   MAC's phy, since the CPSW MAC's phy driver does not support it.
5. Rename the function "am65_cpsw_init_phy()" to
   "am65_cpsw_init_serdes_phy()", to indicate that the phy corresponds to
   the SERDES.
6. Invoke "am65_cpsw_disable_serdes_phy()" as a part of the cleanup that
   is associated with the "am65_cpsw_nuss_remove()" function.

v3:
https://lore.kernel.org/r/20221026090957.180592-1-s-vadapalli@ti.com/
v2:
https://lore.kernel.org/r/20221018085810.151327-1-s-vadapalli@ti.com/
v1:
https://lore.kernel.org/r/20220914095053.189851-1-s-vadapalli@ti.com/

Siddharth Vadapalli (3):
  dt-bindings: net: ti: k3-am654-cpsw-nuss: Add J721e CPSW9G support
  net: ethernet: ti: am65-cpsw: Enable QSGMII mode for J721e CPSW9G
  net: ethernet: ti: am65-cpsw: Add support for SERDES configuration

 .../bindings/net/ti,k3-am654-cpsw-nuss.yaml   | 33 ++++++++-
 drivers/net/ethernet/ti/am65-cpsw-nuss.c      | 73 +++++++++++++++++++
 2 files changed, 102 insertions(+), 4 deletions(-)

Comments

Jakub Kicinski Nov. 9, 2022, 1:53 a.m. UTC | #1 
On Tue, 8 Nov 2022 13:36:03 +0530 Siddharth Vadapalli wrote:
> 2. Rebase series on linux-next tree tagged: next-20221107.

You need to based on the tree which you're expecting to apply the patch.
Which should be net-next here-  throw that into the subject while at it
([PATCH net-next v5 0/3] ....). v4 does not apply cleanly.
Siddharth Vadapalli Nov. 9, 2022, 3:58 a.m. UTC | #2 
Hello Jakub,

On 09/11/22 07:23, Jakub Kicinski wrote:
> On Tue, 8 Nov 2022 13:36:03 +0530 Siddharth Vadapalli wrote:
>> 2. Rebase series on linux-next tree tagged: next-20221107.
> 
> You need to based on the tree which you're expecting to apply the patch.
> Which should be net-next here-  throw that into the subject while at it
> ([PATCH net-next v5 0/3] ....). v4 does not apply cleanly.

I will rebase the series on the net-next tree and use "PATCH net-next"
in the subject and then post the v5 series. It looks like a few patches
got merged to the net-next tree after I had posted my series.

Regards,
Siddharth.