mbox series

[v2,0/4] clk: qcom: clk-rcg2: introduce support for multiple conf for same freq

Message ID 20221103134944.23275-1-ansuelsmth@gmail.com
Headers
Series clk: qcom: clk-rcg2: introduce support for multiple conf for same freq |

Message

Christian Marangi Nov. 3, 2022, 1:49 p.m. UTC 
  This small series fix a current problem with ipq8074 where the 2 uniphy
port doesn't work in some corner case with some clk configuration. The
port to correctly work require a specific frequency, using the wrong one
results in the port not transmitting data.

With the current code with a requested freq of 125MHz, the frequency is
set to 105MHz. This is caused by the fact that there are 2 different
configuration to set 125MHz and it's always selected the first one that
results in 105MHz.

In the original QSDK code, the frequency configuration selection is
different and the CEIL FLOOR logic is not present. Instead it's used a
BEST approach where the frequency table is checked and then it's checked
if there are duplicate entry.

This proposed implementation is more specific and keep the CEIL FLOOR
logic while maitaining the possibility to provide multiple
configuration.

The first 2 patch drop redundant F entry redefinition.

The 3rd one implement the change with also some macro description on how
this new implementation works

The 4th one migrate the gcc-ipq8074 driver to this new implementation.

Changes v2:
- Out of RFC
- Fix compile warning from buildbot related to F redefinition

Christian Marangi (4):
  clk: qcom: gcc-ipq6018: drop redundant F define
  clk: qcom: gcc-sdm660: drop redundant F define
  clk: qcom: clk-rcg2: introduce support for multiple conf for same freq
  clk: qcom: gcc-ipq8074: rework nss_port5/6 clock to multiple conf

 drivers/clk/qcom/clk-rcg.h     | 14 +++++-
 drivers/clk/qcom/clk-rcg2.c    | 84 ++++++++++++++++++++++++++++++----
 drivers/clk/qcom/gcc-ipq6018.c |  2 -
 drivers/clk/qcom/gcc-ipq8074.c | 64 +++++++++++++++++++-------
 drivers/clk/qcom/gcc-sdm660.c  |  2 -
 5 files changed, 136 insertions(+), 30 deletions(-)