mbox series

[v2,0/5] fsi: Add regmap and refactor sbefifo

Message ID 20221102205148.1334459-1-eajames@linux.ibm.com
Headers
Series fsi: Add regmap and refactor sbefifo |

Message

Eddie James Nov. 2, 2022, 8:51 p.m. UTC 
  The SBEFIFO hardware can now be attached over a new I2C endpoint interface
called the I2C Responder (I2CR). In order to use the existing SBEFIFO
driver, add a regmap driver for the FSI bus and an endpoint driver for the
I2CR. Then, refactor the SBEFIFO and OCC drivers to clean up and use the
new regmap driver or the I2CR interface.

Changes since v1:
 - Instead of a regmap driver for the I2CR, just have a private interface
   driver for FSI, since SBEFIFO is likely the only user.

Eddie James (5):
  regmap: Add FSI bus support
  drivers: fsi: Add I2C Responder driver
  drivers: fsi: Rename sbefifo and occ sources
  drivers: fsi: separate char device code for occ and sbefifo
  drivers: fsi: occ and sbefifo refactor

 drivers/base/regmap/Kconfig      |    6 +-
 drivers/base/regmap/Makefile     |    1 +
 drivers/base/regmap/regmap-fsi.c |  231 ++++++
 drivers/fsi/Kconfig              |   32 +-
 drivers/fsi/Makefile             |    9 +-
 drivers/fsi/fsi-occ.c            |  766 --------------------
 drivers/fsi/fsi-sbefifo.c        | 1144 ------------------------------
 drivers/fsi/i2cr.c               |  116 +++
 drivers/fsi/i2cr.h               |   19 +
 drivers/fsi/occ-cdev.c           |  157 ++++
 drivers/fsi/occ.c                |  536 ++++++++++++++
 drivers/fsi/occ.h                |   57 ++
 drivers/fsi/sbefifo-cdev.c       |  218 ++++++
 drivers/fsi/sbefifo-fsi.c        |   68 ++
 drivers/fsi/sbefifo-i2c.c        |   73 ++
 drivers/fsi/sbefifo.c            |  797 +++++++++++++++++++++
 drivers/fsi/sbefifo.h            |   50 ++
 include/linux/regmap.h           |   37 +
 18 files changed, 2398 insertions(+), 1919 deletions(-)
 create mode 100644 drivers/base/regmap/regmap-fsi.c
 delete mode 100644 drivers/fsi/fsi-occ.c
 delete mode 100644 drivers/fsi/fsi-sbefifo.c
 create mode 100644 drivers/fsi/i2cr.c
 create mode 100644 drivers/fsi/i2cr.h
 create mode 100644 drivers/fsi/occ-cdev.c
 create mode 100644 drivers/fsi/occ.c
 create mode 100644 drivers/fsi/occ.h
 create mode 100644 drivers/fsi/sbefifo-cdev.c
 create mode 100644 drivers/fsi/sbefifo-fsi.c
 create mode 100644 drivers/fsi/sbefifo-i2c.c
 create mode 100644 drivers/fsi/sbefifo.c
 create mode 100644 drivers/fsi/sbefifo.h

Comments

Mark Brown Nov. 25, 2022, 9:28 p.m. UTC | #1 
On Wed, 2 Nov 2022 15:51:43 -0500, Eddie James wrote:
> The SBEFIFO hardware can now be attached over a new I2C endpoint interface
> called the I2C Responder (I2CR). In order to use the existing SBEFIFO
> driver, add a regmap driver for the FSI bus and an endpoint driver for the
> I2CR. Then, refactor the SBEFIFO and OCC drivers to clean up and use the
> new regmap driver or the I2CR interface.
> 
> Changes since v1:
>  - Instead of a regmap driver for the I2CR, just have a private interface
>    driver for FSI, since SBEFIFO is likely the only user.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next

Thanks!

[1/5] regmap: Add FSI bus support
      commit: bf0d29fb51ff5e6c13097dbfed7b99e0e35b4a15

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Eddie James Jan. 19, 2023, 5:48 p.m. UTC | #2 
On 11/2/22 15:51, Eddie James wrote:
> The SBEFIFO hardware can now be attached over a new I2C endpoint interface
> called the I2C Responder (I2CR). In order to use the existing SBEFIFO
> driver, add a regmap driver for the FSI bus and an endpoint driver for the
> I2CR. Then, refactor the SBEFIFO and OCC drivers to clean up and use the
> new regmap driver or the I2CR interface.


I'm abandoning the rest of this series in favor of an FSI master driver 
through the I2C responder. It makes a lot more sense to implement a 
master driver here because then we get all the engine drivers for free, 
rather than rework them to talk over i2c.

Thanks,

Eddie


>
> Changes since v1:
>   - Instead of a regmap driver for the I2CR, just have a private interface
>     driver for FSI, since SBEFIFO is likely the only user.
>
> Eddie James (5):
>    regmap: Add FSI bus support
>    drivers: fsi: Add I2C Responder driver
>    drivers: fsi: Rename sbefifo and occ sources
>    drivers: fsi: separate char device code for occ and sbefifo
>    drivers: fsi: occ and sbefifo refactor
>
>   drivers/base/regmap/Kconfig      |    6 +-
>   drivers/base/regmap/Makefile     |    1 +
>   drivers/base/regmap/regmap-fsi.c |  231 ++++++
>   drivers/fsi/Kconfig              |   32 +-
>   drivers/fsi/Makefile             |    9 +-
>   drivers/fsi/fsi-occ.c            |  766 --------------------
>   drivers/fsi/fsi-sbefifo.c        | 1144 ------------------------------
>   drivers/fsi/i2cr.c               |  116 +++
>   drivers/fsi/i2cr.h               |   19 +
>   drivers/fsi/occ-cdev.c           |  157 ++++
>   drivers/fsi/occ.c                |  536 ++++++++++++++
>   drivers/fsi/occ.h                |   57 ++
>   drivers/fsi/sbefifo-cdev.c       |  218 ++++++
>   drivers/fsi/sbefifo-fsi.c        |   68 ++
>   drivers/fsi/sbefifo-i2c.c        |   73 ++
>   drivers/fsi/sbefifo.c            |  797 +++++++++++++++++++++
>   drivers/fsi/sbefifo.h            |   50 ++
>   include/linux/regmap.h           |   37 +
>   18 files changed, 2398 insertions(+), 1919 deletions(-)
>   create mode 100644 drivers/base/regmap/regmap-fsi.c
>   delete mode 100644 drivers/fsi/fsi-occ.c
>   delete mode 100644 drivers/fsi/fsi-sbefifo.c
>   create mode 100644 drivers/fsi/i2cr.c
>   create mode 100644 drivers/fsi/i2cr.h
>   create mode 100644 drivers/fsi/occ-cdev.c
>   create mode 100644 drivers/fsi/occ.c
>   create mode 100644 drivers/fsi/occ.h
>   create mode 100644 drivers/fsi/sbefifo-cdev.c
>   create mode 100644 drivers/fsi/sbefifo-fsi.c
>   create mode 100644 drivers/fsi/sbefifo-i2c.c
>   create mode 100644 drivers/fsi/sbefifo.c
>   create mode 100644 drivers/fsi/sbefifo.h
>