Message ID | 20221102141513.49289-1-fnkl.kernel@gmail.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp3647487wru; Wed, 2 Nov 2022 07:18:14 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7oIHeY+sJSw7kbTg2nTkt5wsy+GfLdAiY9jdKtqbE4jTCufrk3bTU9EUM4TiZZ0oGuLhrA X-Received: by 2002:a17:906:328c:b0:780:7574:ced2 with SMTP id 12-20020a170906328c00b007807574ced2mr24215162ejw.634.1667398694194; Wed, 02 Nov 2022 07:18:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667398694; cv=none; d=google.com; s=arc-20160816; b=FiUMX0+/QsFaJjnrg7ldH323JezP8RSLU8JJ7K9WqtRENmBOFz0OuAj03RzOTHHrG4 ZEogpPJ3+qBhx6C+/W4GLtD96Ru9P0J2lJcu42wMtacg6Km9BLAcE3PkFquvsBH8eAD8 Tc0NxfobQ1LTbyebzci7YjKUlEsDe13+aEDvql/gx+ohK0X/OQyQvc07suhU0stVp3AT /xODGGD/ls20ojBMoh501yzEii/H+OKaWueK9afN5uF9AOcCxri9En3YCVqP4J96n/4g sr8+bfaO5Scxgu56Nyds2CASHNg+dTG9gPWFoeaiaoR9bW3elowjE3zNCtchHYmtQyqv zHig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=0Tx9qzuOwx4JUlHp6FkZ/5WKZ4d6lYz+D1HQa2LD1tA=; b=BD+QAdADmND5z01/nUNuJYIPf9l2Yb6ioXL3ogCLjRM5z/TvUd5vAnWSicCnxE0A74 TpoInpUFoLdDewlyFvJqWLznEbZyCjzyucBXsLViqRuT6QiK8RvR2Lne2gDVqV6MOPKX LamHq6jJr7RmQqGAtfLNj5Q3zBbb31N/c7o6jF7LVtGHf/Nuw2UfdeS5GdMqA5m+3HOr TH76sdbN58iwmlPSMTFEvojywi7lpCTIYVq/q+vCCLTgRwGmthvUwbsJ06VZZNjPUXVt 3kKap5ip6m3ZTNmnN/pGG4uT1DsWjozu657tinSeW+LWzxek+hNTTg65ksBmhEzzNq41 0tIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=EsCUjDCG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bt15-20020a0564020a4f00b0045928479b71si13447643edb.405.2022.11.02.07.17.50; Wed, 02 Nov 2022 07:18:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=EsCUjDCG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231298AbiKBORT (ORCPT <rfc822;yves.mi.zy@gmail.com> + 99 others); Wed, 2 Nov 2022 10:17:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231362AbiKBORQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 2 Nov 2022 10:17:16 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47BB327CC7; Wed, 2 Nov 2022 07:17:13 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id a67so26645786edf.12; Wed, 02 Nov 2022 07:17:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0Tx9qzuOwx4JUlHp6FkZ/5WKZ4d6lYz+D1HQa2LD1tA=; b=EsCUjDCGvuVNc+ZigO1adhkMaFllrxPwJiMmH/+MVP0eLnT14RddOwiZVy7TvY1/qS TzksJ+8HrWbW4EVKdWXNmisIHRooHPtEA6sn7edEUQan2h5aE6kGfmye558mnGqb490m mmNXHOBMMLIS9MGKcRcVMIpIryB8zXz7brhX4cSYbY8bvBL3nBA2HtJDiP9yJjz603Mc ZzzgTlKg6SFs29tlhcNttEaAdWKteOQ9lUF89bGqD6ApUTgKQvTTivquO3oDYSIyFm+f IzVGEV+lJt7hVD2uSnsrHzTNwmqdZjEM8xsU9Q/RVATUb3MJZtio9IiyFqQvnoaFcDHv sANg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0Tx9qzuOwx4JUlHp6FkZ/5WKZ4d6lYz+D1HQa2LD1tA=; b=BJvZAg9GRtj1MJgsYISBu8YMEgmATz3a7B3fRwx3H1dVZrrbkdVsWD0gjnBilHiyNi PqGUsLQW1D74L0+pVBzQhGbQCDhRwAAfTyN5Pfpa9RhF7Pe/cHyapGlKhcPxmX5Ip8C8 2wF0ySCPbXRzuOjulnE5+V+woVyWFGkJY0zIxUvs736jsJfymnAB8Jn92D0mpfZxgxwb VuQxuQ1mSKh9Osl6rwHOaNVBoZGa6FitHdAYmwhgVnMVWP0kfDhW9tCbJTjoxRmfkWYX 7TU0OtiXSdqWtkolau0/LB5fdHoMZXtRqYqJvS2Xni0ZZ4eDDlDecuf5ixaIOkywWgjG OfMg== X-Gm-Message-State: ACrzQf2+QKSlGCHPnCS2AfNKNY2zXxmZ35t1Ty0HPWFqsKkquASIWNGA cv0wlpe5Dp0CY+qDofo917k= X-Received: by 2002:a05:6402:2937:b0:461:32aa:32da with SMTP id ee55-20020a056402293700b0046132aa32damr24299542edb.78.1667398631862; Wed, 02 Nov 2022 07:17:11 -0700 (PDT) Received: from localhost ([88.227.60.86]) by smtp.gmail.com with UTF8SMTPSA id my15-20020a1709065a4f00b0078d38cda2b1sm5376305ejc.202.2022.11.02.07.17.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 07:17:11 -0700 (PDT) From: Sasha Finkelstein <fnkl.kernel@gmail.com> To: thierry.reding@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sasha Finkelstein <fnkl.kernel@gmail.com> Subject: [PATCH v2 0/4] PWM and keyboard backlight driver for ARM Macs Date: Wed, 2 Nov 2022 17:15:09 +0300 Message-Id: <20221102141513.49289-1-fnkl.kernel@gmail.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748394253118635870?= X-GMAIL-MSGID: =?utf-8?q?1748394253118635870?= |
Series |
PWM and keyboard backlight driver for ARM Macs
|
|
Message
Sasha Finkelstein
Nov. 2, 2022, 2:15 p.m. UTC
Hi, This is the v2 of the patch series to add PWM and keyboard backlight drivers for ARM macs. The changes from v1 address the review comments on that patch set. v1: https://www.spinics.net/lists/linux-pwm/msg19500.html Best Regards. Sasha Finkelstein (4): dt-bindings: pwm: Add Apple PWM controller pwm: Add Apple PWM controller arm64: dts: apple: t8103: Add PWM controller MAINTAINERS: Add entries for Apple PWM driver .../bindings/pwm/apple,s5l-fpwm.yaml | 51 +++++++ MAINTAINERS | 2 + arch/arm64/boot/dts/apple/t8103-j293.dts | 20 +++ arch/arm64/boot/dts/apple/t8103-j313.dts | 20 +++ arch/arm64/boot/dts/apple/t8103.dtsi | 9 ++ drivers/pwm/Kconfig | 12 ++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-apple.c | 127 ++++++++++++++++++ 8 files changed, 242 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml create mode 100644 drivers/pwm/pwm-apple.c
Comments
Hi Sasha Finkelstein, Thanks for the patch. > Subject: [PATCH v2 2/4] pwm: Add Apple PWM controller > > Adds the Apple PWM controller driver. > > Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com> > --- > drivers/pwm/Kconfig | 12 ++++ > drivers/pwm/Makefile | 1 + > drivers/pwm/pwm-apple.c | 127 > ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 140 insertions(+) > create mode 100644 drivers/pwm/pwm-apple.c > > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig index > 60d13a949bc5..c3be11468414 100644 > --- a/drivers/pwm/Kconfig > +++ b/drivers/pwm/Kconfig > @@ -51,6 +51,18 @@ config PWM_AB8500 > To compile this driver as a module, choose M here: the module > will be called pwm-ab8500. > > +config PWM_APPLE > + tristate "Apple SoC PWM support" > + depends on ARCH_APPLE || COMPILE_TEST > + help > + Generic PWM framework driver for PWM controller present on > + Apple SoCs > + > + Say Y here if you have an ARM Apple laptop, otherwise say N > + > + To compile this driver as a module, choose M here: the module > + will be called pwm-apple. > + > config PWM_ATMEL > tristate "Atmel PWM support" > depends on ARCH_AT91 || COMPILE_TEST > diff --git a/drivers/pwm/Makefile b/drivers/pwm/Makefile index > 7bf1a29f02b8..19899b912e00 100644 > --- a/drivers/pwm/Makefile > +++ b/drivers/pwm/Makefile > @@ -2,6 +2,7 @@ > obj-$(CONFIG_PWM) += core.o > obj-$(CONFIG_PWM_SYSFS) += sysfs.o > obj-$(CONFIG_PWM_AB8500) += pwm-ab8500.o > +obj-$(CONFIG_PWM_APPLE) += pwm-apple.o > obj-$(CONFIG_PWM_ATMEL) += pwm-atmel.o > obj-$(CONFIG_PWM_ATMEL_HLCDC_PWM) += pwm-atmel-hlcdc.o > obj-$(CONFIG_PWM_ATMEL_TCB) += pwm-atmel-tcb.o > diff --git a/drivers/pwm/pwm-apple.c b/drivers/pwm/pwm-apple.c new > file mode 100644 index 000000000000..7b2936346f4e > --- /dev/null > +++ b/drivers/pwm/pwm-apple.c > @@ -0,0 +1,127 @@ > +// SPDX-License-Identifier: GPL-2.0 OR MIT > +/* > + * Driver for the Apple SoC PWM controller > + * > + * Copyright The Asahi Linux Contributors */ > + > +#include <linux/module.h> > +#include <linux/of.h> > +#include <linux/of_device.h> > +#include <linux/platform_device.h> > +#include <linux/pwm.h> > +#include <linux/io.h> > +#include <linux/clk.h> > +#include <linux/pm_runtime.h> > +#include <linux/math64.h> May be sort header alphabetically?? > + > +#define PWM_CONTROL 0x00 > +#define PWM_ON_CYCLES 0x1c > +#define PWM_OFF_CYCLES 0x18 > + > +#define CTRL_ENABLE BIT(0) > +#define CTRL_MODE BIT(2) > +#define CTRL_UPDATE BIT(5) > +#define CTRL_TRIGGER BIT(9) > +#define CTRL_INVERT BIT(10) > +#define CTRL_OUTPUT_ENABLE BIT(14) > + > +struct apple_pwm { > + struct pwm_chip chip; > + void __iomem *base; > + u64 clkrate; > +}; > + > +static int apple_pwm_apply(struct pwm_chip *chip, struct pwm_device > *pwm, > + const struct pwm_state *state) > +{ > + struct apple_pwm *fpwm; > + u64 on_cycles, off_cycles; > + > + fpwm = container_of(chip, struct apple_pwm, chip); > + if (state->enabled) { > + on_cycles = mul_u64_u64_div_u64(fpwm->clkrate, > + state->duty_cycle, NSEC_PER_SEC); > + off_cycles = mul_u64_u64_div_u64(fpwm->clkrate, > + state->period, NSEC_PER_SEC) - > on_cycles; > + writel(on_cycles, fpwm->base + PWM_ON_CYCLES); > + writel(off_cycles, fpwm->base + PWM_OFF_CYCLES); > + writel(CTRL_ENABLE | CTRL_OUTPUT_ENABLE | CTRL_UPDATE, > + fpwm->base + PWM_CONTROL); > + } else { > + writel(0, fpwm->base + PWM_CONTROL); > + } > + return 0; > +} > + > +static void apple_pwm_get_state(struct pwm_chip *chip, struct > pwm_device *pwm, > + struct pwm_state *state) > +{ > + struct apple_pwm *fpwm; > + u32 on_cycles, off_cycles, ctrl; > + > + fpwm = container_of(chip, struct apple_pwm, chip); > + > + ctrl = readl(fpwm->base + PWM_CONTROL); > + on_cycles = readl(fpwm->base + PWM_ON_CYCLES); > + off_cycles = readl(fpwm->base + PWM_OFF_CYCLES); > + > + state->enabled = (ctrl & CTRL_ENABLE) && (ctrl & > CTRL_OUTPUT_ENABLE); > + state->polarity = PWM_POLARITY_NORMAL; > + state->duty_cycle = div_u64(on_cycles, fpwm->clkrate) * > NSEC_PER_SEC; > + state->period = div_u64(off_cycles + on_cycles, fpwm->clkrate) * > +NSEC_PER_SEC; } > + > +static const struct pwm_ops apple_pwm_ops = { > + .apply = apple_pwm_apply, > + .get_state = apple_pwm_get_state, > + .owner = THIS_MODULE, > +}; > + > +static int apple_pwm_probe(struct platform_device *pdev) { > + struct apple_pwm *pwm; > + struct clk *clk; > + int ret; > + > + pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); > + if (!pwm) > + return -ENOMEM; > + > + pwm->base = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(pwm->base)) > + return PTR_ERR(pwm->base); > + > + platform_set_drvdata(pdev, pwm); > + > + clk = devm_clk_get_enabled(&pdev->dev, NULL); > + if (IS_ERR(clk)) > + return PTR_ERR(clk); What is your use case? PWM is configured by bootloader intially?? Or PWM is configured by Linux not by the bootloader? Or Driver needs to support both ?? Cheers, Biju > + > + pwm->clkrate = clk_get_rate(clk); > + pwm->chip.dev = &pdev->dev; > + pwm->chip.npwm = 1; > + pwm->chip.ops = &apple_pwm_ops; > + > + ret = devm_pwmchip_add(&pdev->dev, &pwm->chip); > + return ret; > +} > + > +static const struct of_device_id apple_pwm_of_match[] = { > + { .compatible = "apple,s5l-fpwm" }, > + {} > +}; > +MODULE_DEVICE_TABLE(of, apple_pwm_of_match); > + > +static struct platform_driver apple_pwm_driver = { > + .probe = apple_pwm_probe, > + .driver = { > + .name = "apple-pwm", > + .owner = THIS_MODULE, > + .of_match_table = apple_pwm_of_match, > + }, > +}; > +module_platform_driver(apple_pwm_driver); > + > +MODULE_DESCRIPTION("Apple SoC PWM driver"); MODULE_LICENSE("Dual > +MIT/GPL"); > -- > 2.37.3 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists > .infradead.org%2Fmailman%2Flistinfo%2Flinux-arm- > kernel&data=05%7C01%7Cbiju.das.jz%40bp.renesas.com%7C0ff5a9275b954 > eff39ae08dabcde3c28%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C63802 > 9959918512569%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2lu > MzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=zdoRENBcN > FUDLdqC8wOspyvoOzRsTkBkS01Q8ff9okk%3D&reserved=0
On Wed, 2 Nov 2022 at 18:33, Biju Das <biju.das.jz@bp.renesas.com> wrote: > > + clk = devm_clk_get_enabled(&pdev->dev, NULL); > > + if (IS_ERR(clk)) > > + return PTR_ERR(clk); > > What is your use case? > > PWM is configured by bootloader intially?? > > Or > > PWM is configured by Linux not by the bootloader? > > Or > > Driver needs to support both ?? The PWM device itself is configured by linux, but the clock it uses is the systemwide 24 MHz clock, and that is configured by platform firmware.
> Subject: Re: [PATCH v2 2/4] pwm: Add Apple PWM controller > > On Wed, 2 Nov 2022 at 18:33, Biju Das <biju.das.jz@bp.renesas.com> > wrote: > > > + clk = devm_clk_get_enabled(&pdev->dev, NULL); > > > + if (IS_ERR(clk)) > > > + return PTR_ERR(clk); > > > > What is your use case? > > > > PWM is configured by bootloader intially?? > > > > Or > > > > PWM is configured by Linux not by the bootloader? > > > > Or > > > > Driver needs to support both ?? > > The PWM device itself is configured by linux, but the clock it uses is > the systemwide 24 MHz clock, and that is configured by platform > firmware. I just asked, because you are unnecessarily turning on the clock or increasing the usage Count, even if it is not used by anyone during probe. Cheers, Biju
On Wed, 2 Nov 2022 at 19:02, Biju Das <biju.das.jz@bp.renesas.com> wrote: > I just asked, because you are unnecessarily turning on the clock or increasing the usage > Count, even if it is not used by anyone during probe. It is used to get the clock rate so it can be used to convert between seconds and pwm ticks, and the pwm uses that clock, so it is kept enabled while the pwm is active.
> Subject: Re: [PATCH v2 2/4] pwm: Add Apple PWM controller > > On Wed, 2 Nov 2022 at 19:02, Biju Das <biju.das.jz@bp.renesas.com> > wrote: > > > I just asked, because you are unnecessarily turning on the clock or > > increasing the usage Count, even if it is not used by anyone during > probe. > > It is used to get the clock rate so it can be used to convert between > seconds and pwm ticks, and the pwm uses that clock, so it is kept > enabled while the pwm is active. You don't need to enable the pwm clock for getting the clock rate. devm_clk_get() and then get the rate. Then enable the clk whenever pwm is enabled And disable the clk whenever pwm is disabled. Cheers, Biju
On Wed, 2 Nov 2022 at 19:29, Biju Das <biju.das.jz@bp.renesas.com> wrote: > > Then enable the clk whenever pwm is enabled > And disable the clk whenever pwm is disabled. I can do that, but I do not see the point in doing that. This clock is active whenever the system is turned on, all this will result in is some unnecessary clock refcount increments/decrements.
> Subject: Re: [PATCH v2 2/4] pwm: Add Apple PWM controller > > On Wed, 2 Nov 2022 at 19:29, Biju Das <biju.das.jz@bp.renesas.com> > wrote: > > > > Then enable the clk whenever pwm is enabled And disable the clk > > whenever pwm is disabled. > I can do that, but I do not see the point in doing that. This clock is > active whenever the system is turned on, all this will result in is > some unnecessary clock refcount increments/decrements. OK for me, as I do not know about your system. I just pointed out you are unnecessarily turning on the clock during probe even if the pwm is not used. Cheers, Biju
Hi, On Wed, Nov 2, 2022, at 15:15, Sasha Finkelstein wrote: > Hi, > > This is the v2 of the patch series to add PWM and keyboard backlight > drivers for ARM macs. The changes from v1 address the review > comments on that patch set. > > v1: https://www.spinics.net/lists/linux-pwm/msg19500.html > > Best Regards. > > Sasha Finkelstein (4): > dt-bindings: pwm: Add Apple PWM controller > pwm: Add Apple PWM controller > arm64: dts: apple: t8103: Add PWM controller > MAINTAINERS: Add entries for Apple PWM driver > > .../bindings/pwm/apple,s5l-fpwm.yaml | 51 +++++++ > MAINTAINERS | 2 + > arch/arm64/boot/dts/apple/t8103-j293.dts | 20 +++ > arch/arm64/boot/dts/apple/t8103-j313.dts | 20 +++ > arch/arm64/boot/dts/apple/t8103.dtsi | 9 ++ > drivers/pwm/Kconfig | 12 ++ > drivers/pwm/Makefile | 1 + > drivers/pwm/pwm-apple.c | 127 ++++++++++++++++++ > 8 files changed, 242 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml > create mode 100644 drivers/pwm/pwm-apple.c > > -- > 2.37.3 this looks good to me, entire series: Acked-by: Sven Peter <sven@svenpeter.dev> Best, Sven