mbox series

[RESEND,v5,0/4] drivers: misc: Add support for TMR Manager and Inject IPs

Message ID 20221028090106.1456940-1-appana.durga.kedareswara.rao@amd.com
Headers
Series drivers: misc: Add support for TMR Manager and Inject IPs |

Message

Appana Durga Kedareswara rao Oct. 28, 2022, 9:01 a.m. UTC 
  This patch series adds support for TMR Manager and TMR Inject IPs.
The TMR Manager is responsible for handling the TMR subsystem state,
including fault detection and error recovery. The core is triplicated
in each of the sub-blocks in the TMR subsystem, and provides majority
voting of its internal state.
The TMR Inject core provides functional fault injection by changing
selected MicroBlaze instructions, which provides the possibility to
verify that the TMR subsystem error detection and fault recovery logic
is working properly.

For more details about TMR Manager and Inject IPs please refer PG268[1].

[1]: https://docs.xilinx.com/r/en-US/pg268-tmr/Triple-Modular-Redundancy-TMR-v1.0-LogiCORE-IP-Product-Guide-PG268

Appana Durga Kedareswara rao (4):
  dt-bindings: misc: tmr-manager: Add device-tree binding for TMR
    Manager
  drivers: misc: Add Support for TMR Manager
  dt-bindings: misc: tmr-inject: Add device-tree binding for TMR Inject
  drivers: misc: Add Support for TMR Inject IP

 .../testing/sysfs-driver-xilinx-tmr-manager   |  16 ++
 .../bindings/misc/xlnx,tmr-inject.yaml        |  47 ++++
 .../bindings/misc/xlnx,tmr-manager.yaml       |  47 ++++
 MAINTAINERS                                   |  13 ++
 drivers/misc/Kconfig                          |  20 ++
 drivers/misc/Makefile                         |   2 +
 drivers/misc/xilinx_tmr_inject.c              | 171 ++++++++++++++
 drivers/misc/xilinx_tmr_manager.c             | 220 ++++++++++++++++++
 8 files changed, 536 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-driver-xilinx-tmr-manager
 create mode 100644 Documentation/devicetree/bindings/misc/xlnx,tmr-inject.yaml
 create mode 100644 Documentation/devicetree/bindings/misc/xlnx,tmr-manager.yaml
 create mode 100644 drivers/misc/xilinx_tmr_inject.c
 create mode 100644 drivers/misc/xilinx_tmr_manager.c

Comments

Greg KH Oct. 28, 2022, 9:09 a.m. UTC | #1 
On Fri, Oct 28, 2022 at 02:31:02PM +0530, Appana Durga Kedareswara rao wrote:
> This patch series adds support for TMR Manager and TMR Inject IPs.
> The TMR Manager is responsible for handling the TMR subsystem state,
> including fault detection and error recovery. The core is triplicated
> in each of the sub-blocks in the TMR subsystem, and provides majority
> voting of its internal state.
> The TMR Inject core provides functional fault injection by changing
> selected MicroBlaze instructions, which provides the possibility to
> verify that the TMR subsystem error detection and fault recovery logic
> is working properly.
> 
> For more details about TMR Manager and Inject IPs please refer PG268[1].
> 
> [1]: https://docs.xilinx.com/r/en-US/pg268-tmr/Triple-Modular-Redundancy-TMR-v1.0-LogiCORE-IP-Product-Guide-PG268
> 
> Appana Durga Kedareswara rao (4):
>   dt-bindings: misc: tmr-manager: Add device-tree binding for TMR
>     Manager
>   drivers: misc: Add Support for TMR Manager
>   dt-bindings: misc: tmr-inject: Add device-tree binding for TMR Inject
>   drivers: misc: Add Support for TMR Inject IP

Why is this a RESEND?

What happened to the first v5 series?

confused,

greg k-h
Rao, Appana Durga Kedareswara Oct. 28, 2022, 9:23 a.m. UTC | #2 
Hi Greg,


On 28/10/22 2:39 pm, Greg KH wrote:
> On Fri, Oct 28, 2022 at 02:31:02PM +0530, Appana Durga Kedareswara rao wrote:
>> This patch series adds support for TMR Manager and TMR Inject IPs.
>> The TMR Manager is responsible for handling the TMR subsystem state,
>> including fault detection and error recovery. The core is triplicated
>> in each of the sub-blocks in the TMR subsystem, and provides majority
>> voting of its internal state.
>> The TMR Inject core provides functional fault injection by changing
>> selected MicroBlaze instructions, which provides the possibility to
>> verify that the TMR subsystem error detection and fault recovery logic
>> is working properly.
>>
>> For more details about TMR Manager and Inject IPs please refer PG268[1].
>>
>> [1]: https://docs.xilinx.com/r/en-US/pg268-tmr/Triple-Modular-Redundancy-TMR-v1.0-LogiCORE-IP-Product-Guide-PG268
>>
>> Appana Durga Kedareswara rao (4):
>>    dt-bindings: misc: tmr-manager: Add device-tree binding for TMR
>>      Manager
>>    drivers: misc: Add Support for TMR Manager
>>    dt-bindings: misc: tmr-inject: Add device-tree binding for TMR Inject
>>    drivers: misc: Add Support for TMR Inject IP
> 
> Why is this a RESEND?
> 
> What happened to the first v5 series? >

Haven't received any review comments for v5 and it's been month that i 
have sent v5, so rebased the patches on top of latest tree and resend.
Should i post v6 instead of RESEND?

Regards,
Kedar.
> confused,
> 
> greg k-h