Message ID | 20221026144208.373504-1-xianting.tian@linux.alibaba.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp312866wru; Wed, 26 Oct 2022 07:53:21 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6E2CJPScR3G1412Qe4IsnaBzMEgucg9jM7AqjA2cexAUkzQxPcezDPuUgWJl6dzB+gCNhz X-Received: by 2002:aa7:cc8a:0:b0:45b:f851:2943 with SMTP id p10-20020aa7cc8a000000b0045bf8512943mr41988293edt.103.1666796001499; Wed, 26 Oct 2022 07:53:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666796001; cv=none; d=google.com; s=arc-20160816; b=RbDa042QIOxmWgMgXDycVcRsEY1nrEISle+uvuxj0DlSuU6ImJc7xIsPRoxeybWexh iEUqeoa/hbNJ0DpYH4dKGng9tpRiSc1IivsumT+hO8yxQduGlDF06xuNWDnUHN3wJkTl CL5w786+VR7EN6d0ebIFoKVAlD35RkRCRetpsMKqYdPYsh7XoMucTS8q6dQxa0rpFKtH rW80Ve86zyQ6EUyeaBpBqgi1PLwykkxsPhikG9siDcIzaRXZh4aU8qpIzTEnyJ1fM4ds EJ1YLTFJ+1EHJDEL4tQjOCSHsl+9x2t4ebU3m01GQevE6hOXfxEKHH2SLE1EzODgYj13 kS4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=thOqSx3DCHbsEAYefztKoHkMlm/nTZH2075hsoSiVX4=; b=P8ZSN8Jdr8Eo8QvcizDGq7axxTTw5Ip+kQwAPG5/x6XUeZ2AdAXDm13pYOGO26umZ4 0OngeIXVV2fCqu8q97wjWqWtWa6F+wjMQNaGOBO34+js2tEo1JuKc13zs6uNnURQe4NX VkwBM8NL+ELqjjeSEdShN09lRpLoZeZjzS+aF7FhZeQ74F9O39S6zDmAkvhsdziRm9mz 4Su3fO+ddgmmnvf0a7lbfxm1xowEQF90KVmoHd0Rrj/aEy8RguQGRKwYzecOQLHmPiSA Rob/xPaq1dLRU/iOHwAZO/bMhm4f9YCXEEuyYIhV0Aq6tvWhj3Peqdkm9lELqkqkwIIG pxRQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x27-20020a50d61b000000b004615ccd71a0si6358813edi.162.2022.10.26.07.52.53; Wed, 26 Oct 2022 07:53:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233895AbiJZOmo (ORCPT <rfc822;pwkd43@gmail.com> + 99 others); Wed, 26 Oct 2022 10:42:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233708AbiJZOme (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 26 Oct 2022 10:42:34 -0400 Received: from out30-44.freemail.mail.aliyun.com (out30-44.freemail.mail.aliyun.com [115.124.30.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4736DEF3C; Wed, 26 Oct 2022 07:42:32 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=xianting.tian@linux.alibaba.com;NM=1;PH=DS;RN=24;SR=0;TI=SMTPD_---0VT7dcjL_1666795330; Received: from localhost.localdomain(mailfrom:xianting.tian@linux.alibaba.com fp:SMTPD_---0VT7dcjL_1666795330) by smtp.aliyun-inc.com; Wed, 26 Oct 2022 22:42:23 +0800 From: Xianting Tian <xianting.tian@linux.alibaba.com> To: paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, anup@brainfault.org, heiko@sntech.de, guoren@kernel.org, mick@ics.forth.gr, alexandre.ghiti@canonical.com, bhe@redhat.com, vgoyal@redhat.com, dyoung@redhat.com, corbet@lwn.net, Conor.Dooley@microchip.com, bagasdotme@gmail.com Cc: kexec@lists.infradead.org, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, crash-utility@redhat.com, heinrich.schuchardt@canonical.com, k-hagio-ab@nec.com, hschauhan@nulltrace.org, yixun.lan@gmail.com, Xianting Tian <xianting.tian@linux.alibaba.com> Subject: [PATCH V5 0/2] Support VMCOREINFO export for RISCV64 Date: Wed, 26 Oct 2022 22:42:06 +0800 Message-Id: <20221026144208.373504-1-xianting.tian@linux.alibaba.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747762283966261275?= X-GMAIL-MSGID: =?utf-8?q?1747762283966261275?= |
Series |
Support VMCOREINFO export for RISCV64
|
|
Message
Xianting Tian
Oct. 26, 2022, 2:42 p.m. UTC
As disscussed in below patch set, the patch of 'describe VMCOREINFO export in Documentation' need to update according to Bagas's comments. https://lore.kernel.org/linux-riscv/22AAF52E-8CC8-4D11-99CB-88DE4D113444@kernel.org/ As others patches in above patch set already applied, so this patch set only contains below two patches. ------ Changes: Fix commit message in patch 2: use "Document these RISCV64 exports above" instead of "This patch just add the description of VMCOREINFO export for RISCV64." V1 -> V2: Remove unnecessary overline above header text in patch 2. V2 -> V3: Fix commit message in patch 1,2; Use 'space' instead of 'region' for vmemmap description in patch 2. V3 -> V4: Remove unnecessary kernel space export: KASAN_SHADOW_START ~ KASAN_SHADOW_END, ADDRESS_SPACE_END V4 -> V5: Remove IS_ENABLED() judgement for KERNEL_LINK_ADDR in patch 1. Xianting Tian (2): RISC-V: Add arch_crash_save_vmcoreinfo support Documentation: kdump: describe VMCOREINFO export for RISCV64 .../admin-guide/kdump/vmcoreinfo.rst | 29 +++++++++++++++++++ arch/riscv/kernel/Makefile | 1 + arch/riscv/kernel/crash_core.c | 21 ++++++++++++++ 3 files changed, 51 insertions(+) create mode 100644 arch/riscv/kernel/crash_core.c
Comments
On 10/26/22 at 10:42pm, Xianting Tian wrote: > As disscussed in below patch set, the patch of 'describe VMCOREINFO export in Documentation' > need to update according to Bagas's comments. > https://lore.kernel.org/linux-riscv/22AAF52E-8CC8-4D11-99CB-88DE4D113444@kernel.org/ > > As others patches in above patch set already applied, so this patch set only contains below two > patches. > > ------ > Changes: > Fix commit message in patch 2: use "Document these RISCV64 exports above" instead of > "This patch just add the description of VMCOREINFO export for RISCV64." > V1 -> V2: > Remove unnecessary overline above header text in patch 2. > V2 -> V3: > Fix commit message in patch 1,2; > Use 'space' instead of 'region' for vmemmap description in patch 2. > V3 -> V4: > Remove unnecessary kernel space export: > KASAN_SHADOW_START ~ KASAN_SHADOW_END, > ADDRESS_SPACE_END > V4 -> V5: > Remove IS_ENABLED() judgement for KERNEL_LINK_ADDR in patch 1. This series looks good to me, thanks. Acked-by: Baoquan He <bhe@redhat.com>
Hi risc-v maintainers, On 10/26/22 at 10:42pm, Xianting Tian wrote: > As disscussed in below patch set, the patch of 'describe VMCOREINFO export in Documentation' > need to update according to Bagas's comments. > https://lore.kernel.org/linux-riscv/22AAF52E-8CC8-4D11-99CB-88DE4D113444@kernel.org/ > > As others patches in above patch set already applied, so this patch set only contains below two > patches. Could you pick this patchset into risc-v tree since it has got acks and two Tested-by? Thanks Baoquan
On Wed, 26 Oct 2022 22:42:06 +0800, Xianting Tian wrote: > As disscussed in below patch set, the patch of 'describe VMCOREINFO export in Documentation' > need to update according to Bagas's comments. > https://lore.kernel.org/linux-riscv/22AAF52E-8CC8-4D11-99CB-88DE4D113444@kernel.org/ > > As others patches in above patch set already applied, so this patch set only contains below two > patches. > > [...] Applied, thanks! [1/2] RISC-V: Add arch_crash_save_vmcoreinfo support https://git.kernel.org/palmer/c/649d6b1019a2 [2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64 https://git.kernel.org/palmer/c/c5b4216929eb Best regards,
Hello: This series was applied to riscv/linux.git (for-next) by Palmer Dabbelt <palmer@rivosinc.com>: On Wed, 26 Oct 2022 22:42:06 +0800 you wrote: > As disscussed in below patch set, the patch of 'describe VMCOREINFO export in Documentation' > need to update according to Bagas's comments. > https://lore.kernel.org/linux-riscv/22AAF52E-8CC8-4D11-99CB-88DE4D113444@kernel.org/ > > As others patches in above patch set already applied, so this patch set only contains below two > patches. > > [...] Here is the summary with links: - [V5,1/2] RISC-V: Add arch_crash_save_vmcoreinfo support https://git.kernel.org/riscv/c/649d6b1019a2 - [V5,2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64 https://git.kernel.org/riscv/c/c5b4216929eb You are awesome, thank you!
Hi Palmer, Here are another two fix-up patches of kdump for the crash tool. https://lore.kernel.org/linux-riscv/20221020141603.2856206-3-guoren@kernel.org/ https://lore.kernel.org/linux-riscv/20221020141603.2856206-2-guoren@kernel.org/ On Sat, Dec 3, 2022 at 8:56 AM Palmer Dabbelt <palmer@rivosinc.com> wrote: > > On Wed, 26 Oct 2022 22:42:06 +0800, Xianting Tian wrote: > > As disscussed in below patch set, the patch of 'describe VMCOREINFO export in Documentation' > > need to update according to Bagas's comments. > > https://lore.kernel.org/linux-riscv/22AAF52E-8CC8-4D11-99CB-88DE4D113444@kernel.org/ > > > > As others patches in above patch set already applied, so this patch set only contains below two > > patches. > > > > [...] > > Applied, thanks! > > [1/2] RISC-V: Add arch_crash_save_vmcoreinfo support > https://git.kernel.org/palmer/c/649d6b1019a2 > [2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64 > https://git.kernel.org/palmer/c/c5b4216929eb > > Best regards, > -- > Palmer Dabbelt <palmer@rivosinc.com>
Hey Palmer, Xianting, On Fri, Dec 02, 2022 at 04:49:39PM -0800, Palmer Dabbelt wrote: > On Wed, 26 Oct 2022 22:42:06 +0800, Xianting Tian wrote: > > As disscussed in below patch set, the patch of 'describe VMCOREINFO export in Documentation' > > need to update according to Bagas's comments. > > https://lore.kernel.org/linux-riscv/22AAF52E-8CC8-4D11-99CB-88DE4D113444@kernel.org/ > > > > As others patches in above patch set already applied, so this patch set only contains below two > > patches. > > > > [...] > > Applied, thanks! > > [1/2] RISC-V: Add arch_crash_save_vmcoreinfo support > https://git.kernel.org/palmer/c/649d6b1019a2 So this patch seems to be causing issues for the nommu build: https://lore.kernel.org/oe-kbuild-all/202212062250.tR0otHcz-lkp@intel.com/ I had a bit of a poke at trying to see if there were some headers we could pull in before actually checking the .config only to see: # CONFIG_MMU is not set Do we have to wrap the whole thing in a `#ifdef CONFIG_MMU` to fix compilation here? Thanks, Conor.
On Wed, Dec 7, 2022 at 7:05 AM Conor Dooley <conor@kernel.org> wrote: > > Hey Palmer, Xianting, > > On Fri, Dec 02, 2022 at 04:49:39PM -0800, Palmer Dabbelt wrote: > > On Wed, 26 Oct 2022 22:42:06 +0800, Xianting Tian wrote: > > > As disscussed in below patch set, the patch of 'describe VMCOREINFO export in Documentation' > > > need to update according to Bagas's comments. > > > https://lore.kernel.org/linux-riscv/22AAF52E-8CC8-4D11-99CB-88DE4D113444@kernel.org/ > > > > > > As others patches in above patch set already applied, so this patch set only contains below two > > > patches. > > > > > > [...] > > > > Applied, thanks! > > > > [1/2] RISC-V: Add arch_crash_save_vmcoreinfo support > > https://git.kernel.org/palmer/c/649d6b1019a2 > > So this patch seems to be causing issues for the nommu build: > https://lore.kernel.org/oe-kbuild-all/202212062250.tR0otHcz-lkp@intel.com/ > > I had a bit of a poke at trying to see if there were some headers we > could pull in before actually checking the .config only to see: > # CONFIG_MMU is not set > > Do we have to wrap the whole thing in a `#ifdef CONFIG_MMU` to fix > compilation here? The problem does not belong to the patch. Could I send a fixup patch? like this? diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index ef8d66de5f38..d8c07999426c 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -512,6 +512,7 @@ config ARCH_HAS_KEXEC_PURGATORY config CRASH_DUMP bool "Build kdump crash kernel" + depends on KEXEC help Generate crash dump after being started by kexec. This should be normally only set in special crash dump kernels which are > > Thanks, > Conor. >
On Wed, Dec 07, 2022 at 11:34:57AM +0800, Guo Ren wrote: > On Wed, Dec 7, 2022 at 7:05 AM Conor Dooley <conor@kernel.org> wrote: > > > > Hey Palmer, Xianting, > > > > On Fri, Dec 02, 2022 at 04:49:39PM -0800, Palmer Dabbelt wrote: > > > On Wed, 26 Oct 2022 22:42:06 +0800, Xianting Tian wrote: > > > > As disscussed in below patch set, the patch of 'describe VMCOREINFO export in Documentation' > > > > need to update according to Bagas's comments. > > > > https://lore.kernel.org/linux-riscv/22AAF52E-8CC8-4D11-99CB-88DE4D113444@kernel.org/ > > > > > > > > As others patches in above patch set already applied, so this patch set only contains below two > > > > patches. > > > > > > > > [...] > > > > > > Applied, thanks! > > > > > > [1/2] RISC-V: Add arch_crash_save_vmcoreinfo support > > > https://git.kernel.org/palmer/c/649d6b1019a2 > > > > So this patch seems to be causing issues for the nommu build: > > https://lore.kernel.org/oe-kbuild-all/202212062250.tR0otHcz-lkp@intel.com/ > > > > I had a bit of a poke at trying to see if there were some headers we > > could pull in before actually checking the .config only to see: > > # CONFIG_MMU is not set > > > > Do we have to wrap the whole thing in a `#ifdef CONFIG_MMU` to fix > > compilation here? > The problem does not belong to the patch. > > Could I send a fixup patch? like this? That seems like a sane dependancy, but did you build that config? This doesn't fix the problem for me :/ > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index ef8d66de5f38..d8c07999426c 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -512,6 +512,7 @@ config ARCH_HAS_KEXEC_PURGATORY > > config CRASH_DUMP > bool "Build kdump crash kernel" > + depends on KEXEC > help > Generate crash dump after being started by kexec. This should > be normally only set in special crash dump kernels which are > > > > > Thanks, > > Conor. > > > > > -- > Best Regards > Guo Ren
On Wed, Dec 7, 2022 at 4:08 PM Conor Dooley <conor@kernel.org> wrote: > > On Wed, Dec 07, 2022 at 11:34:57AM +0800, Guo Ren wrote: > > On Wed, Dec 7, 2022 at 7:05 AM Conor Dooley <conor@kernel.org> wrote: > > > > > > Hey Palmer, Xianting, > > > > > > On Fri, Dec 02, 2022 at 04:49:39PM -0800, Palmer Dabbelt wrote: > > > > On Wed, 26 Oct 2022 22:42:06 +0800, Xianting Tian wrote: > > > > > As disscussed in below patch set, the patch of 'describe VMCOREINFO export in Documentation' > > > > > need to update according to Bagas's comments. > > > > > https://lore.kernel.org/linux-riscv/22AAF52E-8CC8-4D11-99CB-88DE4D113444@kernel.org/ > > > > > > > > > > As others patches in above patch set already applied, so this patch set only contains below two > > > > > patches. > > > > > > > > > > [...] > > > > > > > > Applied, thanks! > > > > > > > > [1/2] RISC-V: Add arch_crash_save_vmcoreinfo support > > > > https://git.kernel.org/palmer/c/649d6b1019a2 > > > > > > So this patch seems to be causing issues for the nommu build: > > > https://lore.kernel.org/oe-kbuild-all/202212062250.tR0otHcz-lkp@intel.com/ > > > > > > I had a bit of a poke at trying to see if there were some headers we > > > could pull in before actually checking the .config only to see: > > > # CONFIG_MMU is not set > > > > > > Do we have to wrap the whole thing in a `#ifdef CONFIG_MMU` to fix > > > compilation here? > > The problem does not belong to the patch. > > > > Could I send a fixup patch? like this? > > That seems like a sane dependancy, but did you build that config? > This doesn't fix the problem for me :/ Sorry, It's the wrong fixup. Here is the new version, and tested. Thx for the report. https://lore.kernel.org/linux-riscv/20221207091112.2258674-1-guoren@kernel.org/ > > > > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > > index ef8d66de5f38..d8c07999426c 100644 > > --- a/arch/riscv/Kconfig > > +++ b/arch/riscv/Kconfig > > @@ -512,6 +512,7 @@ config ARCH_HAS_KEXEC_PURGATORY > > > > config CRASH_DUMP > > bool "Build kdump crash kernel" > > + depends on KEXEC > > help > > Generate crash dump after being started by kexec. This should > > be normally only set in special crash dump kernels which are > > > > > > > > Thanks, > > > Conor. > > > > > > > > > -- > > Best Regards > > Guo Ren