From patchwork Tue Oct 25 10:50:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaron Conole X-Patchwork-Id: 653 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp936707wru; Tue, 25 Oct 2022 04:02:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6W5bMtz8sWTJ8WtAOaTUxxaqxD1dx8GfkhVM11bhlV40gA45Onh9H0Z94xQQ7Dd/58LzEc X-Received: by 2002:a17:907:8a27:b0:78e:274e:9235 with SMTP id sc39-20020a1709078a2700b0078e274e9235mr32184758ejc.754.1666695777719; Tue, 25 Oct 2022 04:02:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666695777; cv=none; d=google.com; s=arc-20160816; b=G+KWb1tPxjPNLETQpNJx7W7dR/NA2NNmMdr7Qy4sh5Ndt8nmxKQE7edjdBbk9GXQuy QiYypkSd4nBtAG9jXhjLr1A1mxWVFxDe3blpg8ZE5bdngXi6q9ER11gu5Fv2U0msxJAO iIwxwTILUcPBtofbV7sLlfFdIZ+thr0oeJFHNyFzlvY/Z3K6c+ePQ8NBCMoQ9DuUZTrT 9zW48fOMPiWqnZlgCZK2tgIUoftvSQITDYpJH3yH/K5xObGicg6qdm5UaLK1BkZ9o2im Rqj9Vp1KT7Aa6NN0Izx1zDffHTwlvmMSd1PZYw3QkzkKjk8xjPe3xbMVHf8vBxXvWeu6 vhhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=pNiueuEunuGnI0CMSpWBepCg2v1habx1MbJneeWWfi4=; b=phuUbzwEBXfPPlZR3YaI9JBKljV9vSTDTsVNsj/Juz71Vy6BHSmVHetELoXOG6LApn B08cAQ84/C/d/h9Fq02T1V/WuzjghffwW5QYMCqCfMhaeKo7aVbZIMnmtKDynSz/GzwM KoM7YH+NalA8bSCPlu3ouRgf86MNaZtq+Xw4NEC+cfsjdOgN97CjdBRcaNN6N2YP6G4p 5/g9UyZUnhgQqGWSMuHNgcGxhdy+xOZrEu0grJm16Wt5WlGBdP5PiKTkVy30g6aDiyqK C51qW1NzQV7aLLfSzvFe8cQAKwraADTM+79d4tbLBdlxawNBojTKaYH0Qd3SR0wVr+cb dczA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=i5tMDy4i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q5-20020a1709064cc500b00789d1d367dcsi568946ejt.281.2022.10.25.04.02.33; Tue, 25 Oct 2022 04:02:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=i5tMDy4i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232470AbiJYKuh (ORCPT + 99 others); Tue, 25 Oct 2022 06:50:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232420AbiJYKu1 (ORCPT ); Tue, 25 Oct 2022 06:50:27 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D38C2DA86 for ; Tue, 25 Oct 2022 03:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666695024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=pNiueuEunuGnI0CMSpWBepCg2v1habx1MbJneeWWfi4=; b=i5tMDy4iaNTzcMq1M49g7rvSaHF6I6jinu5wBStToiBE42fjdB6k9ZtXdDs8aPdaKNFZgU XblxdpN5pl2j2ZI7gOqpNOnTi2HO/ZTQH4jvu5S9mcipLlr3MOBxHU5C5YwNkzceUN3OWe 8TSfp7qnO+G3ZB1ACIRUneZUfl1JWpQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-665-0zY3L0u9NJqOuWlKaIeevw-1; Tue, 25 Oct 2022 06:50:20 -0400 X-MC-Unique: 0zY3L0u9NJqOuWlKaIeevw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 31FF9811E67; Tue, 25 Oct 2022 10:50:20 +0000 (UTC) Received: from RHTPC1VM0NT.redhat.com (unknown [10.22.8.238]) by smtp.corp.redhat.com (Postfix) with ESMTP id 52FA52027061; Tue, 25 Oct 2022 10:50:19 +0000 (UTC) From: Aaron Conole To: netdev@vger.kernel.org Cc: Pravin B Shelar , Jakub Kicinski , "David S. Miller" , Paolo Abeni , Eric Dumazet , Thomas Graf , Kevin Sprague , dev@openvswitch.org, Eelco Chaudron , Ilya Maximets , Shuah Khan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH v2 net 0/2] openvswitch: syzbot splat fix and introduce selftest Date: Tue, 25 Oct 2022 06:50:16 -0400 Message-Id: <20221025105018.466157-1-aconole@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747657191681202267?= X-GMAIL-MSGID: =?utf-8?q?1747657191681202267?= Syzbot recently caught a splat when dropping features from openvswitch datapaths that are in-use. The WARN() call is definitely too large a hammer for the situation, so change to pr_warn. Second patch in the series introduces a new selftest suite which can help show that an issue is fixed. This change might be more suited to net-next tree, so it has been separated out as an additional patch and can be either applied to either tree based on preference. Aaron Conole (2): openvswitch: switch from WARN to pr_warn selftests: add openvswitch selftest suite MAINTAINERS | 1 + net/openvswitch/datapath.c | 3 +- tools/testing/selftests/Makefile | 1 + .../selftests/net/openvswitch/Makefile | 13 + .../selftests/net/openvswitch/openvswitch.sh | 218 +++++++++++ .../selftests/net/openvswitch/ovs-dpctl.py | 351 ++++++++++++++++++ 6 files changed, 586 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/net/openvswitch/Makefile create mode 100755 tools/testing/selftests/net/openvswitch/openvswitch.sh create mode 100644 tools/testing/selftests/net/openvswitch/ovs-dpctl.py