From patchwork Mon Oct 24 08:14:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 575 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp317126wru; Mon, 24 Oct 2022 01:17:56 -0700 (PDT) X-Google-Smtp-Source: AMsMyM78eWFfOTzKocZyP2FnGQs0xf9k9kJcbfmhLfwQCpIGq4wmhjP9r/jfN7YjK3hxqKr+Otxe X-Received: by 2002:a17:906:58cc:b0:78d:ce9c:3787 with SMTP id e12-20020a17090658cc00b0078dce9c3787mr26199378ejs.715.1666599465704; Mon, 24 Oct 2022 01:17:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666599465; cv=none; d=google.com; s=arc-20160816; b=CO+/ITuVMaH3ONzTChMDGItz1BWor2PZ2Pfua+a+MJrxsRXLLa2TQFhiitwijUTNeI b/hfR6fwFsgk2IrDz9BF8hEf2ZlD4PjP23Lhvch1V3Ilk65ldlT2JaElpMOvz0mHl58C 5TwgOB3uGndXJcB1HDKFTTx0pdVO8Z3clyEUyv6A1CQH1SqrfcixF7djTglcLOpEJ1Oh +S+byr5Epb4UaY/zhtEa5WjyIz57es1BKeZjqWx/nV6ekqLr8e3THTU3LmEfRurvf21x +uTGxglZSGI/7mRs4TH9ehBpODZslYPmpNBKXO8xeGFh+Nm1dqyW8tr1jdhPFsg49D1v fGCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=F8CpCLvlkquGwcJwI8u16AqTt0/9utG7eCsNvNXvn74=; b=VcELiUQm9q176dr+ivssucqY/eBg0cxhlP0K9WYWjUVplLlmRweN4RY0wZrb+qiNge DOi7+OQKV4gC+aK2keQPV0yz6FnCsUqBiM0qoQ/o49CPhHzpkR66EjOgggxBQvWDrTqh Zdr8WqZOz3A3lU+fqT7rMggexxpT/VzTTVKRWBUNJdsE5aaOsRufvOTagCJDQTxQe61r HztNVAacmwCYpdw4WKfG0d6XNMgGEKG8wxhPrrHtV2VonTzOh7aKB8kUsgNVL9DMvOTA pp71u/ZnBpIVmyJMwFKuW90fJJ6QGwm4KOKaSplOWpWAUm6jtm7vOp3DekI4IWp5GUW4 kxVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jg15-20020a170907970f00b0077ccad53173si27767082ejc.277.2022.10.24.01.17.21; Mon, 24 Oct 2022 01:17:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230163AbiJXIOn (ORCPT + 99 others); Mon, 24 Oct 2022 04:14:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229949AbiJXIOd (ORCPT ); Mon, 24 Oct 2022 04:14:33 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C30551EAEB for ; Mon, 24 Oct 2022 01:14:29 -0700 (PDT) Received: from ipservice-092-217-079-032.092.217.pools.vodafone-ip.de ([92.217.79.32] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1omsbI-0000nk-Vq; Mon, 24 Oct 2022 10:14:25 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 00/17] staging: r8188eu: clean up mlme handlers Date: Mon, 24 Oct 2022 10:14:00 +0200 Message-Id: <20221024081417.66441-1-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747556201627297578?= X-GMAIL-MSGID: =?utf-8?q?1747556201627297578?= This series cleans up the mlme handlers that process incoming management frames. We can reorder the handler functions and remove forward declarations. We can also remove unused return values and simplify the error handling. This series should be applied after the "some more small cleanups" series. As usual, this series was tested with EdimaxV2 on an arm32 system. Martin Kaiser (17): staging: r8188eu: restructure mlme subfunction handling staging: r8188eu: make OnAssocReq static staging: r8188eu: make OnAssocRsp static staging: r8188eu: make OnProbeReq static staging: r8188eu: make OnProbeRsp static staging: r8188eu: make OnBeacon static staging: r8188eu: make OnDisassoc static staging: r8188eu: make OnAuthClient static staging: r8188eu: make OnDeAuth static staging: r8188eu: make OnAction static staging: r8188eu: make OnAuth static staging: r8188eu: change mlme handlers to void staging: r8188eu: remove unnecessary label staging: r8188eu: remove unnecessary else branch staging: r8188eu: remove unnecessary return staging: r8188eu: remove an else branch staging: r8188eu: go2asoc is not needed drivers/staging/r8188eu/core/rtw_mlme_ext.c | 226 ++++++++---------- .../staging/r8188eu/include/rtw_mlme_ext.h | 23 +- 2 files changed, 100 insertions(+), 149 deletions(-) Tested-by: Philipp Hortmann # Edimax N150